ICEfaces
  1. ICEfaces
  2. ICE-10770

icecore:singleSubmit - Not applied to ice:commandButton

    Details

      Description

      When using the icecore:singleSubmit on the form tag, this is not being applied to the ice:commandButton. On click of the button it is doing a render=@all execute=@all

      With the h:commandButton it is doing a render=@all execute=@this.

        Activity

        Hide
        Arran Mccullough added a comment -

        Attached test case that shows this issue. Note: the icefaces.jar, icefaces-ace.jar, and icefaces-compat.jar files need to be added to the war file to run.

        Steps:

        • Load welcomeICEfaces.jsf
        • Open the browser console to view the submits.
        • Click the ICE Button button, it will show a execute@all and render@all.
        • Click the JSF Button button, it will show a execute@this and render@all.
        Show
        Arran Mccullough added a comment - Attached test case that shows this issue. Note: the icefaces.jar, icefaces-ace.jar, and icefaces-compat.jar files need to be added to the war file to run. Steps: Load welcomeICEfaces.jsf Open the browser console to view the submits. Click the ICE Button button, it will show a execute@all and render@all. Click the JSF Button button, it will show a execute@this and render@all.
        Hide
        Arturo Zambrano added a comment -

        The ice:commandButton component explicitly renders the 'singleSubmit' flag and sets it to 'disabled', which prevents icecore:singleSubmit from handling its click events. This was done under ICE-10169, IPCK-533 and IPCK-532, since ice:commandButton already has a click event handler to submit the form.

        It seems like the intention of icecore:singleSubmit is to give plain HTML elements the ability to make JSF requests. Since, ice:commandButton already has JSF functionalities built-in, icecore:singleSubmit doesn't seem applicable. Perhaps, we could simply add a new 'singleSubmit' attribute to ice:commandButton for making a single submit request (i.e. execute="@this" render="@all", using 'ice.se()').

        Show
        Arturo Zambrano added a comment - The ice:commandButton component explicitly renders the 'singleSubmit' flag and sets it to 'disabled', which prevents icecore:singleSubmit from handling its click events. This was done under ICE-10169 , IPCK-533 and IPCK-532 , since ice:commandButton already has a click event handler to submit the form. It seems like the intention of icecore:singleSubmit is to give plain HTML elements the ability to make JSF requests. Since, ice:commandButton already has JSF functionalities built-in, icecore:singleSubmit doesn't seem applicable. Perhaps, we could simply add a new 'singleSubmit' attribute to ice:commandButton for making a single submit request (i.e. execute="@this" render="@all", using 'ice.se()').
        Hide
        Arturo Zambrano added a comment -

        r48932: added script to check if the ice:commandButton component is affected by icecore:singleSubmit, in which case it won't trigger its own request and will let icecore:singleSubmit operate on it

        Show
        Arturo Zambrano added a comment - r48932: added script to check if the ice:commandButton component is affected by icecore:singleSubmit, in which case it won't trigger its own request and will let icecore:singleSubmit operate on it
        Hide
        Carmen Cristurean added a comment -

        Verified EE-3.3.0-maintenance branch r48953 using attached test case, IE11, FF41, Chrome51.

        Show
        Carmen Cristurean added a comment - Verified EE-3.3.0-maintenance branch r48953 using attached test case, IE11, FF41, Chrome51.

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Arran Mccullough
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: