ICEfaces
  1. ICEfaces
  2. ICE-10733

Remove remaining widgetVar attributes from ACE components

          Details

          • Type: Task Task
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 4.0
          • Fix Version/s: 4.1
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            Any
          • Assignee Priority:
            P2
          • Affects:
            Compatibility/Configuration

            Description

            The introduction of the ice.ace.instance() function replaced the use of widgetVar attributes, which were problematic in their own ways. Some ACE components still have these widgetVar attributes even though they aren't used. These attributes should be removed to avoid confusion.

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Judy Guglielmin added a comment -

              ace:notificationPanel still has widgetVar attribute

              Show
              Judy Guglielmin added a comment - ace:notificationPanel still has widgetVar attribute
              Hide
              Permalink
              Arturo Zambrano added a comment -

              r46188: removed widgetvar code and comments from most components that were still using it
              r46189: removed unused widgetvar attributes from some demos

              The ACE components whose widgetVar attributes and related code got removed are the following: accordion, chart, confirmationDialog, contextMenu, dialog, draggable, droppable, list, listControl, maskedEntry, menu, menuBar, menuButton, notificationPanel, panel, resizable, silderEntry, textAreaEntry, textEntry, and tooltip.

              In the cases of the components listed above, the widgetVar attribute was either only in the Meta class or in other classes but was easily removable, without consequences.

              Testing Notes: please run all regression and showcase tests for the components listed above.

              Show
              Arturo Zambrano added a comment - r46188: removed widgetvar code and comments from most components that were still using it r46189: removed unused widgetvar attributes from some demos The ACE components whose widgetVar attributes and related code got removed are the following: accordion, chart, confirmationDialog, contextMenu, dialog, draggable, droppable, list, listControl, maskedEntry, menu, menuBar, menuButton, notificationPanel, panel, resizable, silderEntry, textAreaEntry, textEntry, and tooltip. In the cases of the components listed above, the widgetVar attribute was either only in the Meta class or in other classes but was easily removable, without consequences. Testing Notes: please run all regression and showcase tests for the components listed above.
              Hide
              Permalink
              Arturo Zambrano added a comment -

              The components left to do are dataTable, dateTimeEntry and tree, whose classes are still dependent on the widgetVar attribute.

              In the case of progressBar, the widgetVar code is easily removable, but its showcase demos make extensive use of the widgetVar.

              Show
              Arturo Zambrano added a comment - The components left to do are dataTable, dateTimeEntry and tree, whose classes are still dependent on the widgetVar attribute. In the case of progressBar, the widgetVar code is easily removable, but its showcase demos make extensive use of the widgetVar.
              Hide
              Permalink
              Carmen Cristurean added a comment -

              ICEfaces4 trunk r46192: removed widgetVar attribute from the QA test applications, and ran regressions for the above mentioned ACE components. Ran also the showcase tests for the same components.

              Show
              Carmen Cristurean added a comment - ICEfaces4 trunk r46192: removed widgetVar attribute from the QA test applications, and ran regressions for the above mentioned ACE components. Ran also the showcase tests for the same components.
              Hide
              Permalink
              Arturo Zambrano added a comment -

              r46203: removed widgetvar code and comments from ace:dataTable, ace:dateTimeEntry, ace:tree, and ace:progressBar; removed widgetvar-related code from CoreRenderer and ComponentUtils and also removed remaining widgetvar-related lines from components that were using such code: ace:accordion, ace:draggable, ace:droppable, ace:maskedEntry, ace:menuButton, ace:notificationPanel, ace:resizable, ace:sliderEntry, ace:submitMonitor, ace:tableConfigPanel, ace:textAreaEntry, ace:textEntry, and ace:tooltip

              r46204: removed remaining widgetvar-related code from the showcase

              Testing notes: please run regression tests on all components affected by these changes, listed above, and report any issues.

              Show
              Arturo Zambrano added a comment - r46203: removed widgetvar code and comments from ace:dataTable, ace:dateTimeEntry, ace:tree, and ace:progressBar; removed widgetvar-related code from CoreRenderer and ComponentUtils and also removed remaining widgetvar-related lines from components that were using such code: ace:accordion, ace:draggable, ace:droppable, ace:maskedEntry, ace:menuButton, ace:notificationPanel, ace:resizable, ace:sliderEntry, ace:submitMonitor, ace:tableConfigPanel, ace:textAreaEntry, ace:textEntry, and ace:tooltip r46204: removed remaining widgetvar-related code from the showcase Testing notes: please run regression tests on all components affected by these changes, listed above, and report any issues.
              Hide
              Permalink
              Arturo Zambrano added a comment -

              r26297: removed remaining widgetvar-related code from the mobi folder and verified no other widgervar code exists anywhere else in the codebase.

              Show
              Arturo Zambrano added a comment - r26297: removed remaining widgetvar-related code from the mobi folder and verified no other widgervar code exists anywhere else in the codebase.
              Hide
              Permalink
              Carmen Cristurean added a comment -

              ICEfaces4 trunk r46216: ran QA regression tests for all components affected by these changes, no issues found except for the ones already reported.

              Show
              Carmen Cristurean added a comment - ICEfaces4 trunk r46216: ran QA regression tests for all components affected by these changes, no issues found except for the ones already reported.
              Hide
              Permalink
              Arturo Zambrano added a comment -

              r46240: ace:tree, fix to ensure that the id rendered to call ice.ace.instance and to re-apply the reordering behaviour is the client id of the root container and not the client if of individual nodes.

              Show
              Arturo Zambrano added a comment - r46240: ace:tree, fix to ensure that the id rendered to call ice.ace.instance and to re-apply the reordering behaviour is the client id of the root container and not the client if of individual nodes.

                People

                • Assignee:
                  Arturo Zambrano
                  Reporter:
                  Arturo Zambrano
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: