ICEfaces
  1. ICEfaces
  2. ICE-10733

Remove remaining widgetVar attributes from ACE components

          Details

          • Type: Task Task
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 4.0
          • Fix Version/s: 4.1
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            Any
          • Assignee Priority:
            P2
          • Affects:
            Compatibility/Configuration

            Description

            The introduction of the ice.ace.instance() function replaced the use of widgetVar attributes, which were problematic in their own ways. Some ACE components still have these widgetVar attributes even though they aren't used. These attributes should be removed to avoid confusion.

              Activity

              Ascending order - Click to sort in descending order
              Arturo Zambrano created issue -
              Arturo Zambrano made changes -
              Field Original Value New Value
              Assignee Arturo Zambrano [ artzambrano ]
              Ken Fyten made changes -
              Assignee Arturo Zambrano [ artzambrano ] Judy Guglielmin [ judy.guglielmin ]
              Fix Version/s 4.1 [ 11375 ]
              Assignee Priority P2 [ 10011 ]
              Arturo Zambrano made changes -
              Assignee Judy Guglielmin [ judy.guglielmin ] Arturo Zambrano [ artzambrano ]
              Hide
              Permalink
              Judy Guglielmin added a comment -

              ace:notificationPanel still has widgetVar attribute

              Show
              Judy Guglielmin added a comment - ace:notificationPanel still has widgetVar attribute
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #46188 Thu Nov 05 15:08:56 MST 2015 art.zambrano ICE-10733 removed widgetvar code and comments from most components that were still using it
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/textentry/TextEntryMeta.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/sliderentry/SliderEntryMeta.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/dnd/DraggableMeta.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/contextmenu/ContextMenuMeta.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/panel/PanelRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/accordion/AccordionMeta.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/panel/PanelMeta.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/confirmationdialog/ConfirmationDialogMeta.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/menubar/MenuBarRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/menubutton/MenuButtonMeta.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/chart/ChartMeta.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/menu/MenuMeta.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/listcontrol/ListControlRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/textareaentry/TextAreaEntryMeta.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/checkboxbutton/checkboxbutton.js
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/maskedentry/MaskedEntryMeta.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/tooltip/TooltipMeta.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/chart/ChartRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/notificationpanel/NotificationPanelMeta.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/dialog/DialogMeta.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/menu/MenuRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/list/ListRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/dnd/DroppableMeta.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/resizable/ResizableMeta.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/contextmenu/ContextMenuRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/radiobutton/radiobutton.js
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/menubar/MenuBarMeta.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #46189 Thu Nov 05 15:10:27 MST 2015 art.zambrano ICE-10733 removed unused widgetvar attributes from some demos
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/chart/chartCandlestick.xhtml
              Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/core/push.xhtml
              Hide
              Permalink
              Arturo Zambrano added a comment -

              r46188: removed widgetvar code and comments from most components that were still using it
              r46189: removed unused widgetvar attributes from some demos

              The ACE components whose widgetVar attributes and related code got removed are the following: accordion, chart, confirmationDialog, contextMenu, dialog, draggable, droppable, list, listControl, maskedEntry, menu, menuBar, menuButton, notificationPanel, panel, resizable, silderEntry, textAreaEntry, textEntry, and tooltip.

              In the cases of the components listed above, the widgetVar attribute was either only in the Meta class or in other classes but was easily removable, without consequences.

              Testing Notes: please run all regression and showcase tests for the components listed above.

              Show
              Arturo Zambrano added a comment - r46188: removed widgetvar code and comments from most components that were still using it r46189: removed unused widgetvar attributes from some demos The ACE components whose widgetVar attributes and related code got removed are the following: accordion, chart, confirmationDialog, contextMenu, dialog, draggable, droppable, list, listControl, maskedEntry, menu, menuBar, menuButton, notificationPanel, panel, resizable, silderEntry, textAreaEntry, textEntry, and tooltip. In the cases of the components listed above, the widgetVar attribute was either only in the Meta class or in other classes but was easily removable, without consequences. Testing Notes: please run all regression and showcase tests for the components listed above.
              Hide
              Permalink
              Arturo Zambrano added a comment -

              The components left to do are dataTable, dateTimeEntry and tree, whose classes are still dependent on the widgetVar attribute.

              In the case of progressBar, the widgetVar code is easily removable, but its showcase demos make extensive use of the widgetVar.

              Show
              Arturo Zambrano added a comment - The components left to do are dataTable, dateTimeEntry and tree, whose classes are still dependent on the widgetVar attribute. In the case of progressBar, the widgetVar code is easily removable, but its showcase demos make extensive use of the widgetVar.
              Hide
              Permalink
              Carmen Cristurean added a comment -

              ICEfaces4 trunk r46192: removed widgetVar attribute from the QA test applications, and ran regressions for the above mentioned ACE components. Ran also the showcase tests for the same components.

              Show
              Carmen Cristurean added a comment - ICEfaces4 trunk r46192: removed widgetVar attribute from the QA test applications, and ran regressions for the above mentioned ACE components. Ran also the showcase tests for the same components.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #46203 Tue Nov 10 10:30:39 MST 2015 art.zambrano ICE-10733 removed widgetvar code and comments from ace:dataTable, ace:dateTimeEntry, ace:tree, and ace:progressBar; removed widgetvar-related code from CoreRenderer and ComponentUtils and also removed remaining widgetvar-related lines from components that were using such code: ace:accordion, ace:draggable, ace:droppable, ace:maskedEntry, ace:menuButton, ace:notificationPanel, ace:resizable, ace:sliderEntry, ace:submitMonitor, ace:tableConfigPanel, ace:textAreaEntry, ace:textEntry, and ace:tooltip
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/tree/TreeRendererContext.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/tree/TreeRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datetimeentry/DateTimeEntryRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/tree/tree.js
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/renderkit/CoreRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/tooltip/TooltipRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/sliderentry/SliderEntryRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.js
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableHeadRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/tableconfigpanel/tableconfigpanel.js
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/progressbar/ProgressBarRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/tableconfigpanel/TableConfigPanelRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/menubutton/MenuButtonRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/textentry/TextEntryRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/resizable/ResizableRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/accordion/AccordionRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/datetimeentry/datetimeentry.js
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/maskedentry/MaskedEntryRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/progressbar/ProgressBarMeta.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datetimeentry/DateTimeEntryMeta.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/textareaentry/TextAreaEntryRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/submitmonitor/SubmitMonitorRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/dnd/DroppableRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/util/ComponentUtils.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/dnd/DraggableRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/notificationpanel/NotificationPanelRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableMeta.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #46204 Tue Nov 10 10:32:20 MST 2015 art.zambrano ICE-10733 removed remaining widgetvar-related code
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/progressbar/progressBarPolling.xhtml
              Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/progressbar/ProgressBarPolling.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/dataTable/dataTableScrolling.xhtml
              Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/dataTable/dataTablePinning.xhtml
              Hide
              Permalink
              Arturo Zambrano added a comment -

              r46203: removed widgetvar code and comments from ace:dataTable, ace:dateTimeEntry, ace:tree, and ace:progressBar; removed widgetvar-related code from CoreRenderer and ComponentUtils and also removed remaining widgetvar-related lines from components that were using such code: ace:accordion, ace:draggable, ace:droppable, ace:maskedEntry, ace:menuButton, ace:notificationPanel, ace:resizable, ace:sliderEntry, ace:submitMonitor, ace:tableConfigPanel, ace:textAreaEntry, ace:textEntry, and ace:tooltip

              r46204: removed remaining widgetvar-related code from the showcase

              Testing notes: please run regression tests on all components affected by these changes, listed above, and report any issues.

              Show
              Arturo Zambrano added a comment - r46203: removed widgetvar code and comments from ace:dataTable, ace:dateTimeEntry, ace:tree, and ace:progressBar; removed widgetvar-related code from CoreRenderer and ComponentUtils and also removed remaining widgetvar-related lines from components that were using such code: ace:accordion, ace:draggable, ace:droppable, ace:maskedEntry, ace:menuButton, ace:notificationPanel, ace:resizable, ace:sliderEntry, ace:submitMonitor, ace:tableConfigPanel, ace:textAreaEntry, ace:textEntry, and ace:tooltip r46204: removed remaining widgetvar-related code from the showcase Testing notes: please run regression tests on all components affected by these changes, listed above, and report any issues.
              Arturo Zambrano made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #46207 Tue Nov 10 10:39:19 MST 2015 art.zambrano ICE-10733 removed remaining widgetvar-related code
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/renderkit/CoreRenderer.java
              Hide
              Permalink
              Arturo Zambrano added a comment -

              r26297: removed remaining widgetvar-related code from the mobi folder and verified no other widgervar code exists anywhere else in the codebase.

              Show
              Arturo Zambrano added a comment - r26297: removed remaining widgetvar-related code from the mobi folder and verified no other widgervar code exists anywhere else in the codebase.
              Ken Fyten made changes -
              Affects Compatibility/Configuration [ 10002 ]
              Carmen Cristurean made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Carmen Cristurean made changes -
              Attachment dataTable-Scrolling.PNG [ 21989 ]
              Ken Fyten made changes -
              Comment [ A comment with security level 'icesoft-internal-developers' was removed. ]
              Ken Fyten made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Carmen Cristurean added a comment -

              ICEfaces4 trunk r46216: ran QA regression tests for all components affected by these changes, no issues found except for the ones already reported.

              Show
              Carmen Cristurean added a comment - ICEfaces4 trunk r46216: ran QA regression tests for all components affected by these changes, no issues found except for the ones already reported.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #46240 Wed Nov 18 16:58:32 MST 2015 art.zambrano ICE-10723, ICE-10733 fix to ensure that the id rendered to call ice.ace.instance and to re-apply the reordering behaviour is the client id of the root container and not the client if of individual nodes
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/tree/TreeRendererContext.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/tree/TreeRenderer.java
              Hide
              Permalink
              Arturo Zambrano added a comment -

              r46240: ace:tree, fix to ensure that the id rendered to call ice.ace.instance and to re-apply the reordering behaviour is the client id of the root container and not the client if of individual nodes.

              Show
              Arturo Zambrano added a comment - r46240: ace:tree, fix to ensure that the id rendered to call ice.ace.instance and to re-apply the reordering behaviour is the client id of the root container and not the client if of individual nodes.
              Ken Fyten made changes -
              Affects Version/s 4.0 [ 11382 ]
              Affects Version/s EE-4.0.0.GA [ 11171 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Arturo Zambrano
                  Reporter:
                  Arturo Zambrano
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: