Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.1
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      ICEfaces 4
    • Affects:
      Documentation (User Guide, Ref. Guide, etc.), Sample App./Tutorial

      Description

      This JIRA is to add a new ace:radioButtons component that would support stamping out a set of radioButtons based on one component tag, similar to the h:selectOneRadioButton component.

      This would support all the styling/attributes of the existing ace:radioButton component, but would support f:selectItems to define the buttons and would use a single value attribute to define the currently selected radioButton.

        Activity

        Ken Fyten created issue -
        Hide
        Ken Fyten added a comment - - edited

        Note that this feature was previously supported in the ice:selectOneRadio component.

        <ice:selectOneRadio id="SlctDrk"
            value="#{selectionTags.selectedDrink}"
            valueChangeListener="#{selectionTags.effectChangeListener}"
            partialSubmit="true" >
            <f:selectItems  id="SlctDrkItms" value="#{selectionTags.drinkItems}"/>
        </ice:selectOneRadio>
        
        Show
        Ken Fyten added a comment - - edited Note that this feature was previously supported in the ice:selectOneRadio component. <ice:selectOneRadio id= "SlctDrk" value= "#{selectionTags.selectedDrink}" valueChangeListener= "#{selectionTags.effectChangeListener}" partialSubmit= " true " > <f:selectItems id= "SlctDrkItms" value= "#{selectionTags.drinkItems}" /> </ice:selectOneRadio>
        Ken Fyten made changes -
        Field Original Value New Value
        Assignee Arturo Zambrano [ artzambrano ]
        Fix Version/s 4.1 [ 11375 ]
        Affects Documentation (User Guide, Ref. Guide, etc.),Sample App./Tutorial [ 10003, 10001 ]
        Ken Fyten made changes -
        Summary ace:radioButton - Add support for f:selectItems New ace:radioButtons component
        Description It would be a nice addition if the ace:radioButton component supported defining a set of radio buttons via the f:selectItems tag.
        This JIRA is to add a new ace:radioButtons component that would support stamping out a set of radioButtons based on one component tag, similar to the h:selectOneRadioButton component.

        This would support all the styling/attributes of the existing ace:radioButton component, but would support f:selectItems to define the buttons and would use a single value attribute to define the currently selected radioButton.
        Ken Fyten made changes -
        Issue Type Improvement [ 4 ] New Feature [ 2 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #45855 Fri Aug 14 19:22:23 MDT 2015 art.zambrano ICE-10713 New ace:radioButtons component
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/radiobutton/radiobutton.js
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/radiobutton/radiobutton.css
        Hide
        Arturo Zambrano added a comment -

        r45855: committed new ace:radioButtons component

        Show
        Arturo Zambrano added a comment - r45855: committed new ace:radioButtons component
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #45860 Tue Aug 18 11:40:17 MDT 2015 art.zambrano ICE-10713 New ace:radioButtons component
        Files Changed
        Commit graph ADD /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/radiobuttons/RadioButtons.java
        Commit graph ADD /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/radiobuttons/RadioButtonsMeta.java
        Commit graph ADD /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/radiobuttons
        Commit graph ADD /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/radiobuttons/RadioButtonsRenderer.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #45861 Tue Aug 18 12:19:36 MDT 2015 art.zambrano ICE-10713, ICE-10716 styling adjustments
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/radiobutton/radiobutton.css
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/checkboxbutton/checkboxbutton.css
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #45862 Tue Aug 18 12:22:06 MDT 2015 art.zambrano ICE-10713, ICE-10716 added label, indicator, and required styling demos
        Files Changed
        Commit graph ADD /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/checkboxButtons/CheckboxButtonsLabelBean.java
        Commit graph ADD /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/radioButtons/radioButtonsIndicator.xhtml
        Commit graph ADD /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/radioButtons
        Commit graph ADD /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/checkboxButtons/checkboxButtonsReqStyle.xhtml
        Commit graph ADD /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/radioButtons/radioButtons.xhtml
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/view/navigation/AceMenu.java
        Commit graph ADD /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/radioButtons
        Commit graph ADD /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/radioButtons/RadioButtonsIndicatorBean.java
        Commit graph ADD /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/radioButtons/radioButtonsLabel.xhtml
        Commit graph ADD /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/checkboxButtons/CheckboxButtonsIndicatorBean.java
        Commit graph ADD /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/checkboxButtons/CheckboxButtonsReqStyleBean.java
        Commit graph ADD /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/ace/documentationResources/RadioButtonsResources.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/checkboxButtons/CheckboxButtonsBean.java
        Commit graph ADD /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/radioButtons/radioButtonsReqStyle.xhtml
        Commit graph ADD /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/checkboxButtons/checkboxButtonsLabel.xhtml
        Commit graph ADD /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/checkboxButtons/checkboxButtonsIndicator.xhtml
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/checkboxButtons/checkboxButtons.xhtml
        Commit graph ADD /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/radioButtons/RadioButtonsReqStyleBean.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/resources/org/icefaces/samples/showcase/view/resources/messages.properties
        Commit graph ADD /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/radioButtons/RadioButtonsLabelBean.java
        Commit graph ADD /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/radioButtons/RadioButtonsBean.java
        Hide
        Arturo Zambrano added a comment -

        r45861: committed some styling adjustments
        r45862: added label, indicator, and required styling demos

        Show
        Arturo Zambrano added a comment - r45861: committed some styling adjustments r45862: added label, indicator, and required styling demos
        Arturo Zambrano made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #45874 Thu Aug 20 12:45:21 MDT 2015 art.zambrano ICE-10713, ICE-10716 modified rendering behaviour when the submitted value is invalid, to render the invalid submitted value instead of the previous valid value, in order to apply invalid styling consistently and allow the user to correct the input; corrected radioButtons behaviour so that the radio buttons don't behave like checkboxes (i.e. one selected they can't be deselected by clicking on them again)
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/checkboxbuttons/CheckboxButtonsRenderer.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/radiobuttons/RadioButtonsRenderer.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/radiobutton/radiobutton.js
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #45875 Thu Aug 20 12:48:22 MDT 2015 art.zambrano ICE-10713, ICE-10716 removed unnecessary resource files from the resource examples; modified the way the values are displayed to make them more presentable
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/checkboxButtons/CheckboxButtonsLabelBean.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/radioButtons/radioButtonsIndicator.xhtml
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/checkboxButtons/checkboxButtonsReqStyle.xhtml
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/radioButtons/radioButtons.xhtml
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/radioButtons/RadioButtonsIndicatorBean.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/radioButtons/radioButtonsLabel.xhtml
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/checkboxButtons/CheckboxButtonsIndicatorBean.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/checkboxButtons/CheckboxButtonsReqStyleBean.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/checkboxButtons/CheckboxButtonsBean.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/radioButtons/radioButtonsReqStyle.xhtml
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/checkboxButtons/checkboxButtons.xhtml
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/checkboxButtons/checkboxButtonsIndicator.xhtml
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/checkboxButtons/checkboxButtonsLabel.xhtml
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/radioButtons/RadioButtonsReqStyleBean.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/radioButtons/RadioButtonsLabelBean.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/radioButtons/RadioButtonsBean.java
        Hide
        Arturo Zambrano added a comment -

        r45874: modified rendering behaviour when the submitted value is invalid, to render the invalid submitted value instead of the previous valid value, in order to apply invalid styling consistently and allow the user to correct the input; corrected radioButtons behaviour so that the radio buttons don't behave like checkboxes (i.e. one selected they can't be deselected by clicking on them again)

        Show
        Arturo Zambrano added a comment - r45874: modified rendering behaviour when the submitted value is invalid, to render the invalid submitted value instead of the previous valid value, in order to apply invalid styling consistently and allow the user to correct the input; corrected radioButtons behaviour so that the radio buttons don't behave like checkboxes (i.e. one selected they can't be deselected by clicking on them again)
        Hide
        Arturo Zambrano added a comment -

        r45875: removed unnecessary resource files from the resource examples; modified the way the values are displayed to make them more presentable.

        Show
        Arturo Zambrano added a comment - r45875: removed unnecessary resource files from the resource examples; modified the way the values are displayed to make them more presentable.
        Hide
        Carlo Guglielmin added a comment - - edited

        Re-opening because if "labelPosition" is not specified there is no text shown for each radio button (see screenshot). This is unrelated to any "label" attribute usage.
        This prevents ace:radioButtons from being a direct drop in replacement for h:selectOneRadio.

        Ideally the text just displays properly, or worst case labelPosition should default to the traditional "left".

        Show
        Carlo Guglielmin added a comment - - edited Re-opening because if "labelPosition" is not specified there is no text shown for each radio button (see screenshot). This is unrelated to any "label" attribute usage. This prevents ace:radioButtons from being a direct drop in replacement for h:selectOneRadio. Ideally the text just displays properly, or worst case labelPosition should default to the traditional "left".
        Carlo Guglielmin made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Hide
        Carlo Guglielmin added a comment - - edited

        Screenshot demonstrating the missing labels unless "labelPosition" is manually specified.

        Show
        Carlo Guglielmin added a comment - - edited Screenshot demonstrating the missing labels unless "labelPosition" is manually specified.
        Carlo Guglielmin made changes -
        Attachment missing-labels.png [ 22020 ]
        Hide
        Arturo Zambrano added a comment -

        r46527: changes in label position to make ace:radioButtons behave like h:selectOneRadio : 1) The default value for the 'labelPosition' attribute is now set to 'right' instead of 'none', 2) If the 'labelPosition' attribute is set to null or to the empty string, the label is still displayed to the right of the radio button; only when 'labelPosition' is set explicitly to 'none' the label won't be displayed

        Show
        Arturo Zambrano added a comment - r46527: changes in label position to make ace:radioButtons behave like h:selectOneRadio : 1) The default value for the 'labelPosition' attribute is now set to 'right' instead of 'none', 2) If the 'labelPosition' attribute is set to null or to the empty string, the label is still displayed to the right of the radio button; only when 'labelPosition' is set explicitly to 'none' the label won't be displayed
        Arturo Zambrano made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #46527 Mon Dec 14 09:30:59 MST 2015 art.zambrano ICE-10713 changes in label position to make ace:radioButtons behave like h:selectOneRadio : 1) The default value for the 'labelPosition' attribute is now set to 'right' instead of 'none', 2) If the 'labelPosition' attribute is set to null or to the empty string, the label is still displayed to the right of the radio button; only when 'labelPosition' is set explicitly to 'none' the label won't be displayed
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/radiobuttons/RadioButtonsMeta.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/radiobuttons/RadioButtonsRenderer.java
        Hide
        Carlo Guglielmin added a comment -

        Looks good from my Emporium testing.

        Show
        Carlo Guglielmin added a comment - Looks good from my Emporium testing.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #46531 Mon Dec 14 17:09:20 MST 2015 art.zambrano ICE-10713 removed 'inField' value from 'labelPosition' TLD documentation
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/radiobuttons/RadioButtonsMeta.java
        Hide
        Arturo Zambrano added a comment -

        r46531: removed 'inField' value from 'labelPosition' TLD documentation.

        Thank you for observing that, Carmen. The 'inField' value has now been removed from the ace:radioButtons documentation, since ace:radioButton doesn't support it either.

        Show
        Arturo Zambrano added a comment - r46531: removed 'inField' value from 'labelPosition' TLD documentation. Thank you for observing that, Carmen. The 'inField' value has now been removed from the ace:radioButtons documentation, since ace:radioButton doesn't support it either.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #46534 Tue Dec 15 10:00:36 MST 2015 carlo.guglielmin ICE-10713 was fixed, so removing workaround
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/ace/emporium/src/main/webapp/WEB-INF/includes/settings-tab.xhtml
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #46545 Tue Dec 15 16:04:42 MST 2015 carmen.cristurean ICE-10713 remove 'inField' value from showcase > radioButtons > Label Position demo.
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/util/PositionBean.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/radioButtons/radioButtonsLabel.xhtml
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Ken Fyten
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: