ICEfaces
  1. ICEfaces
  2. ICE-10520

Implement centralized browser detection strategy

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: EE-3.3.0.GA_P02, 4.0
          • Fix Version/s: 4.2.BETA, 4.2
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            Any
          • Assignee Priority:
            P2

            Description

            In the past, browser detection in client-side component code has been left at the discretion of the component developers and limited to the individual requirements of the various components. As a result, browser detection code is duplicated in many parts of our components' client-side code. Some of that code uses deprecated methods of browser detection. This improvement is to design and implement a centralized browser detection strategy that can be used by any component, making use of more reliable and current methods of browser detection. Most likely, this code should go in core.js.

              Activity

              Ascending order - Click to sort in descending order
              Arturo Zambrano created issue -
              Arturo Zambrano made changes -
              Field Original Value New Value
              Assignee Arturo Zambrano [ artzambrano ]
              Ken Fyten made changes -
              Fix Version/s 4.1 [ 11375 ]
              Ken Fyten made changes -
              Fix Version/s EE-4.1.0.GA [ 12171 ]
              Fix Version/s 4.1 [ 11375 ]
              Ken Fyten made changes -
              Fix Version/s 4.2 [ 12870 ]
              Fix Version/s EE-4.1.0.GA [ 12171 ]
              Ken Fyten made changes -
              Assignee Arturo Zambrano [ artzambrano ] Mircea Toma [ mircea.toma ]
              Assignee Priority P2 [ 10011 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #49555 Wed Nov 16 14:08:24 MST 2016 mircea.toma ICE-10520 Initial implementation of browser detection.
              Files Changed
              Commit graph ADD /icefaces4/trunk/icefaces/core/src/main/javascript/browser.js
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #49556 Wed Nov 16 14:10:40 MST 2016 mircea.toma ICE-10520 Fix Firefox REGEX.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/core/src/main/javascript/browser.js
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #49557 Wed Nov 16 15:27:36 MST 2016 mircea.toma ICE-10520 Reformatted code.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/core/src/main/javascript/browser.js
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #49558 Wed Nov 16 15:42:19 MST 2016 mircea.toma ICE-10520 Simplify API.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/core/src/main/javascript/browser.js
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #49559 Wed Nov 16 16:04:14 MST 2016 mircea.toma ICE-10520 Simplify regex for Safari to work well for desktop and mobile version.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/core/src/main/javascript/browser.js
              Hide
              Permalink
              Mircea Toma added a comment -

              Added implementation for browser detection to ACE components. The API is located in ice.ace.browser.* namespace.

              Show
              Mircea Toma added a comment - Added implementation for browser detection to ACE components. The API is located in ice.ace.browser.* namespace.
              Mircea Toma made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #49561 Thu Nov 17 07:05:59 MST 2016 mircea.toma ICE-10520 Make API part of the ACE components library.
              Files Changed
              Commit graph DEL /icefaces4/trunk/icefaces/core/src/main/javascript/browser.js
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/core/core.js
              Hide
              Permalink
              Ken Fyten added a comment -

              Note that the preferred technique is to use browser feature-detection. A JIRA to implement a centralized API for that is ICE-11183.

              Show
              Ken Fyten added a comment - Note that the preferred technique is to use browser feature-detection. A JIRA to implement a centralized API for that is ICE-11183 .
              Ken Fyten made changes -
              Fix Version/s 4.2.BETA [ 13091 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Mircea Toma
                  Reporter:
                  Arturo Zambrano
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: