ICEfaces
  1. ICEfaces
  2. ICE-10516

ace:submitMonitor - Delay showing modal layer

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: EE-3.3.0.GA_P02, 4.0
          • Fix Version/s: EE-3.3.0.GA_P03, 4.1
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            All

            Description

            When using the ace:submitMonitor with blockUI="@all", it is possible to do a double submit when quickly doing a submit (double click a button).

            This is reproducible with the Showcase demo.

              Activity

              Ascending order - Click to sort in descending order
              Arran Mccullough created issue -
              Hide
              Permalink
              Arran Mccullough added a comment -

              Attached basic test case. Note: the icefaces, ace, and compat jars need to be added back into the war to run.

              Steps:

              • Load welcomeICEfaces.jsf
              • Quickly double click the Submit button. This will show two 'SUBMIT CALLED' logs shown in the server logs as well as one monitor will be shown after the other one.
              Show
              Arran Mccullough added a comment - Attached basic test case. Note: the icefaces, ace, and compat jars need to be added back into the war to run. Steps: Load welcomeICEfaces.jsf Quickly double click the Submit button. This will show two 'SUBMIT CALLED' logs shown in the server logs as well as one monitor will be shown after the other one.
              Arran Mccullough made changes -
              Field Original Value New Value
              Attachment Case13319Example.war [ 18483 ]
              Attachment Case13319Example.zip [ 18484 ]
              Ken Fyten made changes -
              Assignee Mircea Toma [ mircea.toma ]
              Fix Version/s 4.1 [ 11375 ]
              Fix Version/s EE-3.3.0.GA_P03 [ 11572 ]
              Assignee Priority P2 [ 10011 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #44286 Tue Mar 24 08:45:20 MDT 2015 mircea.toma ICE-10516 Cancel event bubbling in the event sinks that ace:submitMonitor sets up.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/submitmonitor/submitmonitor.js
              Hide
              Permalink
              Mircea Toma added a comment -

              Cancel event bubbling in the event sinks that ace:submitMonitor sets up. Tested also with icecore:singleSubmit.

              Show
              Mircea Toma added a comment - Cancel event bubbling in the event sinks that ace:submitMonitor sets up. Tested also with icecore:singleSubmit.
              Mircea Toma made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Liana Munroe added a comment -

              Verified using attached test case ICEfaces EE-4.0.0 Jenkins build 2 and EE-3.3.0 maintenance branch. Tomcat 7, IE 11, FF 34, Chrome 41.
              When testing ace:submitMonitor demo in showcase the submit still appears twice when double clicking the Submit button. This can be noticed more often when first using the demo. Changing the region to block, then double clicking submit will usually show the submitMonitor twice. Subsequent submits will show the submitMonitor only once.

              Show
              Liana Munroe added a comment - Verified using attached test case ICEfaces EE-4.0.0 Jenkins build 2 and EE-3.3.0 maintenance branch. Tomcat 7, IE 11, FF 34, Chrome 41. When testing ace:submitMonitor demo in showcase the submit still appears twice when double clicking the Submit button. This can be noticed more often when first using the demo. Changing the region to block, then double clicking submit will usually show the submitMonitor twice. Subsequent submits will show the submitMonitor only once.
              Ken Fyten made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #44459 Thu Apr 09 12:43:44 MDT 2015 mircea.toma ICE-10516 Override the primitive submit function with one that will block sub-sequent calls.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/submitmonitor/submitmonitor.js
              Hide
              Permalink
              Mircea Toma added a comment -

              Modified submitmonitor.js code to override the primitive submit function with one that will block sub-sequent calls. This is required in cases where the callbacks that trigger a submit are registered with Element.addEventListener function and cannot be reached to be disabled temporarily (to avoid subsequent submits).

              Show
              Mircea Toma added a comment - Modified submitmonitor.js code to override the primitive submit function with one that will block sub-sequent calls. This is required in cases where the callbacks that trigger a submit are registered with Element.addEventListener function and cannot be reached to be disabled temporarily (to avoid subsequent submits).
              Mircea Toma made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Liana Munroe added a comment -

              Verified ICEfaces 4 trunk, EE-3.3.0 maintenance branch r44464 using showcase and attached test case. Tomcat 7, FF 34, Chrome 41, IE 11.

              Show
              Liana Munroe added a comment - Verified ICEfaces 4 trunk, EE-3.3.0 maintenance branch r44464 using showcase and attached test case. Tomcat 7, FF 34, Chrome 41, IE 11.
              Hide
              Permalink
              Ken Fyten added a comment -

              QA, also need to verify that this fix doesn't cause any issues with the following previous fixes:

              Show
              Ken Fyten added a comment - QA, also need to verify that this fix doesn't cause any issues with the following previous fixes: ICE-8668 ICE-5223 ICE-8914
              Hide
              Permalink
              Liana Munroe added a comment -

              ICE-8914 verified with ICEfaces EE-3.3.0 maintenance branch, ICEfaces 4 trunk r44499. Tomcat 7, IE 11, FF 34, Chrome 41.
              New test application /ICE-8914.jsf added to:
              http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces2/Sparkle/Nightly/panel
              http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/panel.

              As per Ken, ICE-5223 does not require further verification.

              Show
              Liana Munroe added a comment - ICE-8914 verified with ICEfaces EE-3.3.0 maintenance branch, ICEfaces 4 trunk r44499. Tomcat 7, IE 11, FF 34, Chrome 41. New test application / ICE-8914 .jsf added to: http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces2/Sparkle/Nightly/panel http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/panel . As per Ken, ICE-5223 does not require further verification.
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Mircea Toma
                  Reporter:
                  Arran Mccullough
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: