Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: EE-3.3.0.GA_P02, 4.0
-
Fix Version/s: EE-4.0.0.GA, EE-3.3.0.GA_P03, 4.1
-
Component/s: ACE-Components
-
Labels:None
-
Environment:All
-
Assignee Priority:P1
-
Support Case References:Support Case #13301 - https://icesoft.my.salesforce.com/50070000011u9MW
-
Affects:Documentation (User Guide, Ref. Guide, etc.), Compatibility/Configuration
Description
The following steps can be used to reproduce the issue with the Showcase demo:
Steps:
1. Click edit for any row.
2. Click edit for another row.
3. Change a value in both rows
4. Submit just one row over the little blue checkmark
5. Now you have one row in edit modus with a changed value. Click on the button "Stop Editing For All"
6. Editing is stopped but the changed value is submited.
If you do these steps with one edited row there are no changed valus submited.
Activity
- All
- Comments
- History
- Activity
- Remote Attachments
- Subversion
Sending samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/ace/documentationResources/CloudPushResources.java
Transmitting file data .
Committed revision 44228.
Fixed a small compilation error by removing the trailing comma withing the resources.
ace:dataTable -> Click Events demo Regression
Re-opened as there is now an issue where multiple submit/responses appear to occur in succession when editing and submitting cell values via double-click.
To reproduce:
- Double-click a name cell to edit it and double-click to submit the changes.
- Navigate to pg2 and then back to pg. via the pagination
- Edit another cell via double-click, notice the flashing between edit and read mode.
The number of flashes between edit and read mode correlates to the number of paginator pages that have been changed. Weird...
That last issue is actually a side effect of ICE-10529. Removing the client id that was added to the span that contains the script, resolves this issue.
This happens because now the table markup is not updated in full when clicking on a page in the paginator. Because now the script tag is inside a span with its own client id and the table body (<tbody>) has its own client id as well, so, when the user clicks on a page of the paginator, the table body and the script are updated, instead of the whole markup from the root div, and, because the script re-initializes the table, a new event listener for double clicks is added to the root element, so now multiple requests are fired because there are multiple event listeners registered.
This could be fixed by removing click event listeners before (re)initializing the table. We could also consider solving ICE-10529 without adding those inner client ids, if feasible.
Closing again, since the last issue is caused by ICE-10529. Comments were copied to that JIRA.
Committed fix to 4.0 trunk at revision 44102 and to 3.3 EE maintenance branch at revision 44103.
The initial fix was simply to avoid processing decodes for ace:cellEditor children when the source of the request isn't the save edits button. However, because of the same reason, domdiff was erasing the inputs entered in other rows in edit mode, when the whole form was being submitted, including requests to save edits of a specific row. So, if two or more rows were in edit mode, and the inputs were edited in some or all of them, after clicking the save edits button for one row, all the other edited inputs were revered to their values in the server, because of a domdiff mechanism that does this. Therefore, a mechanism was added to remove name attributes from input fields inside cell editors, and thus avoid that domdiff see these changes (and revert them). The name attributes are restored when the save edits button is activated for the current row.
Testing notes: please try different use cases that a typical user may have, like having several rows in edit mode, editing them and only saving some of them; submitting the whole form via submit button or causing a full form or full table update, etc. Values in edit mode rows should only be saved when clicking the save edits button of their corresponding row.