ICEfaces
  1. ICEfaces
  2. ICE-1048

onclick attribute not being passed through in panelTab comp

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.5.1
    • Fix Version/s: 1.5.2
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      Operating System: Windows XP
      Platform: PC

      Description

      noted in the forum: http://www.icefaces.org/JForum/posts/list/2980.page

      onclick isn't passing through

        Activity

        Hide
        Greg McCleary added a comment -

        There is a problem with tag class for the PanelTab ... it is missing attributes
        like onclick. I will add the onclick and other missing attributes.

        I am also working on Bug# 1016 - tabChangeEvent proliferation ... it looks like
        the bean instances are actually being propagated ... hopefully a fix for both
        this bug and 1016 will be done soon.

        Show
        Greg McCleary added a comment - There is a problem with tag class for the PanelTab ... it is missing attributes like onclick. I will add the onclick and other missing attributes. I am also working on Bug# 1016 - tabChangeEvent proliferation ... it looks like the bean instances are actually being propagated ... hopefully a fix for both this bug and 1016 will be done soon.
        Hide
        Greg McCleary added a comment -

        Fixed in HEAD [rev 12618] and 1.5 branch [rev 12617]

        The users onclick handler will always be called before the tabChange onclick
        handler.

        In the following instance the alert will be executed prior to the tabChange onclick.

        [page source:]
        ...
        <ice:panelTab label="Tab 1" onclick="alert('onclick');" >
        ...
        </ice:panelTab>
        ...

        [rendered onclick:]
        ...
        onclick="alert('onclick');
        document.forms['_id7']['_id7:_idcl'].value='_id7:_id8';
        iceSubmitPartial( document.forms['_id7'], this,event); return false;"
        ...

        Show
        Greg McCleary added a comment - Fixed in HEAD [rev 12618] and 1.5 branch [rev 12617] The users onclick handler will always be called before the tabChange onclick handler. In the following instance the alert will be executed prior to the tabChange onclick. [page source:] ... <ice:panelTab label="Tab 1" onclick="alert('onclick');" > ... </ice:panelTab> ... [rendered onclick:] ... onclick="alert('onclick'); document.forms ['_id7'] ['_id7:_idcl'] .value='_id7:_id8'; iceSubmitPartial( document.forms ['_id7'] , this,event); return false;" ...
        Hide
        Greg McCleary added a comment -

        Tested against Icefaces 1.5.2

        Show
        Greg McCleary added a comment - Tested against Icefaces 1.5.2

          People

          • Assignee:
            Greg McCleary
            Reporter:
            Philip Breau
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: