ICEfaces
  1. ICEfaces
  2. ICE-10469

remove unused classes in ICEfaces 4 core for compat component support

          Details

          • Type: Task Task
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 4.0
          • Fix Version/s: EE-4.0.0.GA, 4.1
          • Component/s: Framework
          • Labels:
            None
          • Environment:
            jsf 2 ICEfaces4

            Description

            Classes ported over from ICEfaces-3 of
            org.icefaces.facelets.tag.icefaces.core.IceComponentHandler
            and
            org.icefaces.facelets.tag.icefaces.core.TabChangeListener
            refer to the compat components and should be deleted and tested to ensure that they are no longer required.

              Activity

              Ascending order - Click to sort in descending order
              Judy Guglielmin created issue -
              Judy Guglielmin made changes -
              Field Original Value New Value
              Assignee Judy Guglielmin [ judy.guglielmin ]
              Judy Guglielmin made changes -
              Fix Version/s EE-4.0.0.GA [ 11171 ]
              Ken Fyten made changes -
              Assignee Judy Guglielmin [ judy.guglielmin ] Arturo Zambrano [ artzambrano ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #44060 Thu Feb 12 15:27:26 MST 2015 art.zambrano ICE-10469 removed unused classes in ICEfaces 4 core for compat component support
              Files Changed
              Commit graph DEL /icefaces4/trunk/icefaces/core/src/main/java/org/icefaces/facelets/tag/icefaces/core/IceComponentHandler.java
              Commit graph DEL /icefaces4/trunk/icefaces/core/src/main/java/org/icefaces/facelets/tag/icefaces/core/TabChangeListenerHandler.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/merge/TaglibMerge.java
              Hide
              Permalink
              Arturo Zambrano added a comment -

              r44060: Removed the classes IceComponentHandler and TabChangeListenerHandler from the org.icefaces.facelets.tag.icefaces.core package in the core folder, as well as the method replaceComponentHandler() from the TaglibMerge class in the ACE generator that was the only one using them. I verified that these classes aren't used in any other parts. These classes were used to adapt the ICE (compat) components to JSF 2.0. The other class in the same package as these classes is MethodRule, which is used in all components classes that have method expressions, so it was left there. After this, I built the entire project and deployed the showcase application. There were no compilation or runtime errors.

              Testing notes: please observe your routine regression tests and report any new errors.

              Show
              Arturo Zambrano added a comment - r44060: Removed the classes IceComponentHandler and TabChangeListenerHandler from the org.icefaces.facelets.tag.icefaces.core package in the core folder, as well as the method replaceComponentHandler() from the TaglibMerge class in the ACE generator that was the only one using them. I verified that these classes aren't used in any other parts. These classes were used to adapt the ICE (compat) components to JSF 2.0. The other class in the same package as these classes is MethodRule, which is used in all components classes that have method expressions, so it was left there. After this, I built the entire project and deployed the showcase application. There were no compilation or runtime errors. Testing notes: please observe your routine regression tests and report any new errors.
              Arturo Zambrano made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Security Private [ 10001 ]
              Ken Fyten made changes -
              Fix Version/s 4.1 [ 11375 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Arturo Zambrano
                  Reporter:
                  Judy Guglielmin
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: