ICEfaces
  1. ICEfaces
  2. ICE-10469

remove unused classes in ICEfaces 4 core for compat component support

          Details

          • Type: Task Task
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 4.0
          • Fix Version/s: EE-4.0.0.GA, 4.1
          • Component/s: Framework
          • Labels:
            None
          • Environment:
            jsf 2 ICEfaces4

            Description

            Classes ported over from ICEfaces-3 of
            org.icefaces.facelets.tag.icefaces.core.IceComponentHandler
            and
            org.icefaces.facelets.tag.icefaces.core.TabChangeListener
            refer to the compat components and should be deleted and tested to ensure that they are no longer required.

              Activity

              Hide
              Permalink
              Arturo Zambrano added a comment -

              r44060: Removed the classes IceComponentHandler and TabChangeListenerHandler from the org.icefaces.facelets.tag.icefaces.core package in the core folder, as well as the method replaceComponentHandler() from the TaglibMerge class in the ACE generator that was the only one using them. I verified that these classes aren't used in any other parts. These classes were used to adapt the ICE (compat) components to JSF 2.0. The other class in the same package as these classes is MethodRule, which is used in all components classes that have method expressions, so it was left there. After this, I built the entire project and deployed the showcase application. There were no compilation or runtime errors.

              Testing notes: please observe your routine regression tests and report any new errors.

              Show
              Arturo Zambrano added a comment - r44060: Removed the classes IceComponentHandler and TabChangeListenerHandler from the org.icefaces.facelets.tag.icefaces.core package in the core folder, as well as the method replaceComponentHandler() from the TaglibMerge class in the ACE generator that was the only one using them. I verified that these classes aren't used in any other parts. These classes were used to adapt the ICE (compat) components to JSF 2.0. The other class in the same package as these classes is MethodRule, which is used in all components classes that have method expressions, so it was left there. After this, I built the entire project and deployed the showcase application. There were no compilation or runtime errors. Testing notes: please observe your routine regression tests and report any new errors.

                People

                • Assignee:
                  Arturo Zambrano
                  Reporter:
                  Judy Guglielmin
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: