ICEfaces
  1. ICEfaces
  2. ICE-10467

check components which have required attributes to ensure runtime exceptions do not occur

          Details

          • Assignee Priority:
            P2

            Description

            The following components have attributes that are required:-
            MaskedEntryMeta:- mask has required=Required.yes
            MessageMeta:- for value has Required.yes
            TabSetProxyMeta:- “for” value has Required.yes
            When testing MaskedEntryMeta, if mask is not present as an attribute, an NPE will occur at runtime. Renderers need to be updated to ensure this does not happen. (perhaps log a warning for Level.DEBUG to let developers know that this is a required attribute?).

              Activity

              Ascending order - Click to sort in descending order
              Judy Guglielmin created issue -
              Judy Guglielmin made changes -
              Field Original Value New Value
              Assignee Ken Fyten [ ken.fyten ]
              Ken Fyten made changes -
              Assignee Ken Fyten [ ken.fyten ] Judy Guglielmin [ judy.guglielmin ]
              Fix Version/s EE-4.0.0.GA [ 11171 ]
              Fix Version/s EE-3.3.0.GA_P03 [ 11572 ]
              Assignee Priority P2 [ 10011 ]
              Ken Fyten made changes -
              Assignee Judy Guglielmin [ judy.guglielmin ] Arturo Zambrano [ artzambrano ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #44116 Wed Feb 25 16:31:57 MST 2015 art.zambrano ICE-10467 fix to prevent runtime exceptions and to display a warning message when required attributes are missing
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/dataexporter/DataExporterMeta.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/maskedentry/MaskedEntryRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/tabset/TabSetProxy.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/dataexporter/ExporterFactory.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/dataexporter/DataExporter.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/dataexporter/Exporter.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/message/MessageRenderer.java
              Hide
              Permalink
              Arturo Zambrano added a comment -

              Committed fixes to 4.0 trunk at revision 44116 and to 3.3 EE maintenance branch at revision 44117.

              The fixes are to prevent runtime exceptions and to display a warning message when required attributes are missing.

              This was done for the following attributes:

              • 'filename' in ace:dataExporter.
              • 'mask' in ace:maskedEntry
              • 'for' in ace:message
              • 'for' in ace:tabSetProxy
              • 'type' in ace:dataExporter was changed to non-required and now defaults to 'csv'. No warning message is displayed when not specified.
              • Unlike the attributes above, when 'target' in ace:dataExporter is null or invalid, it will cause an exception.

              Also, I verified that there are no other required attributes in all other components.

              Testing notes: please verify that these warning messages appear in the server console and no runtime exceptions occur when the page is loaded. In the case of ace:dataExporter, this is tested when pressing the button.

              Show
              Arturo Zambrano added a comment - Committed fixes to 4.0 trunk at revision 44116 and to 3.3 EE maintenance branch at revision 44117. The fixes are to prevent runtime exceptions and to display a warning message when required attributes are missing. This was done for the following attributes: 'filename' in ace:dataExporter. 'mask' in ace:maskedEntry 'for' in ace:message 'for' in ace:tabSetProxy 'type' in ace:dataExporter was changed to non-required and now defaults to 'csv'. No warning message is displayed when not specified. Unlike the attributes above, when 'target' in ace:dataExporter is null or invalid, it will cause an exception. Also, I verified that there are no other required attributes in all other components. Testing notes: please verify that these warning messages appear in the server console and no runtime exceptions occur when the page is loaded. In the case of ace:dataExporter, this is tested when pressing the button.
              Arturo Zambrano made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Security Private [ 10001 ]
              Ken Fyten made changes -
              Fix Version/s 4.1 [ 11375 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Arturo Zambrano
                  Reporter:
                  Judy Guglielmin
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: