ICEfaces
  1. ICEfaces
  2. ICE-10467

check components which have required attributes to ensure runtime exceptions do not occur

          Details

          • Assignee Priority:
            P2

            Description

            The following components have attributes that are required:-
            MaskedEntryMeta:- mask has required=Required.yes
            MessageMeta:- for value has Required.yes
            TabSetProxyMeta:- “for” value has Required.yes
            When testing MaskedEntryMeta, if mask is not present as an attribute, an NPE will occur at runtime. Renderers need to be updated to ensure this does not happen. (perhaps log a warning for Level.DEBUG to let developers know that this is a required attribute?).

              Activity

              Hide
              Permalink
              Arturo Zambrano added a comment -

              Committed fixes to 4.0 trunk at revision 44116 and to 3.3 EE maintenance branch at revision 44117.

              The fixes are to prevent runtime exceptions and to display a warning message when required attributes are missing.

              This was done for the following attributes:

              • 'filename' in ace:dataExporter.
              • 'mask' in ace:maskedEntry
              • 'for' in ace:message
              • 'for' in ace:tabSetProxy
              • 'type' in ace:dataExporter was changed to non-required and now defaults to 'csv'. No warning message is displayed when not specified.
              • Unlike the attributes above, when 'target' in ace:dataExporter is null or invalid, it will cause an exception.

              Also, I verified that there are no other required attributes in all other components.

              Testing notes: please verify that these warning messages appear in the server console and no runtime exceptions occur when the page is loaded. In the case of ace:dataExporter, this is tested when pressing the button.

              Show
              Arturo Zambrano added a comment - Committed fixes to 4.0 trunk at revision 44116 and to 3.3 EE maintenance branch at revision 44117. The fixes are to prevent runtime exceptions and to display a warning message when required attributes are missing. This was done for the following attributes: 'filename' in ace:dataExporter. 'mask' in ace:maskedEntry 'for' in ace:message 'for' in ace:tabSetProxy 'type' in ace:dataExporter was changed to non-required and now defaults to 'csv'. No warning message is displayed when not specified. Unlike the attributes above, when 'target' in ace:dataExporter is null or invalid, it will cause an exception. Also, I verified that there are no other required attributes in all other components. Testing notes: please verify that these warning messages appear in the server console and no runtime exceptions occur when the page is loaded. In the case of ace:dataExporter, this is tested when pressing the button.

                People

                • Assignee:
                  Arturo Zambrano
                  Reporter:
                  Judy Guglielmin
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: