ICEfaces
  1. ICEfaces
  2. ICE-1044

User Contribution: BlockingServlet.service() assumes that a RuntimeException is due to an ended session

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.5.1
          • Fix Version/s: 1.5.2
          • Component/s: Framework
          • Labels:
            None
          • Environment:
            Operating System: Windows XP
            Platform: PC

            Description

            In BlockingServlet.service() the code assumes that a RuntimeException
            means that the user session has expired. That's not really a good
            assumption. In my case, as NullPointerException from InputFile was being
            treated as an expired session. That made it hard to debug. I didn't
            change the error message, but I did change the logging to include the
            exception to make debugging easier.

            Dave Dunkin
            Technologist
            DIS Corporation
            360.647.4120

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Philip Breau added a comment -

              Created an attachment (id=120)
              patched source file

              Show
              Philip Breau added a comment - Created an attachment (id=120) patched source file
              Hide
              Permalink
              Ken Fyten added a comment -

              Ted,

              Please review this suggestion to see if it's feasible/safe to include in 1.5.2.

              Show
              Ken Fyten added a comment - Ted, Please review this suggestion to see if it's feasible/safe to include in 1.5.2.
              Hide
              Permalink
              Ted Goddard added a comment -

              May be fixed by changes for ICE-1010.

              Show
              Ted Goddard added a comment - May be fixed by changes for ICE-1010 .
              Hide
              Permalink
              Ted Goddard added a comment -

              This is substantially improved in the head (as indicated by the 1030 fix) but those changes are more
              extensive than the simple improvement to logging requested by the customer. The following change
              ensures that the actual exception is provided to "trace" when RuntimeException is caught in the
              BlockingServlet.

              svn commit src/com/icesoft/faces/webapp/xmlhttp/BlockingServlet.java -m "improving debugging per
              customer request (ICE-1044)"
              Sending src/com/icesoft/faces/webapp/xmlhttp/BlockingServlet.java
              Transmitting file data .
              Committed revision 12766.

              Show
              Ted Goddard added a comment - This is substantially improved in the head (as indicated by the 1030 fix) but those changes are more extensive than the simple improvement to logging requested by the customer. The following change ensures that the actual exception is provided to "trace" when RuntimeException is caught in the BlockingServlet. svn commit src/com/icesoft/faces/webapp/xmlhttp/BlockingServlet.java -m "improving debugging per customer request ( ICE-1044 )" Sending src/com/icesoft/faces/webapp/xmlhttp/BlockingServlet.java Transmitting file data . Committed revision 12766.
              Hide
              Permalink
              Ted Goddard added a comment -

              Verified that a bean-thrown NullPointerException is reported to the console rather than resulting in a
              session invalidation.

              Show
              Ted Goddard added a comment - Verified that a bean-thrown NullPointerException is reported to the console rather than resulting in a session invalidation.

                People

                • Assignee:
                  Ted Goddard
                  Reporter:
                  Philip Breau
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: