ICEfaces
  1. ICEfaces
  2. ICE-10373

showcase - ace:dataTable "'JSON' is undefined" error (IE8)

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-3.3.0.GA_P02
    • Fix Version/s: EE-4.0.0.GA, EE-3.3.0.GA_P03, 4.1
    • Component/s: ACE-Components, Sample Apps
    • Labels:
      None
    • Environment:
      ICEfaces4 trunk r. 43281
      Browsers: IE8
      Server: Tomcat7.0.42 (configured for SSL access)

      Description

      1) showcase > ace:dataTable (SSL configuration/ IE8):
      On the Pin Columns demo accessed using the SSL config, a JS error occurs when pinning columns:

       Message: 'JSON' is undefined
      Line: 88
      Char: 58
      Code: 0
      URI: https://10.18.39.149:8443/showcase/javax.faces.resource/util/ace-datatable.js.jsf?ln=icefaces.ace&v=4_0_0_141029

      2) showcase > ace:tableConfigPanel (non-SSL, IE8):
      On the Overview and Advanced demos, a similar JS error occurs when saving changes in the Table Config panel, or when leaving the demo pages;
      afterwards browser window must be re-opened to be able to access other demos:

      Message: 'JSON' is undefined
      Line: 11
      Char: 283
      Code: 0
      URI: http://10.18.39.149:8080/showcase/javax.faces.resource/util/ace-core.js.jsf?ln=icefaces.ace&v=4_0_0_141029

      1. afterFix.PNG
        27 kB
      2. beforeFix.PNG
        27 kB
      3. console.PNG
        13 kB
      4. p01Pinning.PNG
        20 kB

        Activity

        Hide
        Ken Fyten added a comment -

        Re-opened to have this applied to the 3.3 maintenance branch also.

        Show
        Ken Fyten added a comment - Re-opened to have this applied to the 3.3 maintenance branch also.
        Hide
        Mircea Toma added a comment -

        Back-ported change to 3.3.0-GA branch.

        Show
        Mircea Toma added a comment - Back-ported change to 3.3.0-GA branch.
        Hide
        Liana Munroe added a comment -

        There is now a difference in how the table resizes when scrollable=true. To demonstrate I changed the showcase dataTable > Paginator demo so that scrollable=true. When configuring the table to leave a small remainder of rows on the third page, the table does not snap to the smaller height. This is not the case when scrollable=false, the table does resize to accommodate the lesser height. See screen shots beforeFix.png and afterFix.png

        Show
        Liana Munroe added a comment - There is now a difference in how the table resizes when scrollable=true. To demonstrate I changed the showcase dataTable > Paginator demo so that scrollable=true. When configuring the table to leave a small remainder of rows on the third page, the table does not snap to the smaller height. This is not the case when scrollable=false, the table does resize to accommodate the lesser height. See screen shots beforeFix.png and afterFix.png
        Hide
        Ken Fyten added a comment -

        There is now a difference in how the table resizes when scrollable=true. To demonstrate I changed the showcase dataTable > Paginator demo so that scrollable=true. When configuring the table to leave a small remainder of rows on the third page, the table does not snap to the smaller height. This is not the case when scrollable=false, the table does resize to accommodate the lesser height. See screen shots beforeFix.png and afterFix.png

        I think this is an acceptable change, since when in scrollable="true" mode, having the table resize to match the number of displayed rows would be unexpected. It would be expected behaviour, however, if scrollable-="false", and testing shows that this still behaves as expected.

        Show
        Ken Fyten added a comment - There is now a difference in how the table resizes when scrollable=true. To demonstrate I changed the showcase dataTable > Paginator demo so that scrollable=true. When configuring the table to leave a small remainder of rows on the third page, the table does not snap to the smaller height. This is not the case when scrollable=false, the table does resize to accommodate the lesser height. See screen shots beforeFix.png and afterFix.png I think this is an acceptable change, since when in scrollable="true" mode, having the table resize to match the number of displayed rows would be unexpected. It would be expected behaviour, however, if scrollable-="false", and testing shows that this still behaves as expected.
        Hide
        Liana Munroe added a comment -

        Verified ICEfaces ee-3.3.0 maintenance branch r43950 using SSL and non SSL config Tomcat 7. IE 8 on 2 vms, IE 9, 10, 11. Chrome 39 and FF 34.

        Show
        Liana Munroe added a comment - Verified ICEfaces ee-3.3.0 maintenance branch r43950 using SSL and non SSL config Tomcat 7. IE 8 on 2 vms, IE 9, 10, 11. Chrome 39 and FF 34.

          People

          • Assignee:
            Mircea Toma
            Reporter:
            Carmen Cristurean
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: