ICEfaces
  1. ICEfaces
  2. ICE-10305

ice:panelCollapsible - Expanded panel sets inline padding

          Details

            Description

            When the ice:panelCollapsible header is first rendered, it renders an internal div with a padding set to 0px. When this panel is shown/expanded, this div gets an inline styling that uses a padding: 1px;. In more complex apps this simple change can cause major changes to the layout of other components.

            Either this added padding needs to be removed or it needs to be set when the component is first rendered to prevent the changes in layout.

              Activity

              Descending order - Click to sort in ascending order
              Hide
              Permalink
              Liana Munroe added a comment -

              Verified using component-showcase and ICEfaces 1.8.2 r43383. Tomcat 7, IE 11, Chrome 38, FF 33 DOM inspections.

              Show
              Liana Munroe added a comment - Verified using component-showcase and ICEfaces 1.8.2 r43383. Tomcat 7, IE 11, Chrome 38, FF 33 DOM inspections.
              Hide
              Permalink
              Mircea Toma added a comment -

              Change padding to 0px in the client code just as the renderer does.

              Show
              Mircea Toma added a comment - Change padding to 0px in the client code just as the renderer does.
              Hide
              Permalink
              Arran Mccullough added a comment -

              It looks like the change mentioned in ICE-4674 was implemented in ICE-5308. The issue is still seen with this change though. When the panelCollapsible is rendered it renders the inner div with padding: 0px; Upon expand or contract, this div's padding is changed to 1px;

              Looking at the update returned, the div has padding: 0px; still set, so this additional padding is being set from something else. I did a quick test and setting padding: 1px; in the PanelCollapsibleRendered.java does keep the padding consistent but this might not be best for backwards compatibility.

              This issue can be seen on the show case demo's as well. Load the panel collapsible demo and inspect the header div code. Expand or contract the panel and inspecting the same div shows the change in padding.

              Show
              Arran Mccullough added a comment - It looks like the change mentioned in ICE-4674 was implemented in ICE-5308 . The issue is still seen with this change though. When the panelCollapsible is rendered it renders the inner div with padding: 0px; Upon expand or contract, this div's padding is changed to 1px; Looking at the update returned, the div has padding: 0px; still set, so this additional padding is being set from something else. I did a quick test and setting padding: 1px; in the PanelCollapsibleRendered.java does keep the padding consistent but this might not be best for backwards compatibility. This issue can be seen on the show case demo's as well. Load the panel collapsible demo and inspect the header div code. Expand or contract the panel and inspecting the same div shows the change in padding.

                People

                • Assignee:
                  Mircea Toma
                  Reporter:
                  Arran Mccullough
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: