ICEfaces
  1. ICEfaces
  2. ICE-10279

ace:submenu - Set width depending on contents

    Details

      Description

      Feature Request: Have the ace:submenu tag's width set depending on the size of it's contents. This way if the contents are changed dynamically they can be resized without changing the CSS manually.

      At the moment the width is set to 150px by default.
      1. contextMenu.png
        25 kB
      2. contextMenu-ee3.3branch.png
        46 kB
      3. contextMenu-if4trunk.png
        41 kB
      4. contextMenuTooWide.png
        24 kB
      5. menuBar.PNG
        16 kB
      6. menuRepeat.PNG
        16 kB
      7. menuSeparator.PNG
        17 kB
      8. multi.PNG
        15 kB
      9. showcaseContextMenu1.PNG
        42 kB
      10. showcaseContextMenu2.PNG
        38 kB
      11. showcaseMuliColumnSubMenu.png
        19 kB
      12. sliding1.PNG
        17 kB
      13. sliding2.PNG
        18 kB

        Activity

        Hide
        Liana Munroe added a comment -

        Verified no additional issues (besides ICE-10600) found. ICEfaces EE-3.3.0 maintenance branch r44364, ICEfaces EE-4.0.0 Jenkins build 5. Tomcat 7, IE 11, FF 34, Chrome 41.

        Show
        Liana Munroe added a comment - Verified no additional issues (besides ICE-10600) found. ICEfaces EE-3.3.0 maintenance branch r44364, ICEfaces EE-4.0.0 Jenkins build 5. Tomcat 7, IE 11, FF 34, Chrome 41.
        Hide
        Arturo Zambrano added a comment -

        Marking as fixed. Verified all styling changes in the 4.0 trunk and in the 3.3 EE maintenance branch. The only issue that couldn't be fixed is with the tiered ace:menu on IE7 (3.3 EE maintenance branch). The left arrow icon appears next to the label, instead of appearing at the right edge. Functionality is still normal.

        While working on this JIRA, an issue with sliding menus was found, which could be reproduced before these styling changes. It is described in ICE-10600.

        Show
        Arturo Zambrano added a comment - Marking as fixed. Verified all styling changes in the 4.0 trunk and in the 3.3 EE maintenance branch. The only issue that couldn't be fixed is with the tiered ace:menu on IE7 (3.3 EE maintenance branch). The left arrow icon appears next to the label, instead of appearing at the right edge. Functionality is still normal. While working on this JIRA, an issue with sliding menus was found, which could be reproduced before these styling changes. It is described in ICE-10600.
        Hide
        Arturo Zambrano added a comment -

        r44292: removed extra padding and margins from ul element in all menus; added distinctive class name to root node of ace:menuButton (in 3.3 EE maintenance branch).

        Show
        Arturo Zambrano added a comment - r44292: removed extra padding and margins from ul element in all menus; added distinctive class name to root node of ace:menuButton (in 3.3 EE maintenance branch).
        Hide
        Arturo Zambrano added a comment - - edited

        r44001: committed some fixes to the 3.3 EE maintnenance branch: fixed IE7 issue with submenu headers in plain menus not stretching to the largest width; fixed IE7 issue with deeper menu levels in sliding menus having an indentation; added styling rules to make the root node of ace:menu display like a block element, as before (and without stretching the menu contents).

        Show
        Arturo Zambrano added a comment - - edited r44001: committed some fixes to the 3.3 EE maintnenance branch: fixed IE7 issue with submenu headers in plain menus not stretching to the largest width; fixed IE7 issue with deeper menu levels in sliding menus having an indentation; added styling rules to make the root node of ace:menu display like a block element, as before (and without stretching the menu contents).
        Hide
        Arturo Zambrano added a comment - - edited

        Krashan, as I said before. The first rule you suggested (top: 0) is valid and has already been committed to our code. Thank you.

        The second rule (display: block; ) causes other styling issues that are visible in our internal test applications. And these issues are visible in the other menu components as well (the contents of the menus are stretched to take the entire width of the page). It might look ok in the showcase application, but that might be because of other custom styling in that application in particular.

        The ace:menuBar component, including the root menu, now only takes as much width as it needs, without stretching to the end of the page. This was done on purpose. However, it's debatable whether the root menu of ace:menuBar should take the whole width of the page (as before) or just take no more than it needs. We will review that in a meeting, In any case, to stretch the root menu of ace:menuBar the following rule would be more appropriate, in order to avoid affecting other menu components.

        .ice-ace-menu-bar > .wijmo-wijmenu-horizontal {
        	display:block;
        }
        
        Show
        Arturo Zambrano added a comment - - edited Krashan, as I said before. The first rule you suggested (top: 0) is valid and has already been committed to our code. Thank you. The second rule (display: block; ) causes other styling issues that are visible in our internal test applications. And these issues are visible in the other menu components as well (the contents of the menus are stretched to take the entire width of the page). It might look ok in the showcase application, but that might be because of other custom styling in that application in particular. The ace:menuBar component, including the root menu, now only takes as much width as it needs, without stretching to the end of the page. This was done on purpose. However, it's debatable whether the root menu of ace:menuBar should take the whole width of the page (as before) or just take no more than it needs. We will review that in a meeting, In any case, to stretch the root menu of ace:menuBar the following rule would be more appropriate, in order to avoid affecting other menu components. .ice-ace-menu-bar > .wijmo-wijmenu-horizontal { display:block; }

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Arran Mccullough
          • Votes:
            1 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: