ICEfaces
  1. ICEfaces
  2. ICE-10279

ace:submenu - Set width depending on contents

    Details

      Description

      Feature Request: Have the ace:submenu tag's width set depending on the size of it's contents. This way if the contents are changed dynamically they can be resized without changing the CSS manually.

      At the moment the width is set to 150px by default.
      1. contextMenu.png
        25 kB
      2. contextMenu-ee3.3branch.png
        46 kB
      3. contextMenu-if4trunk.png
        41 kB
      4. contextMenuTooWide.png
        24 kB
      5. menuBar.PNG
        16 kB
      6. menuRepeat.PNG
        16 kB
      7. menuSeparator.PNG
        17 kB
      8. multi.PNG
        15 kB
      9. showcaseContextMenu1.PNG
        42 kB
      10. showcaseContextMenu2.PNG
        38 kB
      11. showcaseMuliColumnSubMenu.png
        19 kB
      12. sliding1.PNG
        17 kB
      13. sliding2.PNG
        18 kB

        Activity

        Arran Mccullough created issue -
        Ken Fyten made changes -
        Field Original Value New Value
        Fix Version/s EE-4.0.0.GA [ 11171 ]
        Fix Version/s EE-3.3.0.GA_P03 [ 11572 ]
        Ken Fyten made changes -
        Assignee Arturo Zambrano [ artzambrano ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #43578 Thu Nov 20 13:29:17 MST 2014 art.zambrano ICE-10279 fixes to allow submenus to take as much width as they need
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/wijmo/wijmo.css
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/menu/MenuRenderer.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/menu/BaseMenuRenderer.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/menubar/MenuBarRenderer.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/contextmenu/ContextMenuRenderer.java
        Hide
        Arturo Zambrano added a comment -

        Committed fix to 4.0 trunk at revision 43578 and to 3.3 EE maintenance branch at revision 43579.

        After trying different approaches, using the CSS property white-space:nowrap; worked best. There's still the issue that when using icons, they won't appear aligned with the label when the label is the widest one in a submenu, even though they are supposed to be aligned by using white-space:nowrap, this doesn't happen because of other necessary CSS involved. Anyway, all this can be fixed at the app level with custom CSS and other workarounds.

        Show
        Arturo Zambrano added a comment - Committed fix to 4.0 trunk at revision 43578 and to 3.3 EE maintenance branch at revision 43579. After trying different approaches, using the CSS property white-space:nowrap; worked best. There's still the issue that when using icons, they won't appear aligned with the label when the label is the widest one in a submenu, even though they are supposed to be aligned by using white-space:nowrap, this doesn't happen because of other necessary CSS involved. Anyway, all this can be fixed at the app level with custom CSS and other workarounds.
        Arturo Zambrano made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Show
        Carmen Cristurean added a comment - - edited Regression test (/submenuResize.jsf) added for ace:menu, ace:menuBar, ace:contextMenu: http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/menu http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/menuBar http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/contextMenu
        Hide
        Carmen Cristurean added a comment -

        Attaching screen shots for ace:contextMenu on IF4 trunk vs EE-3.3 maintenance branch.

        Show
        Carmen Cristurean added a comment - Attaching screen shots for ace:contextMenu on IF4 trunk vs EE-3.3 maintenance branch.
        Carmen Cristurean made changes -
        Attachment contextMenu-ee3.3branch.png [ 17600 ]
        Attachment contextMenu-if4trunk.png [ 17601 ]
        Hide
        Liana Munroe added a comment - - edited

        Reopening as there are styling issues with showcase demos and QA test applications. See attached screen shots.

        Show
        Liana Munroe added a comment - - edited Reopening as there are styling issues with showcase demos and QA test applications. See attached screen shots.
        Liana Munroe made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Liana Munroe made changes -
        Attachment menuBar.PNG [ 17680 ]
        Attachment menuSeparator.PNG [ 17681 ]
        Attachment multi.PNG [ 17682 ]
        Liana Munroe made changes -
        Attachment contextMenu.png [ 17683 ]
        Ken Fyten made changes -
        Assignee Arturo Zambrano [ artzambrano ] Liana Munroe [ liana.munroe ]
        Ken Fyten made changes -
        Affects Version/s EE-3.3.0.GA_P02 [ 11371 ]
        Affects Version/s 4.0 [ 11382 ]
        Ken Fyten made changes -
        Comment [ These issues appear to be resolved as of 4.0 at least on showcase. Please retest and confirm. ]
        Ken Fyten made changes -
        Assignee Liana Munroe [ liana.munroe ] Arturo Zambrano [ artzambrano ]
        Assignee Priority P1 [ 10010 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #43878 Tue Jan 06 15:13:00 MST 2015 art.zambrano ICE-10279 fixes for various styling issues with menu items and submenus
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/wijmo/wijmo.js
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/wijmo/wijmo.css
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/menu/MenuRenderer.java
        Hide
        Arturo Zambrano added a comment -

        r43878: committed fixes to 4.0 trunk for all styling issues with menu items and submenus.

        Show
        Arturo Zambrano added a comment - r43878: committed fixes to 4.0 trunk for all styling issues with menu items and submenus.
        Hide
        Liana Munroe added a comment -

        Tested with ICEfaces 4 trunk r43878. There are still issues present in showcase and the QA test apps when using a sliding or tiered menu.
        1.) The 2nd level tiered submenus with a small label are still displayed in a very wide container, see screen shot titled contextMenuTooWide.png. Test app /submenuResize.jsf
        http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/contextMenu

        2.) Sliding menus do not resize to fit the label content, therefore text is overlapping in the submenu, see screen shots titled sliding1.png, sliding2.png. Test app /submenuResize.jsf
        http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/menu

        3.) Showcase ContextMenu > Delegate. When mousing over the dataTable the initial contextMenu appears too wide, see screen shot showcaseContextMenu1.PNG. When clicking on the contextMenu the second menu is not wide enough for the data present, see screen shot showcaseContextMenu2.PNG

        Show
        Liana Munroe added a comment - Tested with ICEfaces 4 trunk r43878. There are still issues present in showcase and the QA test apps when using a sliding or tiered menu. 1.) The 2nd level tiered submenus with a small label are still displayed in a very wide container, see screen shot titled contextMenuTooWide.png. Test app /submenuResize.jsf http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/contextMenu 2.) Sliding menus do not resize to fit the label content, therefore text is overlapping in the submenu, see screen shots titled sliding1.png, sliding2.png. Test app /submenuResize.jsf http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/menu 3.) Showcase ContextMenu > Delegate. When mousing over the dataTable the initial contextMenu appears too wide, see screen shot showcaseContextMenu1.PNG. When clicking on the contextMenu the second menu is not wide enough for the data present, see screen shot showcaseContextMenu2.PNG
        Liana Munroe made changes -
        Attachment contextMenuTooWide.png [ 17781 ]
        Attachment showcaseContextMenu1.PNG [ 17782 ]
        Attachment showcaseContextMenu2.PNG [ 17783 ]
        Attachment sliding1.PNG [ 17784 ]
        Attachment sliding2.PNG [ 17785 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #43900 Tue Jan 13 09:29:37 MST 2015 art.zambrano ICE-10279 more fixes for various styling issues with menu items and submenus
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/wijmo/wijmo.js
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/wijmo/wijmo.css
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/menu/BaseMenuRenderer.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/wijmo/readme.txt
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/menubar/MenuBarRenderer.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/contextmenu/ContextMenuRenderer.java
        Hide
        Arturo Zambrano added a comment -

        r43900: committed more fixes for various submenu and menu item styling issues, including the context menu issues reported above.

        Trying to fix all these styling issues often results in introducing new issues to other menu components or parts of them. In the latest commit, new CSS rules and classes were introduced to try to keep some styling rules separate between the various menu components.

        Note that this feature of setting width depending on contents was never meant to work on sliding menus, since the width could vary from page to page of the sliding menu, and it is meant to keep the same width at all times. However, we should still test that it's not affected by these changes.

        Testing notes: please verify that no new styling issues were introduced in this latest commit in all browsers and report any issues found.

        Show
        Arturo Zambrano added a comment - r43900: committed more fixes for various submenu and menu item styling issues, including the context menu issues reported above. Trying to fix all these styling issues often results in introducing new issues to other menu components or parts of them. In the latest commit, new CSS rules and classes were introduced to try to keep some styling rules separate between the various menu components. Note that this feature of setting width depending on contents was never meant to work on sliding menus, since the width could vary from page to page of the sliding menu, and it is meant to keep the same width at all times. However, we should still test that it's not affected by these changes. Testing notes: please verify that no new styling issues were introduced in this latest commit in all browsers and report any issues found.
        Hide
        Carmen Cristurean added a comment -

        IF4 trunk r. 43901 testing results (IE11, Chrome39, FF34):
        The tiered menus have been resolved in the QA test apps (issue #1 above), while the sliding menu in the ace:menu QA test app is still an issue (issue #2).

        In showcase > ace:contextMenu > Delegate: in the initial submenu is still too wide, and the arrow renders now underneath the text (all browsers). The second menu being too small for the data present is caused by the wrong data formatting, and is now a separate JIRA, ICE-10444.

        Show
        Carmen Cristurean added a comment - IF4 trunk r. 43901 testing results (IE11, Chrome39, FF34): The tiered menus have been resolved in the QA test apps (issue #1 above), while the sliding menu in the ace:menu QA test app is still an issue (issue #2). In showcase > ace:contextMenu > Delegate: in the initial submenu is still too wide, and the arrow renders now underneath the text (all browsers). The second menu being too small for the data present is caused by the wrong data formatting, and is now a separate JIRA, ICE-10444 .
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #43924 Mon Jan 19 17:47:37 MST 2015 art.zambrano ICE-10279 fixed sliding menu issues; added a way to specify sliding menu width
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/wijmo/wijmo.js
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/wijmo/wijmo.css
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/menu/MenuRenderer.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/menu/BaseMenuRenderer.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/menubar/MenuBarRenderer.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/contextmenu/ContextMenuRenderer.java
        Hide
        Arturo Zambrano added a comment - - edited

        r43924: fixed sliding menu styling issues; added a way to specify sliding menu width.

        Note that sliding menus are not supposed to adjust their width to fit their contents. This type of menu was originally intended for mobile devices and it's meant to maintain the same width across menu tiers.

        The width of a sliding menu was previously set with the '.wijmo-wijmenu-ipod' CSS class. While this is still possible, a new and more intuitive way to set the width of a sliding menu would be by means of the following CSS rule:

        .ice-ace-menu-sliding .wijmo-wijmenu-container {
        	width:180px;
        }
        

        Testing notes: Please test all these components again, since some general modifications were made in the previous approach used to support this behaviour.

        Show
        Arturo Zambrano added a comment - - edited r43924: fixed sliding menu styling issues; added a way to specify sliding menu width. Note that sliding menus are not supposed to adjust their width to fit their contents. This type of menu was originally intended for mobile devices and it's meant to maintain the same width across menu tiers. The width of a sliding menu was previously set with the '.wijmo-wijmenu-ipod' CSS class. While this is still possible, a new and more intuitive way to set the width of a sliding menu would be by means of the following CSS rule: .ice-ace-menu-sliding .wijmo-wijmenu-container { width:180px; } Testing notes: Please test all these components again, since some general modifications were made in the previous approach used to support this behaviour.
        Arturo Zambrano made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Krashan Brahmanjara added a comment -

        Did you check these changes on older browsers?
        After previous commits we notice unwanted and not backward compatibile changes in custom styled menus under Firefox.

        Show
        Krashan Brahmanjara added a comment - Did you check these changes on older browsers? After previous commits we notice unwanted and not backward compatibile changes in custom styled menus under Firefox.
        Arturo Zambrano made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Hide
        Arturo Zambrano added a comment -

        This feature can't be backwards compatible regarding custom-styled menus. To support this feature, it was necessary to make big changes in the core menu styling, having to do with positioning, floats, widths, etc. So, all custom styling will have to be adjusted to these new changes. There's just no other way around it.

        Show
        Arturo Zambrano added a comment - This feature can't be backwards compatible regarding custom-styled menus. To support this feature, it was necessary to make big changes in the core menu styling, having to do with positioning, floats, widths, etc. So, all custom styling will have to be adjusted to these new changes. There's just no other way around it.
        Hide
        Arturo Zambrano added a comment -

        r43927: backported fix to 3.3 EE maintenance branch.

        Show
        Arturo Zambrano added a comment - r43927: backported fix to 3.3 EE maintenance branch.
        Ken Fyten made changes -
        Affects Compatibility/Configuration [ 10002 ]
        Hide
        Krashan Brahmanjara added a comment -

        >This feature can't be backwards compatible regarding custom-styled menus
        Work but youe stylesheet need two changes.

        .ice-ace-menu-bar .wijmo-wijmenu .wijmo-wijmenu-link > .ui-icon {
            top: 0;
        }
        .ui-widget.ui-widget-content.wijmo-wijmenu {
            display: block;
        }
        
        Show
        Krashan Brahmanjara added a comment - >This feature can't be backwards compatible regarding custom-styled menus Work but youe stylesheet need two changes. .ice-ace-menu-bar .wijmo-wijmenu .wijmo-wijmenu-link > .ui-icon { top: 0; } .ui-widget.ui-widget-content.wijmo-wijmenu { display: block; }
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #43952 Mon Jan 26 10:40:27 MST 2015 art.zambrano ICE-10279 moves cursor styling to renderer, as before, to avoid applying it to disabled menu items; added top:0; to arrow icons
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/wijmo/wijmo.css
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/menu/BaseMenuRenderer.java
        Hide
        Arturo Zambrano added a comment -

        The first suggested change is ok. It doesn't cause any visible change in our test apps, but it's still valid, since 'top:0;' was already added to sliding menus, where it was necessary, and it just reinforces the way we want the arrow icon to be displayed.

        The second rule can't be changed, since we need it to be 'display:inline-block;', otherwise, the menus, menu items and submenus take all the width available on the page, which is what this JIRA is trying to change.

        Show
        Arturo Zambrano added a comment - The first suggested change is ok. It doesn't cause any visible change in our test apps, but it's still valid, since 'top:0;' was already added to sliding menus, where it was necessary, and it just reinforces the way we want the arrow icon to be displayed. The second rule can't be changed, since we need it to be 'display:inline-block;', otherwise, the menus, menu items and submenus take all the width available on the page, which is what this JIRA is trying to change.
        Hide
        Arturo Zambrano added a comment -

        r43952: Moved cursor styling to renderer, as before, to avoid applying it to disabled menu items; added 'top:0;' to arrow icons. Committed to 4.0 trunk.

        Show
        Arturo Zambrano added a comment - r43952: Moved cursor styling to renderer, as before, to avoid applying it to disabled menu items; added 'top:0;' to arrow icons. Committed to 4.0 trunk.
        Liana Munroe made changes -
        Attachment menuRepeat.PNG [ 18080 ]
        Hide
        Liana Munroe added a comment - - edited

        Tested ICEfaces 4 trunk r43958. Tomcat 7 all browsers. Menu in ui:repeat now displays menus horizontally instead of vertically. This was not an issue r43873. Please see screenshot menuRepeat.png.
        Test app menuRepeat.jsf
        http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/menu

        Showcase MultiColumnSubmenu > Overview demo - Multi2 Menu has odd spacing between rows of menu items and flows past the width of the demo. Please see screen shot showcaseMuliColumnSubMenu.png

        Show
        Liana Munroe added a comment - - edited Tested ICEfaces 4 trunk r43958. Tomcat 7 all browsers. Menu in ui:repeat now displays menus horizontally instead of vertically. This was not an issue r43873. Please see screenshot menuRepeat.png. Test app menuRepeat.jsf http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/menu Showcase MultiColumnSubmenu > Overview demo - Multi2 Menu has odd spacing between rows of menu items and flows past the width of the demo. Please see screen shot showcaseMuliColumnSubMenu.png
        Liana Munroe made changes -
        Attachment showcaseMuliColumnSubMenu.png [ 18081 ]
        Hide
        Krashan Brahmanjara added a comment -

        Arturo. Both rules was added for backward compatibility and works with app from trunk, modern FF18&up and even old FF3.6

        >.wijmo-wijmenu .wijmo-wijmenu-link > .ui-icon

        { top: 0;}

        this is for old browsers because icon was too low , new browser don't use that

        >ice-ace-menu-bar .ui-widget.ui-widget-content.wijmo-wijmenu

        { display: block;}

        block because inline destroy layut of main horizontal menu with two level submenus

        Show
        Krashan Brahmanjara added a comment - Arturo. Both rules was added for backward compatibility and works with app from trunk, modern FF18&up and even old FF3.6 >.wijmo-wijmenu .wijmo-wijmenu-link > .ui-icon { top: 0;} this is for old browsers because icon was too low , new browser don't use that >ice-ace-menu-bar .ui-widget.ui-widget-content.wijmo-wijmenu { display: block;} block because inline destroy layut of main horizontal menu with two level submenus
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #43982 Thu Jan 29 14:35:45 MST 2015 art.zambrano ICE-10279 added styling rules to make the root node of ace:menu display like a block element, as before
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/wijmo/wijmo.css
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #43984 Thu Jan 29 14:51:43 MST 2015 art.zambrano ICE-10279 decreased width of 'Multi 2' autoflow menu column to make it fit better on the page
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/multiColumnSubmenu/multiColumnSubmenu.xhtml
        Hide
        Arturo Zambrano added a comment -

        r43982: added styling rules to make the root node of ace:menu display like a block element, as before (and without stretching the menu contents).

        r43984: decreased the menu column of the 'Multi 2' menu in the Showcase MultiColumnSubmenu > Overview demo, to make it fit better on the page.

        Note that this fix doesn't apply to multi-column submenus, as each individual ace:menuColumn component has a width attribute (with a default value of 200 pixels) that determines the width of that column. Perhaps, in the future, a boolean attribute could be added to ace:menuColumn to ignore the specified width and automatically adjust the width to its contents. However, this has already been tried before, but it hasn't been possible to accomplish because of other styling constraints in the menu components.

        Show
        Arturo Zambrano added a comment - r43982: added styling rules to make the root node of ace:menu display like a block element, as before (and without stretching the menu contents). r43984: decreased the menu column of the 'Multi 2' menu in the Showcase MultiColumnSubmenu > Overview demo, to make it fit better on the page. Note that this fix doesn't apply to multi-column submenus, as each individual ace:menuColumn component has a width attribute (with a default value of 200 pixels) that determines the width of that column. Perhaps, in the future, a boolean attribute could be added to ace:menuColumn to ignore the specified width and automatically adjust the width to its contents. However, this has already been tried before, but it hasn't been possible to accomplish because of other styling constraints in the menu components.
        Hide
        Arturo Zambrano added a comment - - edited

        Krashan, as I said before. The first rule you suggested (top: 0) is valid and has already been committed to our code. Thank you.

        The second rule (display: block; ) causes other styling issues that are visible in our internal test applications. And these issues are visible in the other menu components as well (the contents of the menus are stretched to take the entire width of the page). It might look ok in the showcase application, but that might be because of other custom styling in that application in particular.

        The ace:menuBar component, including the root menu, now only takes as much width as it needs, without stretching to the end of the page. This was done on purpose. However, it's debatable whether the root menu of ace:menuBar should take the whole width of the page (as before) or just take no more than it needs. We will review that in a meeting, In any case, to stretch the root menu of ace:menuBar the following rule would be more appropriate, in order to avoid affecting other menu components.

        .ice-ace-menu-bar > .wijmo-wijmenu-horizontal {
        	display:block;
        }
        
        Show
        Arturo Zambrano added a comment - - edited Krashan, as I said before. The first rule you suggested (top: 0) is valid and has already been committed to our code. Thank you. The second rule (display: block; ) causes other styling issues that are visible in our internal test applications. And these issues are visible in the other menu components as well (the contents of the menus are stretched to take the entire width of the page). It might look ok in the showcase application, but that might be because of other custom styling in that application in particular. The ace:menuBar component, including the root menu, now only takes as much width as it needs, without stretching to the end of the page. This was done on purpose. However, it's debatable whether the root menu of ace:menuBar should take the whole width of the page (as before) or just take no more than it needs. We will review that in a meeting, In any case, to stretch the root menu of ace:menuBar the following rule would be more appropriate, in order to avoid affecting other menu components. .ice-ace-menu-bar > .wijmo-wijmenu-horizontal { display:block; }
        Hide
        Arturo Zambrano added a comment - - edited

        r44001: committed some fixes to the 3.3 EE maintnenance branch: fixed IE7 issue with submenu headers in plain menus not stretching to the largest width; fixed IE7 issue with deeper menu levels in sliding menus having an indentation; added styling rules to make the root node of ace:menu display like a block element, as before (and without stretching the menu contents).

        Show
        Arturo Zambrano added a comment - - edited r44001: committed some fixes to the 3.3 EE maintnenance branch: fixed IE7 issue with submenu headers in plain menus not stretching to the largest width; fixed IE7 issue with deeper menu levels in sliding menus having an indentation; added styling rules to make the root node of ace:menu display like a block element, as before (and without stretching the menu contents).
        Ken Fyten made changes -
        Assignee Priority P1 [ 10010 ] P3 [ 10012 ]
        Hide
        Arturo Zambrano added a comment -

        r44292: removed extra padding and margins from ul element in all menus; added distinctive class name to root node of ace:menuButton (in 3.3 EE maintenance branch).

        Show
        Arturo Zambrano added a comment - r44292: removed extra padding and margins from ul element in all menus; added distinctive class name to root node of ace:menuButton (in 3.3 EE maintenance branch).
        Hide
        Arturo Zambrano added a comment -

        Marking as fixed. Verified all styling changes in the 4.0 trunk and in the 3.3 EE maintenance branch. The only issue that couldn't be fixed is with the tiered ace:menu on IE7 (3.3 EE maintenance branch). The left arrow icon appears next to the label, instead of appearing at the right edge. Functionality is still normal.

        While working on this JIRA, an issue with sliding menus was found, which could be reproduced before these styling changes. It is described in ICE-10600.

        Show
        Arturo Zambrano added a comment - Marking as fixed. Verified all styling changes in the 4.0 trunk and in the 3.3 EE maintenance branch. The only issue that couldn't be fixed is with the tiered ace:menu on IE7 (3.3 EE maintenance branch). The left arrow icon appears next to the label, instead of appearing at the right edge. Functionality is still normal. While working on this JIRA, an issue with sliding menus was found, which could be reproduced before these styling changes. It is described in ICE-10600.
        Arturo Zambrano made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Liana Munroe added a comment -

        Verified no additional issues (besides ICE-10600) found. ICEfaces EE-3.3.0 maintenance branch r44364, ICEfaces EE-4.0.0 Jenkins build 5. Tomcat 7, IE 11, FF 34, Chrome 41.

        Show
        Liana Munroe added a comment - Verified no additional issues (besides ICE-10600) found. ICEfaces EE-3.3.0 maintenance branch r44364, ICEfaces EE-4.0.0 Jenkins build 5. Tomcat 7, IE 11, FF 34, Chrome 41.
        Ken Fyten made changes -
        Fix Version/s 4.1 [ 11375 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Arran Mccullough
          • Votes:
            1 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: