ICEfaces
  1. ICEfaces
  2. ICE-10173

mobi:sms "message" and "number" attributes should be required.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.0.BETA
    • Fix Version/s: 4.0
    • Component/s: MOBI-Components
    • Labels:
      None
    • Environment:
      Icefaces 4 trunk, mobi:sms tld doc
    • Assignee Priority:
      P2
    • Affects:
      Documentation (User Guide, Ref. Guide, etc.)

      Description

      Please change "message" and "number" attributes to Required.
      These attributes are shown as not Required in the tld doc for mobi:sms. When the attributes are not included in the component an http status 500 error appears:
      java.lang.NullPointerException org.icefaces.mobi.component.sms.SmsRenderer.escapeString(SmsRenderer.java:78) org.icefaces.mobi.component.sms.SmsRenderer.encodeEnd(SmsRenderer.java:57) javax.faces.component.UIComponentBase.encodeEnd(UIComponentBase.java:919) javax.faces.component.UIComponent.encodeAll(UIComponent.java:1863)

        Activity

        Hide
        Liana Munroe added a comment -

        Verified ICEfaces4 trunk r42510. Tomcat 7, android 4.4.2, ios 7 and all modern desktop browsers.

        Show
        Liana Munroe added a comment - Verified ICEfaces4 trunk r42510. Tomcat 7, android 4.4.2, ios 7 and all modern desktop browsers.
        Hide
        Judy Guglielmin added a comment -

        rev 42323...if the script generation for Bridgeit throws an exception, then the button is disabled, server log states that number and message must not be null and a FacesMessage is generated for the id (in case h:message for="idOfsmsComp"/> is present).

        Show
        Judy Guglielmin added a comment - rev 42323...if the script generation for Bridgeit throws an exception, then the button is disabled, server log states that number and message must not be null and a FacesMessage is generated for the id (in case h:message for="idOfsmsComp"/> is present).
        Hide
        Judy Guglielmin added a comment -

        will reopen and make the button disabled so it is apparent that something is wrong.

        Show
        Judy Guglielmin added a comment - will reopen and make the button disabled so it is apparent that something is wrong.
        Hide
        Liana Munroe added a comment -

        Verified ICEfaces 4 trunk r42320. Tomcat 7, ios 7, Android 4.4.2

        Show
        Liana Munroe added a comment - Verified ICEfaces 4 trunk r42320. Tomcat 7, ios 7, Android 4.4.2
        Hide
        Judy Guglielmin added a comment -

        Basically if a number or message is null, then a message is logged to server log and a Faces Message will be posted to the component:-
        <h3> another form to test sms without message</h3>
        <h:form id="test2">
        <mobi:fieldsetGroup>
        <mobi:fieldsetRow>
        No message
        </mobi:fieldsetRow>
        <mobi:fieldsetRow>
        <mobi:sms id="smsButton" number="#

        {smsBean.number}

        "/>
        <h:message for="smsButton"/>
        </mobi:fieldsetRow>
        </mobi:fieldsetGroup>
        </h:form>

        for testing....

        Show
        Judy Guglielmin added a comment - Basically if a number or message is null, then a message is logged to server log and a Faces Message will be posted to the component:- <h3> another form to test sms without message</h3> <h:form id="test2"> <mobi:fieldsetGroup> <mobi:fieldsetRow> No message </mobi:fieldsetRow> <mobi:fieldsetRow> <mobi:sms id="smsButton" number="# {smsBean.number} "/> <h:message for="smsButton"/> </mobi:fieldsetRow> </mobi:fieldsetGroup> </h:form> for testing....

          People

          • Assignee:
            Judy Guglielmin
            Reporter:
            Liana Munroe
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: