ICEfaces
  1. ICEfaces
  2. ICE-10173

mobi:sms "message" and "number" attributes should be required.

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 4.0.BETA
          • Fix Version/s: 4.0
          • Component/s: MOBI-Components
          • Labels:
            None
          • Environment:
            Icefaces 4 trunk, mobi:sms tld doc
          • Assignee Priority:
            P2
          • Affects:
            Documentation (User Guide, Ref. Guide, etc.)

            Description

            Please change "message" and "number" attributes to Required.
            These attributes are shown as not Required in the tld doc for mobi:sms. When the attributes are not included in the component an http status 500 error appears:
            java.lang.NullPointerException org.icefaces.mobi.component.sms.SmsRenderer.escapeString(SmsRenderer.java:78) org.icefaces.mobi.component.sms.SmsRenderer.encodeEnd(SmsRenderer.java:57) javax.faces.component.UIComponentBase.encodeEnd(UIComponentBase.java:919) javax.faces.component.UIComponent.encodeAll(UIComponent.java:1863)

              Activity

              Ascending order - Click to sort in descending order
              Liana Munroe created issue -
              Liana Munroe made changes -
              Field Original Value New Value
              Description Please change "message" and "number attributes to Required.
              These attributes are shown as not Required in the tld doc for mobi:sms. When the attributes are not included in the component an http status 500 error appears:
              java.lang.NullPointerException org.icefaces.mobi.component.sms.SmsRenderer.escapeString(SmsRenderer.java:78) org.icefaces.mobi.component.sms.SmsRenderer.encodeEnd(SmsRenderer.java:57) javax.faces.component.UIComponentBase.encodeEnd(UIComponentBase.java:919) javax.faces.component.UIComponent.encodeAll(UIComponent.java:1863)               		Please change "message" and "number" attributes to Required.
              These attributes are shown as not Required in the tld doc for mobi:sms. When the attributes are not included in the component an http status 500 error appears:
              java.lang.NullPointerException org.icefaces.mobi.component.sms.SmsRenderer.escapeString(SmsRenderer.java:78) org.icefaces.mobi.component.sms.SmsRenderer.encodeEnd(SmsRenderer.java:57) javax.faces.component.UIComponentBase.encodeEnd(UIComponentBase.java:919) javax.faces.component.UIComponent.encodeAll(UIComponent.java:1863)
              Ken Fyten made changes -
              Summary mobi:sms tld doc requires update mobi:sms "message" and "number" attributes should be required.
              Assignee Judy Guglielmin [ judy.guglielmin ]
              Fix Version/s 4.0 [ 11382 ]
              Affects Version/s 4.0.BETA [ 10770 ]
              Affects Documentation (User Guide, Ref. Guide, etc.) [ 10003 ]
              Assignee Priority P2 [ 10011 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #42320 Thu Aug 28 09:03:36 MDT 2014 judy.guglielmin ICE-10173 now the component will log a server side message that message and number attributes must be non-null. Will also log a FacesMessage for the component if an h:message tag for the component is present.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/sms/SmsRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/sms/SmsMeta.java
              Hide
              Permalink
              Judy Guglielmin added a comment -

              Basically if a number or message is null, then a message is logged to server log and a Faces Message will be posted to the component:-
              <h3> another form to test sms without message</h3>
              <h:form id="test2">
              <mobi:fieldsetGroup>
              <mobi:fieldsetRow>
              No message
              </mobi:fieldsetRow>
              <mobi:fieldsetRow>
              <mobi:sms id="smsButton" number="#

              {smsBean.number}

              "/>
              <h:message for="smsButton"/>
              </mobi:fieldsetRow>
              </mobi:fieldsetGroup>
              </h:form>

              for testing....

              Show
              Judy Guglielmin added a comment - Basically if a number or message is null, then a message is logged to server log and a Faces Message will be posted to the component:- <h3> another form to test sms without message</h3> <h:form id="test2"> <mobi:fieldsetGroup> <mobi:fieldsetRow> No message </mobi:fieldsetRow> <mobi:fieldsetRow> <mobi:sms id="smsButton" number="# {smsBean.number} "/> <h:message for="smsButton"/> </mobi:fieldsetRow> </mobi:fieldsetGroup> </h:form> for testing....
              Judy Guglielmin made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Liana Munroe added a comment -

              Verified ICEfaces 4 trunk r42320. Tomcat 7, ios 7, Android 4.4.2

              Show
              Liana Munroe added a comment - Verified ICEfaces 4 trunk r42320. Tomcat 7, ios 7, Android 4.4.2
              Hide
              Permalink
              Judy Guglielmin added a comment -

              will reopen and make the button disabled so it is apparent that something is wrong.

              Show
              Judy Guglielmin added a comment - will reopen and make the button disabled so it is apparent that something is wrong.
              Judy Guglielmin made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Ken Fyten made changes -
              Security Private [ 10001 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #42323 Thu Aug 28 11:10:00 MDT 2014 judy.guglielmin ICE-10173 made button disabled unless number and message attributes present and don't throw exception upon generating the script for bridgeit.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/sms/SmsRenderer.java
              Hide
              Permalink
              Judy Guglielmin added a comment -

              rev 42323...if the script generation for Bridgeit throws an exception, then the button is disabled, server log states that number and message must not be null and a FacesMessage is generated for the id (in case h:message for="idOfsmsComp"/> is present).

              Show
              Judy Guglielmin added a comment - rev 42323...if the script generation for Bridgeit throws an exception, then the button is disabled, server log states that number and message must not be null and a FacesMessage is generated for the id (in case h:message for="idOfsmsComp"/> is present).
              Judy Guglielmin made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Liana Munroe added a comment -

              Verified ICEfaces4 trunk r42510. Tomcat 7, android 4.4.2, ios 7 and all modern desktop browsers.

              Show
              Liana Munroe added a comment - Verified ICEfaces4 trunk r42510. Tomcat 7, android 4.4.2, ios 7 and all modern desktop browsers.
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Judy Guglielmin
                  Reporter:
                  Liana Munroe
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: