ICEfaces
  1. ICEfaces
  2. ICE-10154

Review and document all icecore:config attributes

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.0.BETA
    • Fix Version/s: 4.0
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      ICEfaces 4
    • Assignee Priority:
      P2
    • Affects:
      Documentation (User Guide, Ref. Guide, etc.)

      Description

      As part of ICE-10021, we updated the icecore Wiki documentation and TLD files to be more comprehensive. However the icecore:config attributes appear to not be complete. We need to review and document the relevant attributes.

        Activity

        Hide
        Deryk Sinotte added a comment -

        These are the currently supported attributes according to the ConfigHandler class:

            public ConfigHandler(TagConfig config) {
                super(config);
                this.render = this.getAttribute("render");
                this.ariaEnabled = this.getAttribute("ariaEnabled");
                this.blockUIOnSubmit = this.getAttribute("blockUIOnSubmit");
                this.lazyPush = this.getAttribute("lazyPush");
                this.subtreeDiff = this.getAttribute("subtreeDiff");
                this.diffConfig = this.getAttribute("diffConfig");
                this.mandatoryResource = this.getAttribute("mandatoryResource");
                this.messagePersistence = this.getAttribute("messagePersistence");
                this.focusManaged = this.getAttribute("focusManaged");
            }
        

        The information needs to be added to the core TLD as well as to the Wiki (http://www.icesoft.org/wiki/display/ICE/config). Any missing tests should be provided to QA as well so they can exercise the attributes going forward.

        Show
        Deryk Sinotte added a comment - These are the currently supported attributes according to the ConfigHandler class: public ConfigHandler(TagConfig config) { super (config); this .render = this .getAttribute( "render" ); this .ariaEnabled = this .getAttribute( "ariaEnabled" ); this .blockUIOnSubmit = this .getAttribute( "blockUIOnSubmit" ); this .lazyPush = this .getAttribute( "lazyPush" ); this .subtreeDiff = this .getAttribute( "subtreeDiff" ); this .diffConfig = this .getAttribute( "diffConfig" ); this .mandatoryResource = this .getAttribute( "mandatoryResource" ); this .messagePersistence = this .getAttribute( "messagePersistence" ); this .focusManaged = this .getAttribute( "focusManaged" ); } The information needs to be added to the core TLD as well as to the Wiki ( http://www.icesoft.org/wiki/display/ICE/config ). Any missing tests should be provided to QA as well so they can exercise the attributes going forward.
        Hide
        Mircea Toma added a comment -

        Completed documentation for the attributes in the Wiki page.

        Show
        Mircea Toma added a comment - Completed documentation for the attributes in the Wiki page.
        Hide
        Krashan Brahmanjara added a comment -

        Param org.icefaces.render seems to be unused.

        Also very old subtreeDiff param seems to be unnecessary on jsf 2.2/myfaces 2.2 plaform. Do we still need that?
        Primefaces do not use any complex DOMPartialViewContext or ResponseWriters and works correct and fast.

        In my tests with context-param org.icefaces.subtreeDiff=false
        everything works the same except one TabSetRenderer issue.
        Also this setting improve compatibility with Primefaces.

        Show
        Krashan Brahmanjara added a comment - Param org.icefaces.render seems to be unused. Also very old subtreeDiff param seems to be unnecessary on jsf 2.2/myfaces 2.2 plaform. Do we still need that? Primefaces do not use any complex DOMPartialViewContext or ResponseWriters and works correct and fast. In my tests with context-param org.icefaces.subtreeDiff=false everything works the same except one TabSetRenderer issue. Also this setting improve compatibility with Primefaces.

          People

          • Assignee:
            Mircea Toma
            Reporter:
            Deryk Sinotte
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: