ICEfaces
  1. ICEfaces
  2. ICE-10129

Add the capability to dynamically change the lang attribute of an <html> tag.

          Details

            Description

            Feature Request: Currently for Internationalization with ICEfaces we recommend changing the f:view locale attribute to reflect the change in locale. The issue with this is that it does not reflect these changes to the <html> lang attribute.

            The HTML lang attribute helps search robots interpret the page and provide tools such as automatic translation. This is an SEO recommendation.

            First step would be to see if this is possible under the JSF/ICEfaces framework.

              Activity

              Ascending order - Click to sort in descending order
              Arran Mccullough created issue -
              Ken Fyten made changes -
              Field Original Value New Value
              Fix Version/s 4.1 [ 11375 ]
              Ken Fyten made changes -
              Fix Version/s EE-4.1.0.GA [ 12171 ]
              Fix Version/s 4.1 [ 11375 ]
              Ken Fyten made changes -
              Assignee Arturo Zambrano [ artzambrano ]
              Fix Version/s EE-3.3.0.GA_P04 [ 12270 ]
              Assignee Priority P2 [ 10011 ]
              Hide
              Permalink
              Arran Mccullough added a comment -

              Uploaded sample test case showing issue when dynamically changing the HTML lang attribute.

              Steps:

              • Load welcomeICEfaces.jsf
              • Click on the links to change the locale/lang. An error will show shown in the server console: org.icefaces.impl.util.DOMUtils.nodeDiff Diff propagated to root but no ID set [html: null]
              Show
              Arran Mccullough added a comment - Uploaded sample test case showing issue when dynamically changing the HTML lang attribute. Steps: Load welcomeICEfaces.jsf Click on the links to change the locale/lang. An error will show shown in the server console: org.icefaces.impl.util.DOMUtils.nodeDiff Diff propagated to root but no ID set [html: null]
              Arran Mccullough made changes -
              Attachment Case12927Example.war [ 22117 ]
              Attachment Case12927Example.zip [ 22118 ]
              Ken Fyten made changes -
              Assignee Arturo Zambrano [ artzambrano ] Mircea Toma [ mircea.toma ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #48531 Mon Mar 21 16:50:03 MDT 2016 mircea.toma ICE-10129 Add 'id' attribute to the 'html' element to allow for attribute updating.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/core/src/main/java/org/icefaces/impl/context/DOMResponseWriter.java
              Hide
              Permalink
              Mircea Toma added a comment - - edited

              Modified DOMResposeWriter to add an 'id' attribute to the 'html' element when missing so that element's attributes can be updated. The 'id' attribute is added only when org.icefaces.diffConfig contains the 'att' setting since only then the 'html' attributes can be modified, full 'html' element update was never supported by JSF or most of the browsers.

              Show
              Mircea Toma added a comment - - edited Modified DOMResposeWriter to add an 'id' attribute to the 'html' element when missing so that element's attributes can be updated. The 'id' attribute is added only when org.icefaces.diffConfig contains the 'att' setting since only then the 'html' attributes can be modified, full 'html' element update was never supported by JSF or most of the browsers.
              Mircea Toma made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Carmen Cristurean made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Ken Fyten made changes -
              Assignee Priority P2 [ 10011 ] P1 [ 10010 ]
              Hide
              Permalink
              Mircea Toma added a comment -

              Verify if org.icefaces.diffConfig parameter is null before using its value.

              Show
              Mircea Toma added a comment - Verify if org.icefaces.diffConfig parameter is null before using its value.
              Mircea Toma made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #48551 Wed Mar 23 15:50:18 MDT 2016 mircea.toma ICE-10129 Verify if org.icefaces.diffConfig parameter is null.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/core/src/main/java/org/icefaces/impl/context/DOMResponseWriter.java
              Hide
              Permalink
              Mircea Toma added a comment - - edited

              As already explained above the following context parameter needs to be added into web.xml file in order for the updates to work:

                  <context-param>
        <param-name>org.icefaces.diffConfig</param-name>
        <param-value>att</param-value>
    </context-param>
              Show
              Mircea Toma added a comment - - edited As already explained above the following context parameter needs to be added into web.xml file in order for the updates to work: <context-param> <param-name>org.icefaces.diffConfig</param-name> <param-value>att</param-value> </context-param>
              Ken Fyten made changes -
              Fix Version/s EE-4.1.0.BETA [ 13072 ]
              Ken Fyten made changes -
              Fix Version/s 4.2.BETA [ 13091 ]
              Fix Version/s 4.2 [ 12870 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Mircea Toma
                  Reporter:
                  Arran Mccullough
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: