ICEfaces
  1. ICEfaces
  2. ICE-10122

ace:dataTable - Scrollbar shown when table items is less than the scroll height

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-3.3.0.GA_P02
    • Fix Version/s: 4.0, EE-3.3.0.GA_P03
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      All

      Description

      When and ace:dataTable is set to use scrolling an the number of items that are shown is less than the scroll height, a scrollbar is still shown and this is causing an alignment issue with the header and body columns.

        Activity

        Hide
        Arran Mccullough added a comment -

        The following issue can be reproduced with the Showcase demo. Here is a comment from the customer on this:

        "I was able to reproduce the problem with your showcase app by changing the DEFAULT_LIST_SIZE value in DataTableData from 30 to 5 to simulate our issue. When the Scolling example under ace:dataTable in showcase is displayed, you will see that the vertical scroll bar is displayed (even though all 5 rows are displayed so no scroll bar should appear) and the column headings are misaligned with the table data. "

        I also have a basic test case where I can see the issue as well. Screen shot to be attached shortly.

        Show
        Arran Mccullough added a comment - The following issue can be reproduced with the Showcase demo. Here is a comment from the customer on this: "I was able to reproduce the problem with your showcase app by changing the DEFAULT_LIST_SIZE value in DataTableData from 30 to 5 to simulate our issue. When the Scolling example under ace:dataTable in showcase is displayed, you will see that the vertical scroll bar is displayed (even though all 5 rows are displayed so no scroll bar should appear) and the column headings are misaligned with the table data. " I also have a basic test case where I can see the issue as well. Screen shot to be attached shortly.
        Hide
        Arturo Zambrano added a comment -

        Committed fix at revision 41860. The fix consists in various changes in the scroll resizing logic to make sure that the header table always gets a margin adjustment so it aligns with the body table.

        The vertical scrollbar wasn't causing the misalignments. Some other parts of the logic to resize the table were causing them. The vertical scrollbar will always be visible in order to make more consistent resizing calculations. This was decided when fixing ICE-9908 and ICE-10040.

        Show
        Arturo Zambrano added a comment - Committed fix at revision 41860. The fix consists in various changes in the scroll resizing logic to make sure that the header table always gets a margin adjustment so it aligns with the body table. The vertical scrollbar wasn't causing the misalignments. Some other parts of the logic to resize the table were causing them. The vertical scrollbar will always be visible in order to make more consistent resizing calculations. This was decided when fixing ICE-9908 and ICE-10040 .
        Hide
        Liana Munroe added a comment -

        Verified Icefaces 4 trunk r42011. Tomcat 7, all browsers.
        Fix still has to be committed to EE-maintenance branch as issue still exists on r42011

        Show
        Liana Munroe added a comment - Verified Icefaces 4 trunk r42011. Tomcat 7, all browsers. Fix still has to be committed to EE-maintenance branch as issue still exists on r42011
        Hide
        Arturo Zambrano added a comment -

        r42012: committed fix to 3.3 EE branch.

        Show
        Arturo Zambrano added a comment - r42012: committed fix to 3.3 EE branch.
        Hide
        Liana Munroe added a comment -

        Verified Icefaces EE-3.3.0 maintenance branch r42012. Tomcat 7, all browsers.

        Show
        Liana Munroe added a comment - Verified Icefaces EE-3.3.0 maintenance branch r42012. Tomcat 7, all browsers.

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Arran Mccullough
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: