ICEfaces
  1. ICEfaces
  2. ICE-10048

ace:comboBox - Selection not shown when component is disabled/readonly

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: EE-3.3.0.GA_P01, 4.0.BETA
    • Fix Version/s: EE-3.3.0.GA_P02, 4.0
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      All

      Description

      After making a selection for the comboBox (or if selection is made on render) and then disabling/setting readonly the combo box, the selection is not shown. Changing the component to be enabled shows the selection again.

        Activity

        Hide
        Arran Mccullough added a comment -

        Attached test case that shows the issue. Note: The icefaces, icefaces-ace, and icefaces-compat jar files need to be added into the war to run.

        Steps:

        • Load welcomeICEfaces.jsf
        • Make a selection from the comboBox.
        • Click the Toggle Combo button, the selection is now no longer shown.
        • Click the button again, the selection is now shown.
        Show
        Arran Mccullough added a comment - Attached test case that shows the issue. Note: The icefaces, icefaces-ace, and icefaces-compat jar files need to be added into the war to run. Steps: Load welcomeICEfaces.jsf Make a selection from the comboBox. Click the Toggle Combo button, the selection is now no longer shown. Click the button again, the selection is now shown.
        Hide
        Arturo Zambrano added a comment -

        Committed fix to 4.0 trunk at revision 41252, to 3.3 EE maintenance branch at revision 41251 and to the P02 tag at revision 41253. The problem was that when updating the value when the component is disabled or readonly, the old input text node was being updated, which wasn't visible, instead of the new one, and this was because when the component is disabled or readonly, it is not initialized, so all the node references aren't updated. This was fixed by updating those necessary node references. Also added a fix to prevent JS errors when the first time the component loads is disabled or readonly and added another fix to also set the hidden input field to disabled/readonly, since that's the one that actually gets decoded in the server side.

        Show
        Arturo Zambrano added a comment - Committed fix to 4.0 trunk at revision 41252, to 3.3 EE maintenance branch at revision 41251 and to the P02 tag at revision 41253. The problem was that when updating the value when the component is disabled or readonly, the old input text node was being updated, which wasn't visible, instead of the new one, and this was because when the component is disabled or readonly, it is not initialized, so all the node references aren't updated. This was fixed by updating those necessary node references. Also added a fix to prevent JS errors when the first time the component loads is disabled or readonly and added another fix to also set the hidden input field to disabled/readonly, since that's the one that actually gets decoded in the server side.
        Hide
        Liana Munroe added a comment -

        Verified with Tomcat 7 using test case, all browsers, Icefaces ee-3.3.0 maintenance branch , Icefaces 4 trunk, and P02 tag r 41254.

        Show
        Liana Munroe added a comment - Verified with Tomcat 7 using test case, all browsers, Icefaces ee-3.3.0 maintenance branch , Icefaces 4 trunk, and P02 tag r 41254.

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Arran Mccullough
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: