ICEfaces
  1. ICEfaces
  2. ICE-10020

Should not be able to delete name from fileEntry before submitting in IE

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: EE-3.3.0.GA_P01, 4.0.BETA
    • Fix Version/s: EE-3.3.0.GA_P02, 4.0
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      IE10, ace cmponents

      Description

      Browse and select file to upload -> before you submit put the indicator on the file path and remove it using backspace -> click submit.
       
       The file will be submitted with no issues.

      Should disable the submit if file name is not detected on client.

        Activity

        Hide
        Ken Fyten added a comment -

        Seems like IE10 allows the user to edit the file/path entry field, but really, they can only type something which will erase the previously selected file, but not allow them to enter actual content into the field. Pressing space in the field causes the file selection dialog to open.

        I think the issue here is that the fileEntry component doesn't clear the previously selected filename if the user just type something into the path field which clears it out. Maybe there is a special DOM event we need to listen for in this case.

        Show
        Ken Fyten added a comment - Seems like IE10 allows the user to edit the file/path entry field, but really, they can only type something which will erase the previously selected file, but not allow them to enter actual content into the field. Pressing space in the field causes the file selection dialog to open. I think the issue here is that the fileEntry component doesn't clear the previously selected filename if the user just type something into the path field which clears it out. Maybe there is a special DOM event we need to listen for in this case.
        Hide
        Arturo Zambrano added a comment - - edited

        Committed fix to 4.0 trunk at revision 41174 and to 3.3. EE maintenance branch at revision 41175.

        This issue could also be reproduced on IE7, IE8, and IE9, besides IE10. It could also be reproduced with the delete key. Since the whole file path was deleted with a single backspace or delete keypress, an onkeydown event was added that listens for a backspace or delete keypress on the file input field to clear the file selection, using our internal API, so that nothing gets submitted. This only applies to the non-multiple case, since when ace:fileEntry is in multiple mode, the actual file input elements are not exposed to the user.

        Show
        Arturo Zambrano added a comment - - edited Committed fix to 4.0 trunk at revision 41174 and to 3.3. EE maintenance branch at revision 41175. This issue could also be reproduced on IE7, IE8, and IE9, besides IE10. It could also be reproduced with the delete key. Since the whole file path was deleted with a single backspace or delete keypress, an onkeydown event was added that listens for a backspace or delete keypress on the file input field to clear the file selection, using our internal API, so that nothing gets submitted. This only applies to the non-multiple case, since when ace:fileEntry is in multiple mode, the actual file input elements are not exposed to the user.
        Hide
        Carmen Cristurean added a comment -

        Verified with EE-3.3.0-maintenance branch rev. 41176 in IE10/7.
        Issue still present with ICEfaces4 trunk rev. 41176 (showcase > Listener/Validation).

        Show
        Carmen Cristurean added a comment - Verified with EE-3.3.0-maintenance branch rev. 41176 in IE10/7. Issue still present with ICEfaces4 trunk rev. 41176 (showcase > Listener/Validation).
        Hide
        Arturo Zambrano added a comment -

        Comitted fix to 4.0 trunk at revision 41181. Added special function to completely clear file selection in the single case, copied form the 3.3 EE branch.

        Show
        Arturo Zambrano added a comment - Comitted fix to 4.0 trunk at revision 41181. Added special function to completely clear file selection in the single case, copied form the 3.3 EE branch.
        Hide
        Carmen Cristurean added a comment -

        Verified with ICEfaces4 trunk rev. 41181 in IE7/8/10.

        Show
        Carmen Cristurean added a comment - Verified with ICEfaces4 trunk rev. 41181 in IE7/8/10.

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Judy Guglielmin
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: