[PUSH-388] Include the uri of a cloud push notification in the public API - ICEsoft JIRA Issue Tracker

Details

Type: Improvement
Status: Resolved
Priority: Major
Resolution: Fixed
Affects Version/s: EE-4.0.0.GA, 4.1
Fix Version/s: EE-4.2.0.GA
Component/s: Push Library
Labels:
None
Environment:
ICEfaces, ICEpush

Assignee Priority:
P1

Description

When issuing a request for a push eligible for cloud push, a subject, detail and uri can be specified. Currently the ICEfaces' PushMessage and the ICEpush' PushNotification only exposes the subject and detail. We should improve this APIs to expose them more clearly and naming the uri something more sensible like targetURI or destinationURI. The fact that they are part of either PushMessage and PushNotification should make its intend clear.

Issue Links

blocks

ICE-11004 showcase & poll - mobi:cloudPush demo update required for URI cloudPush API changes

Closed

Activity

Ascending order - Click to sort in descending order

Jack Van Ooststroom created issue - 29/Mar/16 6:21 AM

Jack Van Ooststroom made changes - 29/Mar/16 6:21 AM

Field	Original Value	New Value
Assignee		Jack Van Ooststroom [ jack.van.ooststroom ]

Jack Van Ooststroom made changes - 29/Mar/16 6:21 AM

Fix Version/s

EE-4.1.0.GA [ 12172 ]

Jack Van Ooststroom made changes - 29/Mar/16 6:22 AM

Description

When issuing a request for a push eligible for cloud push, a subject, detail and uri can be specified. Currently the ICEfaces' PushOptions does not expose any of these, while the ICEpush' PushNotification only exposes the subject and detail. We should improve this APIs to expose them more clearly and naming the uri something more sensible like targetURI or destinationURI. The fact that they are part of either PushOptions and PushNotification should make its intend clear.

Hide

Permalink

Jack Van Ooststroom added a comment - 31/Mar/16 1:18 PM

Sending icepush/core/src/main/java/org/icepush/ConfirmationTimeout.java
Sending icepush/core/src/main/java/org/icepush/PushConfiguration.java
Sending icepush/core/src/main/java/org/icepush/PushContext.java
Sending icepush/core/src/main/java/org/icepush/PushNotification.java
Transmitting file data ....
Committed revision 48586.

Sending core/src/main/java/org/icefaces/application/PushMessage.java
Sending core/src/main/java/org/icefaces/application/PushOptions.java
Sending core/src/main/java/org/icefaces/application/PushOthers.java
Sending core/src/main/java/org/icefaces/application/PushRenderer.java
Transmitting file data ....
Committed revision 48587.

Sending samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/mobi/cloudpush/CloudPushBean.java
Transmitting file data .
Committed revision 48588.

Show

Jack Van Ooststroom added a comment - 31/Mar/16 1:18 PM Sending icepush/core/src/main/java/org/icepush/ConfirmationTimeout.java Sending icepush/core/src/main/java/org/icepush/PushConfiguration.java Sending icepush/core/src/main/java/org/icepush/PushContext.java Sending icepush/core/src/main/java/org/icepush/PushNotification.java Transmitting file data .... Committed revision 48586. Sending core/src/main/java/org/icefaces/application/PushMessage.java Sending core/src/main/java/org/icefaces/application/PushOptions.java Sending core/src/main/java/org/icefaces/application/PushOthers.java Sending core/src/main/java/org/icefaces/application/PushRenderer.java Transmitting file data .... Committed revision 48587. Sending samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/mobi/cloudpush/CloudPushBean.java Transmitting file data . Committed revision 48588.

Hide

Permalink

Jack Van Ooststroom added a comment - 31/Mar/16 1:22 PM

Both ICEpush' PushNotification and ICEfaces' PushMessage expose the targetURI as a java.net.URI. Underneath the targetURI is being put into the attributeMap as a java.lang.String. Before it gets passed onto the Cloud Notification Service the targetURI is being remapped to uri. Guards have been placed in PushNotification and PushMessage as well as in PushContext to ensure the right contents. Marking this one as FIXED.

Show

Jack Van Ooststroom added a comment - 31/Mar/16 1:22 PM Both ICEpush' PushNotification and ICEfaces' PushMessage expose the targetURI as a java.net.URI . Underneath the targetURI is being put into the attributeMap as a java.lang.String . Before it gets passed onto the Cloud Notification Service the targetURI is being remapped to uri . Guards have been placed in PushNotification and PushMessage as well as in PushContext to ensure the right contents. Marking this one as FIXED.

Jack Van Ooststroom made changes - 31/Mar/16 1:22 PM

Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#48586	Thu Mar 31 13:22:35 MDT 2016	jack.van.ooststroom	Fixed JIRA ~~PUSH-388~~ : Include the uri of a cloud push notification in the public API
				Files Changed
				MODIFY /icepush/trunk/icepush/core/src/main/java/org/icepush/PushConfiguration.java MODIFY /icepush/trunk/icepush/core/src/main/java/org/icepush/PushContext.java MODIFY /icepush/trunk/icepush/core/src/main/java/org/icepush/ConfirmationTimeout.java MODIFY /icepush/trunk/icepush/core/src/main/java/org/icepush/PushNotification.java

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#48587	Thu Mar 31 13:23:32 MDT 2016	jack.van.ooststroom	Fixed JIRA ~~PUSH-388~~ : Include the uri of a cloud push notification in the public API
				Files Changed
				MODIFY /icefaces4/trunk/icefaces/core/src/main/java/org/icefaces/application/PushMessage.java MODIFY /icefaces4/trunk/icefaces/core/src/main/java/org/icefaces/application/PushRenderer.java MODIFY /icefaces4/trunk/icefaces/core/src/main/java/org/icefaces/application/PushOptions.java MODIFY /icefaces4/trunk/icefaces/core/src/main/java/org/icefaces/application/PushOthers.java

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#48588	Thu Mar 31 13:23:58 MDT 2016	jack.van.ooststroom	Fixed JIRA ~~PUSH-388~~ : Include the uri of a cloud push notification in the public API
				Files Changed
				MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/mobi/cloudpush/CloudPushBean.java

Hide

Permalink

Jack Van Ooststroom added a comment - 01/Apr/16 7:12 AM

Reopening this one as the ICEfaces-EE build was broken due to the commits for this issue:

compile:
    [javac] Compiling 10 source files to <http://dev.icesoft.com/jenkins/job/ICEfaces%20EE%204%20Trunk%20(Nightly)/ws/icefaces-ee/bundle/ICEfaces-EE-4.1.0.SNAPSHOT-bin/samples/eps/poll/build/classes>
    [javac] <http://dev.icesoft.com/jenkins/job/ICEfaces%20EE%204%20Trunk%20(Nightly)/ws/icefaces-ee/bundle/ICEfaces-EE-4.1.0.SNAPSHOT-bin/samples/eps/poll/src/main/java/com/icesoft/faces/demo/poll/Poll.java>:178: cannot find symbol
    [javac] symbol  : constructor PushMessage(java.lang.String,java.lang.String)
    [javac] location: class org.icefaces.application.PushMessage
    [javac]                                 new PushMessage("Poll", "Results changed to against: " + getStatement()));
    [javac]                                 ^
    [javac] <http://dev.icesoft.com/jenkins/job/ICEfaces%20EE%204%20Trunk%20(Nightly)/ws/icefaces-ee/bundle/ICEfaces-EE-4.1.0.SNAPSHOT-bin/samples/eps/poll/src/main/java/com/icesoft/faces/demo/poll/Poll.java>:182: cannot find symbol
    [javac] symbol  : constructor PushMessage(java.lang.String,java.lang.String)
    [javac] location: class org.icefaces.application.PushMessage
    [javac]                                 new PushMessage("Poll", "Results changed to for: " + getStatement()));
    [javac]                                 ^
    [javac] <http://dev.icesoft.com/jenkins/job/ICEfaces%20EE%204%20Trunk%20(Nightly)/ws/icefaces-ee/bundle/ICEfaces-EE-4.1.0.SNAPSHOT-bin/samples/eps/poll/src/main/java/com/icesoft/faces/demo/poll/Poll.java>:186: cannot find symbol
    [javac] symbol  : constructor PushMessage(java.lang.String,java.lang.String)
    [javac] location: class org.icefaces.application.PushMessage
    [javac]                                 new PushMessage("Poll", "Results changed to a tie: " + getStatement()));
    [javac]                                 ^
    [javac] <http://dev.icesoft.com/jenkins/job/ICEfaces%20EE%204%20Trunk%20(Nightly)/ws/icefaces-ee/bundle/ICEfaces-EE-4.1.0.SNAPSHOT-bin/samples/eps/poll/src/main/java/com/icesoft/faces/demo/poll/Poll.java>:229: cannot find symbol
    [javac] symbol  : constructor PushMessage(java.lang.String,java.lang.String)
    [javac] location: class org.icefaces.application.PushMessage
    [javac]                                 new PushMessage("Poll", "Results changed to against: " + getStatement()));
    [javac]                                 ^
    [javac] <http://dev.icesoft.com/jenkins/job/ICEfaces%20EE%204%20Trunk%20(Nightly)/ws/icefaces-ee/bundle/ICEfaces-EE-4.1.0.SNAPSHOT-bin/samples/eps/poll/src/main/java/com/icesoft/faces/demo/poll/Poll.java>:233: cannot find symbol
    [javac] symbol  : constructor PushMessage(java.lang.String,java.lang.String)
    [javac] location: class org.icefaces.application.PushMessage
    [javac]                                 new PushMessage("Poll", "Results changed to for: " + getStatement()));
    [javac]                                 ^
    [javac] <http://dev.icesoft.com/jenkins/job/ICEfaces%20EE%204%20Trunk%20(Nightly)/ws/icefaces-ee/bundle/ICEfaces-EE-4.1.0.SNAPSHOT-bin/samples/eps/poll/src/main/java/com/icesoft/faces/demo/poll/Poll.java>:237: cannot find symbol
    [javac] symbol  : constructor PushMessage(java.lang.String,java.lang.String)
    [javac] location: class org.icefaces.application.PushMessage
    [javac]                                 new PushMessage("Poll", "Results changed to a tie: " + getStatement()));
    [javac]                                 ^
    [javac] <http://dev.icesoft.com/jenkins/job/ICEfaces%20EE%204%20Trunk%20(Nightly)/ws/icefaces-ee/bundle/ICEfaces-EE-4.1.0.SNAPSHOT-bin/samples/eps/poll/src/main/java/com/icesoft/faces/demo/poll/PollCollection.java>:211: cannot find symbol
    [javac] symbol  : constructor PushMessage(java.lang.String,java.lang.String)
    [javac] location: class org.icefaces.application.PushMessage
    [javac]                 Poll.POLL_GROUP_NAME, new PushMessage("Poll", "New poll added: " + poll.getStatement()));
    [javac]                                       ^
    [javac] Note: <http://dev.icesoft.com/jenkins/job/ICEfaces%20EE%204%20Trunk%20(Nightly)/ws/icefaces-ee/bundle/ICEfaces-EE-4.1.0.SNAPSHOT-bin/samples/eps/poll/src/main/java/com/icesoft/faces/demo/poll/PollCollection.java> uses unchecked or unsafe operations.
    [javac] Note: Recompile with -Xlint:unchecked for details.
    [javac] 7 errors

Show

Jack Van Ooststroom added a comment - 01/Apr/16 7:12 AM Reopening this one as the ICEfaces-EE build was broken due to the commits for this issue: compile: [javac] Compiling 10 source files to <http: //dev.icesoft.com/jenkins/job/ICEfaces%20EE%204%20Trunk%20(Nightly)/ws/icefaces-ee/bundle/ICEfaces-EE-4.1.0.SNAPSHOT-bin/samples/eps/poll/build/classes> [javac] <http: //dev.icesoft.com/jenkins/job/ICEfaces%20EE%204%20Trunk%20(Nightly)/ws/icefaces-ee/bundle/ICEfaces-EE-4.1.0.SNAPSHOT-bin/samples/eps/poll/src/main/java/com/icesoft/faces/demo/poll/Poll.java>:178: cannot find symbol [javac] symbol : constructor PushMessage(java.lang. String ,java.lang. String ) [javac] location: class org.icefaces.application.PushMessage [javac] new PushMessage( "Poll" , "Results changed to against: " + getStatement())); [javac] ^ [javac] <http: //dev.icesoft.com/jenkins/job/ICEfaces%20EE%204%20Trunk%20(Nightly)/ws/icefaces-ee/bundle/ICEfaces-EE-4.1.0.SNAPSHOT-bin/samples/eps/poll/src/main/java/com/icesoft/faces/demo/poll/Poll.java>:182: cannot find symbol [javac] symbol : constructor PushMessage(java.lang. String ,java.lang. String ) [javac] location: class org.icefaces.application.PushMessage [javac] new PushMessage( "Poll" , "Results changed to for : " + getStatement())); [javac] ^ [javac] <http: //dev.icesoft.com/jenkins/job/ICEfaces%20EE%204%20Trunk%20(Nightly)/ws/icefaces-ee/bundle/ICEfaces-EE-4.1.0.SNAPSHOT-bin/samples/eps/poll/src/main/java/com/icesoft/faces/demo/poll/Poll.java>:186: cannot find symbol [javac] symbol : constructor PushMessage(java.lang. String ,java.lang. String ) [javac] location: class org.icefaces.application.PushMessage [javac] new PushMessage( "Poll" , "Results changed to a tie: " + getStatement())); [javac] ^ [javac] <http: //dev.icesoft.com/jenkins/job/ICEfaces%20EE%204%20Trunk%20(Nightly)/ws/icefaces-ee/bundle/ICEfaces-EE-4.1.0.SNAPSHOT-bin/samples/eps/poll/src/main/java/com/icesoft/faces/demo/poll/Poll.java>:229: cannot find symbol [javac] symbol : constructor PushMessage(java.lang. String ,java.lang. String ) [javac] location: class org.icefaces.application.PushMessage [javac] new PushMessage( "Poll" , "Results changed to against: " + getStatement())); [javac] ^ [javac] <http: //dev.icesoft.com/jenkins/job/ICEfaces%20EE%204%20Trunk%20(Nightly)/ws/icefaces-ee/bundle/ICEfaces-EE-4.1.0.SNAPSHOT-bin/samples/eps/poll/src/main/java/com/icesoft/faces/demo/poll/Poll.java>:233: cannot find symbol [javac] symbol : constructor PushMessage(java.lang. String ,java.lang. String ) [javac] location: class org.icefaces.application.PushMessage [javac] new PushMessage( "Poll" , "Results changed to for : " + getStatement())); [javac] ^ [javac] <http: //dev.icesoft.com/jenkins/job/ICEfaces%20EE%204%20Trunk%20(Nightly)/ws/icefaces-ee/bundle/ICEfaces-EE-4.1.0.SNAPSHOT-bin/samples/eps/poll/src/main/java/com/icesoft/faces/demo/poll/Poll.java>:237: cannot find symbol [javac] symbol : constructor PushMessage(java.lang. String ,java.lang. String ) [javac] location: class org.icefaces.application.PushMessage [javac] new PushMessage( "Poll" , "Results changed to a tie: " + getStatement())); [javac] ^ [javac] <http: //dev.icesoft.com/jenkins/job/ICEfaces%20EE%204%20Trunk%20(Nightly)/ws/icefaces-ee/bundle/ICEfaces-EE-4.1.0.SNAPSHOT-bin/samples/eps/poll/src/main/java/com/icesoft/faces/demo/poll/PollCollection.java>:211: cannot find symbol [javac] symbol : constructor PushMessage(java.lang. String ,java.lang. String ) [javac] location: class org.icefaces.application.PushMessage [javac] Poll.POLL_GROUP_NAME, new PushMessage( "Poll" , "New poll added: " + poll.getStatement())); [javac] ^ [javac] Note: <http: //dev.icesoft.com/jenkins/job/ICEfaces%20EE%204%20Trunk%20(Nightly)/ws/icefaces-ee/bundle/ICEfaces-EE-4.1.0.SNAPSHOT-bin/samples/eps/poll/src/main/java/com/icesoft/faces/demo/poll/PollCollection.java> uses unchecked or unsafe operations. [javac] Note: Recompile with -Xlint:unchecked for details. [javac] 7 errors

Jack Van Ooststroom made changes - 01/Apr/16 7:12 AM

Resolution	Fixed [ 1 ]
Status	Resolved [ 5 ]	Reopened [ 4 ]

Hide

Permalink

Jack Van Ooststroom added a comment - 01/Apr/16 7:12 AM

Sending samples/eps/poll/src/main/java/com/icesoft/faces/demo/poll/Poll.java
Sending samples/eps/poll/src/main/java/com/icesoft/faces/demo/poll/PollCollection.java
Transmitting file data ..
Committed revision 44845.

Show

Jack Van Ooststroom added a comment - 01/Apr/16 7:12 AM Sending samples/eps/poll/src/main/java/com/icesoft/faces/demo/poll/Poll.java Sending samples/eps/poll/src/main/java/com/icesoft/faces/demo/poll/PollCollection.java Transmitting file data .. Committed revision 44845.

Hide

Permalink

Jack Van Ooststroom added a comment - 01/Apr/16 7:14 AM

Applied a temporary 'fix' to the Poll sample app. For now it specifies the targetURI to be null. Other JIRAs should be created to address the Poll and Showcase usages of the PushMessage in order for the Cloud Push support to function again.

Marking this one as FIXED again.

Show

Jack Van Ooststroom added a comment - 01/Apr/16 7:14 AM Applied a temporary 'fix' to the Poll sample app. For now it specifies the targetURI to be null . Other JIRAs should be created to address the Poll and Showcase usages of the PushMessage in order for the Cloud Push support to function again. Marking this one as FIXED again.

Jack Van Ooststroom made changes - 01/Apr/16 7:14 AM

Status	Reopened [ 4 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Hide

Permalink

Liana Munroe added a comment - 06/Apr/16 4:20 PM - edited

Tested QA cloudPush application using Jenkins ICEfaces EE 4 trunk Nightly build 433. Tested locally and on Labs1 server instance. I left the application running on Labs1 for Jack to view.
In the QA application I added the URI as per the new API. Now native notifications are no longer received and a server warning is seen when using priority push. This warning appeared with or without the modifications to web.xml.

Apr 06, 2016 7:56:43 PM org.icepush.ConfirmationTimeout execute
WARNING: Exception caught on confirmationTimeout TimerTask.
java.lang.UnsupportedOperationException
        at java.util.Collections$UnmodifiableMap.remove(Collections.java:1460)
        at org.icepush.ConfirmationTimeout.execute(ConfirmationTimeout.java:204)
        at org.icepush.ConfirmationTimeout.execute(ConfirmationTimeout.java:102)
        at org.icepush.ConfirmationTimeout$1.run(ConfirmationTimeout.java:56)
        at java.util.TimerThread.mainLoop(Timer.java:555)
        at java.util.TimerThread.run(Timer.java:505)

Also there was a server warning upon deployment. I ended up manually adding these Jackson jars to my .war file as they were not added during the build. I eventually commented out the email references in the web.xml file on the Labs 1 server.

Task.run E-mail Notification Provider is disabled by configuration.
Exception in thread "APNS Notification Provider set-up thread" java.lang.NoClass
DefFoundError: com/fasterxml/jackson/core/JsonGenerator
        at com.icesoft.notify.cloud.core.APNSNotificationProvider$AutoRegistrati
on$RegistrationTask.run(APNSNotificationProvider.java:445)
        at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.ClassNotFoundException: com.fasterxml.jackson.core.JsonGene
rator
        at org.apache.catalina.loader.WebappClassLoaderBase.loadClass(WebappClas
sLoaderBase.java:1295)
        at org.apache.catalina.loader.WebappClassLoaderBase.loadClass(WebappClas
sLoaderBase.java:1147)
        ... 2 more

The QA test app can be found at http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Manual/cloudPush.
Use the CloudPush Persistence page

Show

Liana Munroe added a comment - 06/Apr/16 4:20 PM - edited Tested QA cloudPush application using Jenkins ICEfaces EE 4 trunk Nightly build 433. Tested locally and on Labs1 server instance. I left the application running on Labs1 for Jack to view. In the QA application I added the URI as per the new API. Now native notifications are no longer received and a server warning is seen when using priority push. This warning appeared with or without the modifications to web.xml. Apr 06, 2016 7:56:43 PM org.icepush.ConfirmationTimeout execute WARNING: Exception caught on confirmationTimeout TimerTask. java.lang.UnsupportedOperationException at java.util.Collections$UnmodifiableMap.remove(Collections.java:1460) at org.icepush.ConfirmationTimeout.execute(ConfirmationTimeout.java:204) at org.icepush.ConfirmationTimeout.execute(ConfirmationTimeout.java:102) at org.icepush.ConfirmationTimeout$1.run(ConfirmationTimeout.java:56) at java.util.TimerThread.mainLoop(Timer.java:555) at java.util.TimerThread.run(Timer.java:505) Also there was a server warning upon deployment. I ended up manually adding these Jackson jars to my .war file as they were not added during the build. I eventually commented out the email references in the web.xml file on the Labs 1 server. Task.run E-mail Notification Provider is disabled by configuration. Exception in thread "APNS Notification Provider set-up thread" java.lang.NoClass DefFoundError: com/fasterxml/jackson/core/JsonGenerator at com.icesoft.notify.cloud.core.APNSNotificationProvider$AutoRegistrati on$RegistrationTask.run(APNSNotificationProvider.java:445) at java.lang. Thread .run( Thread .java:745) Caused by: java.lang.ClassNotFoundException: com.fasterxml.jackson.core.JsonGene rator at org.apache.catalina.loader.WebappClassLoaderBase.loadClass(WebappClas sLoaderBase.java:1295) at org.apache.catalina.loader.WebappClassLoaderBase.loadClass(WebappClas sLoaderBase.java:1147) ... 2 more The QA test app can be found at http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Manual/cloudPush . Use the CloudPush Persistence page

Hide

Permalink

Jack Van Ooststroom added a comment - 06/Apr/16 4:34 PM

Sending icepush/core/src/main/java/org/icepush/ConfirmationTimeout.java
Transmitting file data .
Committed revision 48616.

Show

Jack Van Ooststroom added a comment - 06/Apr/16 4:34 PM Sending icepush/core/src/main/java/org/icepush/ConfirmationTimeout.java Transmitting file data . Committed revision 48616.

Liana Munroe made changes - 06/Apr/16 4:34 PM

Resolution	Fixed [ 1 ]
Status	Resolved [ 5 ]	Reopened [ 4 ]

Hide

Permalink

Jack Van Ooststroom added a comment - 06/Apr/16 4:37 PM

The UnsupportedOperationException should be fixed as instead of changing references of the propertyMap the class member propertyMap is now cleared and the parameter propertyMap is then added in its entirety to the class member propertyMap. As the class member propertyMap is under its own control and used by the execute(...) method the UnsupportedOperationException should no longer be thrown.

Show

Jack Van Ooststroom added a comment - 06/Apr/16 4:37 PM The UnsupportedOperationException should be fixed as instead of changing references of the propertyMap the class member propertyMap is now cleared and the parameter propertyMap is then added in its entirety to the class member propertyMap . As the class member propertyMap is under its own control and used by the execute(...) method the UnsupportedOperationException should no longer be thrown.

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#48616	Wed Apr 06 16:40:07 MDT 2016	jack.van.ooststroom	Fixed JIRA ~~PUSH-388~~ : Include the uri of a cloud push notification in the public API; Fixed UnsupportedOperationException.
				Files Changed
				MODIFY /icepush/trunk/icepush/core/src/main/java/org/icepush/ConfirmationTimeout.java

Ken Fyten made changes - 07/Apr/16 10:36 AM

Assignee Priority

P1 [ 10010 ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#48620	Mon Apr 11 17:08:29 MDT 2016	jack.van.ooststroom	Fixed JIRA ~~PUSH-388~~ : Include the uri of a cloud push notification in the public API; Possible temporary typo fix.
				Files Changed
				MODIFY /icepush/trunk/icepush/core/src/main/java/org/icepush/ConfirmationTimeout.java

Carmen Cristurean made changes - 13/Apr/16 3:06 PM

Link

This issue blocks ~~ICE-11004~~ [ ~~ICE-11004~~ ]

Hide

Permalink

Jack Van Ooststroom added a comment - 29/Apr/16 7:33 AM

The targetURI is now part of the various public APIs, namely at the Java-side for ICEfaces (using the PushMessage class) and ICEpush (using the PushNotification class), and at the JavaScript-side for ICEpush (using the notify function). At the server-side the new targetURI eventually translates to the url property for the ICEnotify, ICEnotify-EE and/or Cloud Notification Service. Marking this one as FIXED.

Show

Jack Van Ooststroom added a comment - 29/Apr/16 7:33 AM The targetURI is now part of the various public APIs, namely at the Java-side for ICEfaces (using the PushMessage class) and ICEpush (using the PushNotification class), and at the JavaScript-side for ICEpush (using the notify function). At the server-side the new targetURI eventually translates to the url property for the ICEnotify, ICEnotify-EE and/or Cloud Notification Service. Marking this one as FIXED.

Jack Van Ooststroom made changes - 29/Apr/16 7:33 AM

Status	Reopened [ 4 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Hide

Permalink

Carmen Cristurean added a comment - 29/Apr/16 8:55 AM

EE4 trunk r45002, verified cloudPush priority notifications on Labs1 on iPad/IOS9:

the UnspportedOperationException can no longer be reproduced. - VERIFIED/CONFIRMED.
the notifications work partially only on iPad/iOS9. - NOTIFICATIONS WORK CONSISTENTLY; ONE EXCEPTION WOULD BE IF SENDING NOTIFICATIONS "IN A QUEUE" FROM DIFFERENT PAGES, WHEN ONLY THE FIRST NOTIFICATION IS RECEIVED.
the notifications appear to work on iPad/iOS9 only if there is no other device that previously registered for cloudPush using the same application. If another device registered first for cloudPush from the same app, in order for the notifications to start working again on iPad, the browser on iPad should be cleared, and must register again for cloudPush from the iPad. - THIS WORKS CORRECTLY NOW.
the received notifications contain the name of the color-coded page, and the subject line. - VERIFIED/PASS.
clicking on the notification opens up the browser window displaying two tabs: the default opened tab is the second tab with the main registration page, and the first tab has the color-coded page that generated the notification. - this is expected and correct behavior – CLICKING ON THE NATIVE NOTIFICATION OPENS UP NOW ONLY THE CORRESPONDING COLOR-CODED PAGE.

Show

Carmen Cristurean added a comment - 29/Apr/16 8:55 AM EE4 trunk r45002, verified cloudPush priority notifications on Labs1 on iPad/IOS9: the UnspportedOperationException can no longer be reproduced. - VERIFIED/CONFIRMED. the notifications work partially only on iPad/iOS9. - NOTIFICATIONS WORK CONSISTENTLY; ONE EXCEPTION WOULD BE IF SENDING NOTIFICATIONS "IN A QUEUE" FROM DIFFERENT PAGES, WHEN ONLY THE FIRST NOTIFICATION IS RECEIVED. the notifications appear to work on iPad/iOS9 only if there is no other device that previously registered for cloudPush using the same application. If another device registered first for cloudPush from the same app, in order for the notifications to start working again on iPad, the browser on iPad should be cleared, and must register again for cloudPush from the iPad. - THIS WORKS CORRECTLY NOW. the received notifications contain the name of the color-coded page, and the subject line. - VERIFIED/PASS. clicking on the notification opens up the browser window displaying two tabs: the default opened tab is the second tab with the main registration page, and the first tab has the color-coded page that generated the notification. - this is expected and correct behavior – CLICKING ON THE NATIVE NOTIFICATION OPENS UP NOW ONLY THE CORRESPONDING COLOR-CODED PAGE.

Ken Fyten made changes - 29/Apr/16 10:27 AM

Fix Version/s

EE-4.1.0.BETA [ 13073 ]

Ken Fyten made changes - 11/May/16 11:35 AM

Fix Version/s		EE-4.1.1.BETA [ 13077 ]
Fix Version/s	EE-4.1.0.GA [ 12172 ]
Fix Version/s	EE-4.1.0.RC1 [ 13073 ]

Ken Fyten made changes - 13/Dec/16 11:36 AM

Fix Version/s		EE-4.2.0.GA [ 13074 ]
Fix Version/s	EE-4.1.1.BETA [ 13077 ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#50753	Mon Feb 27 13:43:44 MST 2017	jack.van.ooststroom	Reverted ~~PUSH-388~~ fixes to ICEfaces-layer
				Files Changed
				MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/mobi/cloudpush/CloudPushBean.java

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#50754	Mon Feb 27 14:08:51 MST 2017	jack.van.ooststroom	Reverted ~~PUSH-388~~ fixes to ICEfaces-layer
				Files Changed
				MODIFY /icefaces4/trunk/icefaces/core/src/main/java/org/icefaces/application/PushMessage.java MODIFY /icefaces4/trunk/icefaces/core/src/main/java/org/icefaces/application/PushRenderer.java MODIFY /icefaces4/trunk/icefaces/core/src/main/java/org/icefaces/application/PushOptions.java MODIFY /icefaces4/trunk/icefaces/core/src/main/java/org/icefaces/application/PushOthers.java

People

Assignee:

Jack Van Ooststroom

Reporter:

Jack Van Ooststroom

Votes:

0 Vote for this issue

Watchers:

4 Start watching this issue

Dates

Created:

29/Mar/16 6:21 AM

Updated:

13/Dec/16 11:36 AM

Resolved:

29/Apr/16 7:33 AM