ICEpush
  1. ICEpush
  2. PUSH-366

Lower Some NaaS code.icepush Logging levels

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.1, EE-3.3.0.GA_P04
    • Component/s: Push Library
    • Labels:
      None
    • Environment:
      n/a

      Description

      The push blocking connection logging is overly verbose. Because the send and receive confirmation logging statements are being logged at info level, it's hard to filter these out from more important logging. We should lower this logging statements to debug level.

      eg. in http://dev.bridgeit.io/push/code.icepush:

      info(logger, 'send confirmation: ' + ids);

      and

      info(logger, 'received confirmation: ' + confirmedIDs);

        Activity

        Philip Breau created issue -
        Philip Breau made changes -
        Field Original Value New Value
        Summary Lower Some NaaS Logging levels Lower Some NaaS code.icepush Logging levels
        Philip Breau made changes -
        Description The push blocking connection logging is overly verbose. Because the send and receive confirmation logging statements are being logged at info level, it's hard to filter these out from more important logging. We should lower this logging statements to debug level.

        info(logger, 'send confirmation: ' + ids);

        and

        info(logger, 'received confirmation: ' + confirmedIDs);
        The push blocking connection logging is overly verbose. Because the send and receive confirmation logging statements are being logged at info level, it's hard to filter these out from more important logging. We should lower this logging statements to debug level.

        eg. in http://dev.bridgeit.io/push/code.icepush:

        info(logger, 'send confirmation: ' + ids);

        and

        info(logger, 'received confirmation: ' + confirmedIDs);
        Hide
        Jack Van Ooststroom added a comment -

        Sending core/src/main/javascript/pushid.expiry.js
        Transmitting file data .
        Committed revision 45004.

        Show
        Jack Van Ooststroom added a comment - Sending core/src/main/javascript/pushid.expiry.js Transmitting file data . Committed revision 45004.
        Hide
        Jack Van Ooststroom added a comment -

        I lowered the logging level from info to debug for these two logging statements. Marking this one as FIXED.

        Show
        Jack Van Ooststroom added a comment - I lowered the logging level from info to debug for these two logging statements. Marking this one as FIXED.
        Jack Van Ooststroom made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Jack Van Ooststroom added a comment -

        This one should probably be moved to ICEpush instead of ICEnotify.

        Show
        Jack Van Ooststroom added a comment - This one should probably be moved to ICEpush instead of ICEnotify.
        Jack Van Ooststroom made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Ken Fyten made changes -
        Project ICEnotify [ 10070 ] ICEpush [ 10050 ]
        Key NTFY-267 PUSH-366
        Component/s Notification [ 10072 ]
        Ken Fyten made changes -
        Component/s Push Library [ 10044 ]
        Ken Fyten made changes -
        Fix Version/s 4.1 [ 11570 ]
        Fix Version/s EE-3.3.0.GA_P04 [ 12271 ]
        Ken Fyten made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Jack Van Ooststroom
            Reporter:
            Philip Breau
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: