ICEpush
  1. ICEpush
  2. PUSH-346

[Regression] ice.push.browser isn't always send in requests even when it should be known

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: EE-4.0.0.GA
    • Fix Version/s: EE-4.0.0.GA
    • Labels:
      None
    • Environment:
      Tomcat, ICEfaces(-EE), Showcase
    • Assignee Priority:
      P1

      Description

      Using Showcase and a single browser window I see the Set-Cookie for ice.push.browser pass by more than 10 times. This causes a request to eventually have an ice.pushid with a mismatched ice.push.browser. This doesn't seem to harm normal Push, but it does seem to harm Cloud Push.

        Activity

        Jack Van Ooststroom created issue -
        Jack Van Ooststroom made changes -
        Field Original Value New Value
        Fix Version/s EE-4.0.0.GA [ 11170 ]
        Ken Fyten made changes -
        Assignee Jack Van Ooststroom [ jack.van.ooststroom ]
        Jack Van Ooststroom made changes -
        Priority Major [ 3 ] Blocker [ 1 ]
        Jack Van Ooststroom made changes -
        Affects Version/s EE-4.0.0.GA [ 11170 ]
        Jack Van Ooststroom made changes -
        Summary ice.push.browser isn't always send in requests even when it should be known [Regression] ice.push.browser isn't always send in requests even when it should be known
        Jack Van Ooststroom made changes -
        Assignee Jack Van Ooststroom [ jack.van.ooststroom ] Mircea Toma [ mircea.toma ]
        Ken Fyten made changes -
        Assignee Priority P1 [ 10010 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #43989 Mon Feb 02 13:13:49 MST 2015 mircea.toma PUSH-346 Removed code that sets ice.push.browser cookie since ICEpush relies only on parameters and XML responses for carrying the browser ID.
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/core/src/main/java/org/icefaces/impl/push/servlet/ICEpushResourceHandler.java
        Hide
        Mircea Toma added a comment - - edited

        Removed code in ICEPushResourceHandler that sets ice.push.browser cookie since ICEpush relies only on parameters and XML responses for carrying the browser ID. This seems to be code that was overlooked after the refactoring done for PUSH-317.

        Show
        Mircea Toma added a comment - - edited Removed code in ICEPushResourceHandler that sets ice.push.browser cookie since ICEpush relies only on parameters and XML responses for carrying the browser ID. This seems to be code that was overlooked after the refactoring done for PUSH-317 .
        Mircea Toma made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Mircea Toma
            Reporter:
            Jack Van Ooststroom
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: