ICEpush
  1. ICEpush
  2. PUSH-318

NPE in LocalPushGroupManager's OutOfBandNotification

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: EE-3.3.0.GA_P01
          • Fix Version/s: EE-3.3.0.GA_P02
          • Component/s: Push Library
          • Labels:
            None
          • Environment:
            Tomcat 7.0.54, ActiveMQ 5.1.0, Cluster, EPS, Poll

            Description

            The following NPE can be thrown in the described environment:

            java.lang.NullPointerException
                    at org.icepush.LocalPushGroupManager$OutOfBandNotification.run(LocalPushGroupManager.java:415)
                    at org.icepush.LocalPushGroupManager$QueueConsumerTask.run(LocalPushGroupManager.java:429)
                    at java.util.TimerThread.mainLoop(Timer.java:512)
                    at java.util.TimerThread.run(Timer.java:462)

            But I don't think it's environment-dependent. Looking at the code this can happen in a stand-alone environment as well, potentially without EPS.

              Activity

              Ascending order - Click to sort in descending order
              Jack Van Ooststroom created issue -
              Jack Van Ooststroom made changes -
              Field Original Value New Value
              Assignee Jack Van Ooststroom [ jack.van.ooststroom ]
              Jack Van Ooststroom made changes -
              Fix Version/s EE-3.3.0.GA_P02 [ 11370 ]
              Hide
              Permalink
              Jack Van Ooststroom added a comment -

              Sending core/src/main/java/org/icepush/LocalPushGroupManager.java
              Transmitting file data .
              Committed revision 41242.

              Show
              Jack Van Ooststroom added a comment - Sending core/src/main/java/org/icepush/LocalPushGroupManager.java Transmitting file data . Committed revision 41242.
              Hide
              Permalink
              Jack Van Ooststroom added a comment -

              Looking at the code for ICEfaces(-EE) 4 it has a null-check in place guarding the same logic it fails for ICEfaces(-EE) 3. I added a similar null-check. Marking this one as FIXED.

              Show
              Jack Van Ooststroom added a comment - Looking at the code for ICEfaces(-EE) 4 it has a null-check in place guarding the same logic it fails for ICEfaces(-EE) 3. I added a similar null-check. Marking this one as FIXED.
              Jack Van Ooststroom made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Jack Van Ooststroom
                  Reporter:
                  Jack Van Ooststroom
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: