ICEpush
  1. ICEpush
  2. PUSH-310

"BrowserBoundServlet" local classes: "AddGroupMember", "RemoveGroupMember" throw NPE on certain url's

          Details

          • Type: Bug Bug
          • Status: Open
          • Priority: Major Major
          • Resolution: Unresolved
          • Affects Version/s: 3.3
          • Fix Version/s: None
          • Component/s: Push Library
          • Labels:
            None
          • Environment:
            Windows 7 pro, Chrome 33
          • Workaround Exists:
            Yes
          • Workaround Description:
            Hide
            in BrowserBoundServlet, wrap PushContext methods addGroupMember() and removeGroupMember() in NULL checking if.

            String group = request.getParameter("group");
            String pushID = request.getParameter("id");
            if (group!=null && pushID!=null) {
                 pushContext.removeGroupMember(group, pushID);
            }

            String group = request.getParameter("group");
            String pushID = request.getParameter("id");
            if (group!=null && pushID!=null) {
                        pushContext.addGroupMember(group, pushID);
            }

            Show
            in BrowserBoundServlet, wrap PushContext methods addGroupMember() and removeGroupMember() in NULL checking if. String group = request.getParameter("group"); String pushID = request.getParameter("id"); if (group!=null && pushID!=null) {      pushContext.removeGroupMember(group, pushID); } String group = request.getParameter("group"); String pushID = request.getParameter("id"); if (group!=null && pushID!=null) {             pushContext.addGroupMember(group, pushID); }

            Description

            "BrowserBoundServlet" local classes: "AddGroupMember", "RemoveGroupMember" uses user-supplied parameters with ConcurrentHashMap get() method without check for NULL.

            ConcurrentHashMap get() method throws NPE if supplied arguments is NULL.

              Activity

              Ascending order - Click to sort in descending order
              Kairat Rakhimov created issue -

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  Kairat Rakhimov
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated: