ICEpush
  1. ICEpush
  2. PUSH-303

Cloud Push listener configuration

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-3.3.0.GA_P01
    • Fix Version/s: 4.0
    • Labels:
      None
    • Environment:
      ICEpush, Cloud Push

      Description

      ICEpush may be used in an environment that supports Cloud Push even the application does not make use of the feature. If the application will not issue a Cloud Push notification to a given pushID, there is no need to consume server resources by parking that pushID.

        Activity

        Ted Goddard created issue -
        Hide
        Ted Goddard added a comment -

        Suggestion from Jack that the set of allowed redirect URLs be configurable.

        Show
        Ted Goddard added a comment - Suggestion from Jack that the set of allowed redirect URLs be configurable.
        Hide
        Ted Goddard added a comment -

        Similar to PUSH-297, this configuration could be based on

        public void addGroupMember(final String groupName, final String pushId, PushConfiguration config)

        where the PushConfiguration contains cloudPush = "true".

        The corresponding JavaScript API would be

        ice.push.addGroupMember(group, pushId, options);

        where options contains cloudPush = "true".

        If cloudPush is not enabled for a given pushId at the time it is added to a group, that pushID will not be parked when the push connection goes offline.

        Show
        Ted Goddard added a comment - Similar to PUSH-297, this configuration could be based on public void addGroupMember(final String groupName, final String pushId, PushConfiguration config) where the PushConfiguration contains cloudPush = "true". The corresponding JavaScript API would be ice.push.addGroupMember(group, pushId, options); where options contains cloudPush = "true". If cloudPush is not enabled for a given pushId at the time it is added to a group, that pushID will not be parked when the push connection goes offline.
        Ted Goddard made changes -
        Field Original Value New Value
        Assignee Jack Van Ooststroom [ jack.van.ooststroom ]
        Hide
        Ted Goddard added a comment -

        Note that Cloud Push will now be disabled by default, so the parameter is only needed to enable Cloud Push.

        Show
        Ted Goddard added a comment - Note that Cloud Push will now be disabled by default, so the parameter is only needed to enable Cloud Push.
        Jack Van Ooststroom made changes -
        Fix Version/s 4.0 [ 11383 ]
        Fix Version/s 4.0.BETA [ 10971 ]
        Hide
        Jack Van Ooststroom added a comment -

        Looks like this is doable for 4.0. However, my suggestion of "that the set of allowed redirect URLs be configurable" might need to be addressed in a separate JIRA. I'm not sure if my suggestion was related to this JIRA. It was related to avoid being directed to any (malicious) page through Cloud Push.

        Show
        Jack Van Ooststroom added a comment - Looks like this is doable for 4.0. However, my suggestion of "that the set of allowed redirect URLs be configurable" might need to be addressed in a separate JIRA. I'm not sure if my suggestion was related to this JIRA. It was related to avoid being directed to any (malicious) page through Cloud Push.
        Jack Van Ooststroom made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #42135 Thu Aug 21 09:22:33 MDT 2014 jack.van.ooststroom Fixed JIRA PUSH-303 : Cloud Push listener configuration
        Files Changed
        Commit graph MODIFY /icepush/trunk/icepush/core/src/main/java/org/icepush/Browser.java
        Commit graph MODIFY /icepush/trunk/icepush/core/src/main/java/org/icepush/PushGroupManager.java
        Commit graph MODIFY /icepush/trunk/icepush/core/src/main/java/org/icepush/PushID.java
        Commit graph MODIFY /icepush/trunk/icepush/core/src/main/java/org/icepush/LocalPushGroupManager.java
        Commit graph MODIFY /icepush/trunk/icepush/core/src/main/java/org/icepush/NoopPushGroupManager.java
        Commit graph MODIFY /icepush/trunk/icepush/core/src/main/java/org/icepush/PushContext.java
        Commit graph MODIFY /icepush/trunk/icepush/core/src/main/java/org/icepush/servlet/BrowserBoundServlet.java
        Hide
        Jack Van Ooststroom added a comment -

        Sending core/src/main/java/org/icepush/Browser.java
        Sending core/src/main/java/org/icepush/LocalPushGroupManager.java
        Sending core/src/main/java/org/icepush/NoopPushGroupManager.java
        Sending core/src/main/java/org/icepush/PushContext.java
        Sending core/src/main/java/org/icepush/PushGroupManager.java
        Sending core/src/main/java/org/icepush/PushID.java
        Sending core/src/main/java/org/icepush/servlet/BrowserBoundServlet.java
        Transmitting file data .......
        Committed revision 42135.

        Sending eps/src/main/java/com/icesoft/push/DynamicPushGroupManager.java
        Sending eps/src/main/java/com/icesoft/push/LocalPushGroupManager.java
        Sending eps/src/main/java/com/icesoft/push/RemotePushGroupManager.java
        Adding eps/src/main/java/com/icesoft/push/SerializablePushConfiguration.java
        Sending eps/src/main/java/com/icesoft/push/SerializablePushNotification.java
        Sending eps/src/main/java/com/icesoft/push/messaging/PushMessageService.java
        Transmitting file data ......
        Committed revision 39198.

        Sending src/main/java/com/icesoft/notify/client/NotificationClient.java
        Sending src/main/java/com/icesoft/notify/common/data/NotificationAsAService.java
        Sending src/main/java/com/icesoft/notify/common/data/NotificationMarshallerJSON.java
        Sending src/main/java/com/icesoft/notify/common/data/NotificationUnmarshallerJSON.java
        Sending src/main/java/com/icesoft/notify/common/data/PushConfiguration.java
        Sending src/main/java/com/icesoft/notify/push/LocalPushGroupManager.java
        Sending src/main/java/com/icesoft/notify/push/servlet/BrowserBoundServlet.java
        Sending src/main/java/com/icesoft/notify/server/AbstractNotificationResourceRequestHandler.java
        Sending src/main/java/com/icesoft/notify/server/NotificationContext.java
        Sending src/main/java/com/icesoft/notify/server/NotificationService.java
        Sending src/main/resources/com/icesoft/notify/common/data/notification-as-a-service.xsd
        Sending src/main/test/com/icesoft/notify/NotificationClientTest.java
        Transmitting file data ............
        Committed revision 39199.

        Show
        Jack Van Ooststroom added a comment - Sending core/src/main/java/org/icepush/Browser.java Sending core/src/main/java/org/icepush/LocalPushGroupManager.java Sending core/src/main/java/org/icepush/NoopPushGroupManager.java Sending core/src/main/java/org/icepush/PushContext.java Sending core/src/main/java/org/icepush/PushGroupManager.java Sending core/src/main/java/org/icepush/PushID.java Sending core/src/main/java/org/icepush/servlet/BrowserBoundServlet.java Transmitting file data ....... Committed revision 42135. Sending eps/src/main/java/com/icesoft/push/DynamicPushGroupManager.java Sending eps/src/main/java/com/icesoft/push/LocalPushGroupManager.java Sending eps/src/main/java/com/icesoft/push/RemotePushGroupManager.java Adding eps/src/main/java/com/icesoft/push/SerializablePushConfiguration.java Sending eps/src/main/java/com/icesoft/push/SerializablePushNotification.java Sending eps/src/main/java/com/icesoft/push/messaging/PushMessageService.java Transmitting file data ...... Committed revision 39198. Sending src/main/java/com/icesoft/notify/client/NotificationClient.java Sending src/main/java/com/icesoft/notify/common/data/NotificationAsAService.java Sending src/main/java/com/icesoft/notify/common/data/NotificationMarshallerJSON.java Sending src/main/java/com/icesoft/notify/common/data/NotificationUnmarshallerJSON.java Sending src/main/java/com/icesoft/notify/common/data/PushConfiguration.java Sending src/main/java/com/icesoft/notify/push/LocalPushGroupManager.java Sending src/main/java/com/icesoft/notify/push/servlet/BrowserBoundServlet.java Sending src/main/java/com/icesoft/notify/server/AbstractNotificationResourceRequestHandler.java Sending src/main/java/com/icesoft/notify/server/NotificationContext.java Sending src/main/java/com/icesoft/notify/server/NotificationService.java Sending src/main/resources/com/icesoft/notify/common/data/notification-as-a-service.xsd Sending src/main/test/com/icesoft/notify/NotificationClientTest.java Transmitting file data ............ Committed revision 39199.
        Hide
        Jack Van Ooststroom added a comment -

        The new addGroupMember(String, String, PushConfiguration) method, and its related logic, has been added to ICEpush, ICEpush-EE, EPS, NaaS and the NotificationServiceClient. I also added two additional tests to the NaaS test-suite. Support at the JavaScript-level still needs to be added.

        Show
        Jack Van Ooststroom added a comment - The new addGroupMember(String, String, PushConfiguration) method, and its related logic, has been added to ICEpush, ICEpush-EE, EPS, NaaS and the NotificationServiceClient. I also added two additional tests to the NaaS test-suite. Support at the JavaScript-level still needs to be added.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #42148 Mon Aug 25 09:16:25 MDT 2014 jack.van.ooststroom Fixed JIRA PUSH-303 : Cloud Push listener configuration
        Files Changed
        Commit graph MODIFY /icepush/trunk/icepush/core/src/main/javascript/application.js
        Hide
        Jack Van Ooststroom added a comment -

        Sending core/src/main/javascript/application.js
        Transmitting file data .
        Committed revision 42148.

        Show
        Jack Van Ooststroom added a comment - Sending core/src/main/javascript/application.js Transmitting file data . Committed revision 42148.
        Hide
        Jack Van Ooststroom added a comment -

        Added support to the ICEfaces JavaScript Bridge.

        Show
        Jack Van Ooststroom added a comment - Added support to the ICEfaces JavaScript Bridge.
        Hide
        Ted Goddard added a comment -

        It does look like that first comment quoting Jack is not intended for this JIRA.

        Show
        Ted Goddard added a comment - It does look like that first comment quoting Jack is not intended for this JIRA.
        Hide
        Jack Van Ooststroom added a comment -

        Sending src/main/java/com/icesoft/notify/push/PushID.java
        Transmitting file data .
        Committed revision 39300.

        Show
        Jack Van Ooststroom added a comment - Sending src/main/java/com/icesoft/notify/push/PushID.java Transmitting file data . Committed revision 39300.
        Hide
        Jack Van Ooststroom added a comment -

        NaaS now adapts the new method accordingly.

        Show
        Jack Van Ooststroom added a comment - NaaS now adapts the new method accordingly.
        Hide
        Jack Van Ooststroom added a comment -

        Marking this one as FIXED.

        Show
        Jack Van Ooststroom added a comment - Marking this one as FIXED.
        Jack Van Ooststroom made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Jack Van Ooststroom
            Reporter:
            Ted Goddard
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: