Details
-
Type: Improvement
-
Status: Closed
-
Priority: Major
-
Resolution: Fixed
-
Affects Version/s: 3.3, EE-3.3.0.GA_P01
-
Component/s: Push Library, Push Server
-
Labels:None
-
Environment:ICEpush
Description
Currently we have the Request/Response interfaces that we use in wrapping the HttpServletRequest and HttpServletResponse instances. However, if we want to use these interfaces to wrap different request/response implementation objects, the current API doesn't always suit this. In addition, it'd be nicer to split the ServletRequestResponse class into a ServletRequest and ServletResponse class, and still keep the ServletRequestResponse class, but then as a wrapper of a ServletRequest and ServletResponse instance. Introducing PushRequest and PushResponse interfaces (as extensions to Request/Response) can also be utilized to introduce ICEpush-specific getters and setters for ease of development, like getSequenceNumber() and setSequenceNumber(). Then the implementation of these interfaces can decide where to retrieve the sequenceNumber from and where to put it depending on the wrapped Request/Response classes.
Activity
Jack Van Ooststroom
created issue -
Jack Van Ooststroom
made changes -
Field | Original Value | New Value |
---|---|---|
Assignee | Jack Van Ooststroom [ jack.van.ooststroom ] |
Jack Van Ooststroom
made changes -
Fix Version/s | 4.0 [ 10971 ] | |
Fix Version/s | EE-4.0.0.GA [ 11170 ] |
Jack Van Ooststroom
made changes -
Status | Open [ 1 ] | In Progress [ 3 ] |
Jack Van Ooststroom
made changes -
Status | In Progress [ 3 ] | Resolved [ 5 ] |
Resolution | Fixed [ 1 ] |
Ken Fyten
made changes -
Fix Version/s | 4.0 [ 11383 ] | |
Fix Version/s | EE-4.0.0.GA [ 11170 ] |
Ken Fyten
made changes -
Status | Resolved [ 5 ] | Closed [ 6 ] |
Adding core/src/main/java/org/icepush/BackOff.javaDeleting core/src/main/java/org/icepush/BackOffResponseHandler.javaSending core/src/main/java/org/icepush/BlockingConnectionServer.java
Sending core/src/main/java/org/icepush/Browser.java
Sending core/src/main/java/org/icepush/CheckBrowserIDServlet.java
Adding core/src/main/java/org/icepush/ConnectionClose.java
Adding core/src/main/java/org/icepush/Noop.java
Adding core/src/main/java/org/icepush/NotifiedPushIDs.java
Sending core/src/main/java/org/icepush/PushStormDetectionServer.java
Sending core/src/main/java/org/icepush/SequenceTaggingServer.java
Adding core/src/main/java/org/icepush/ServerError.java
Adding core/src/main/java/org/icepush/http/PushRequest.java
Adding core/src/main/java/org/icepush/http/PushResponse.java
Adding core/src/main/java/org/icepush/http/PushResponseHandler.java
Adding core/src/main/java/org/icepush/http/PushServer.java
Sending core/src/main/java/org/icepush/http/standard/CacheControlledServer.java
Sending core/src/main/java/org/icepush/http/standard/CompressingServer.java
Sending core/src/main/java/org/icepush/http/standard/FixedSizeContentHandler.java
Adding core/src/main/java/org/icepush/http/standard/PushRequestProxy.java
Adding core/src/main/java/org/icepush/http/standard/PushResponseHandlerServer.java
Adding core/src/main/java/org/icepush/http/standard/PushResponseProxy.java
Sending core/src/main/java/org/icepush/http/standard/RequestProxy.java
Sending core/src/main/java/org/icepush/http/standard/ResponseProxy.java
Adding core/src/main/java/org/icepush/servlet/AbstractRequest.java
Adding core/src/main/java/org/icepush/servlet/AbstractResponse.java
Sending core/src/main/java/org/icepush/servlet/AsyncAdaptingServlet.java
Sending core/src/main/java/org/icepush/servlet/BrowserBoundServlet.java
Sending core/src/main/java/org/icepush/servlet/ConfigurationServlet.java
Sending core/src/main/java/org/icepush/servlet/EnvironmentAdaptingServlet.java
Adding core/src/main/java/org/icepush/servlet/ServletPushRequest.java
Adding core/src/main/java/org/icepush/servlet/ServletPushRequestResponse.java
Adding core/src/main/java/org/icepush/servlet/ServletPushResponse.java
Adding core/src/main/java/org/icepush/servlet/ServletRequest.java
Sending core/src/main/java/org/icepush/servlet/ServletRequestResponse.java
Adding core/src/main/java/org/icepush/servlet/ServletResponse.java
Sending core/src/main/java/org/icepush/servlet/ThreadBlockingAdaptingServlet.java
Transmitting file data ...................................
Committed revision 38707.
Sending core-ee/src/main/java/com/icesoft/icepush/AdjustHeartbeatServer.java
Sending core-ee/src/main/java/com/icesoft/icepush/BrowserBoundServlet.java
Sending eps/src/main/java/com/icesoft/push/servlet/BrowserBoundServlet.java
Transmitting file data ...
Committed revision 36090.