ICEpush
  1. ICEpush
  2. PUSH-281

Make the BrowserBoundServlet's inner classes for handling .icepush requests extensible

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.3, EE-3.3.0.GA_P01
    • Fix Version/s: 4.0.BETA, 4.0
    • Component/s: Push Library
    • Labels:
      None
    • Environment:
      ICEpush

      Description

      In order to be able to extend the BrowserBoundServlet's inner classes for handling .icepush requests to add or modify their behavior, we should make this inner classes protected and add protected methods for creating them. This way subclasses of the BrowserBoundServlet can extend the classes and override the methods in order for the overridden subclasses to be utilized.

        Activity

        Jack Van Ooststroom created issue -
        Hide
        Jack Van Ooststroom added a comment -

        Sending core/src/main/java/org/icepush/servlet/BrowserBoundServlet.java
        Sending core/src/main/java/org/icepush/servlet/MainServlet.java
        Transmitting file data ..
        Committed revision 38350.

        Sending core-ee/src/main/java/com/icesoft/icepush/BrowserBoundServlet.java
        Sending core-ee/src/main/java/com/icesoft/icepush/MainServlet.java
        Sending eps/src/main/java/com/icesoft/push/servlet/MainServlet.java
        Transmitting file data ...
        Committed revision 35710.

        Show
        Jack Van Ooststroom added a comment - Sending core/src/main/java/org/icepush/servlet/BrowserBoundServlet.java Sending core/src/main/java/org/icepush/servlet/MainServlet.java Transmitting file data .. Committed revision 38350. Sending core-ee/src/main/java/com/icesoft/icepush/BrowserBoundServlet.java Sending core-ee/src/main/java/com/icesoft/icepush/MainServlet.java Sending eps/src/main/java/com/icesoft/push/servlet/MainServlet.java Transmitting file data ... Committed revision 35710.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #38350 Thu Oct 03 09:15:16 MDT 2013 jack.van.ooststroom Fixed JIRA PUSH-281 : Make the BrowserBoundServlet's inner classes for handling .icepush requests extensible
        Files Changed
        Commit graph MODIFY /icepush/trunk/icepush/core/src/main/java/org/icepush/servlet/MainServlet.java
        Commit graph MODIFY /icepush/trunk/icepush/core/src/main/java/org/icepush/servlet/BrowserBoundServlet.java
        Hide
        Jack Van Ooststroom added a comment -

        Introduced new protected methods for creating the inner classes and changed the inner classes to protected in order for overriding to be allowed. Marking this one as FIXED.

        Show
        Jack Van Ooststroom added a comment - Introduced new protected methods for creating the inner classes and changed the inner classes to protected in order for overriding to be allowed. Marking this one as FIXED.
        Jack Van Ooststroom made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Fix Version/s 4.0.BETA [ 10971 ]
        Ken Fyten made changes -
        Fix Version/s 4.0 [ 11383 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Jack Van Ooststroom
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: