ICEpush
  1. ICEpush
  2. PUSH-271

Move getBrowserID (from Header or Cookie) into Browser class

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 3.3, EE-3.3.0.GA_P01
          • Fix Version/s: 4.0.BETA, 4.0
          • Component/s: Push Library
          • Labels:
            None
          • Environment:
            ICEpush

            Description

            Currently ICEpush has various duplicate locations for getting the Browser-ID from a Header or a Cookie. This logic should be moved to the new Browser class and used throughout.

              Activity

              Ascending order - Click to sort in descending order
              Jack Van Ooststroom created issue -
              Jack Van Ooststroom made changes -
              Field Original Value New Value
              Fix Version/s 3.4 [ 10971 ]
              Fix Version/s EE-3.4.0.GA [ 11170 ]
              Jack Van Ooststroom made changes -
              Assignee Jack Van Ooststroom [ jack.van.ooststroom ]
              Jack Van Ooststroom made changes -
              Status Open [ 1 ] In Progress [ 3 ]
              Hide
              Permalink
              Jack Van Ooststroom added a comment -

              Sending src/main/java/org/icepush/Browser.java
              Sending src/main/java/org/icepush/PushContext.java
              Sending src/main/java/org/icepush/servlet/BrowserDispatcher.java
              Transmitting file data ...
              Committed revision 37780.

              Show
              Jack Van Ooststroom added a comment - Sending src/main/java/org/icepush/Browser.java Sending src/main/java/org/icepush/PushContext.java Sending src/main/java/org/icepush/servlet/BrowserDispatcher.java Transmitting file data ... Committed revision 37780.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #37780 Wed Sep 04 18:05:32 MDT 2013 jack.van.ooststroom Fixed JIRA PUSH-271 : Move getBrowserID (from Header or Cookie) into Browser class
              Files Changed
              Commit graph MODIFY /icepush/trunk/icepush/core/src/main/java/org/icepush/Browser.java
              Commit graph MODIFY /icepush/trunk/icepush/core/src/main/java/org/icepush/servlet/BrowserDispatcher.java
              Commit graph MODIFY /icepush/trunk/icepush/core/src/main/java/org/icepush/PushContext.java
              Hide
              Permalink
              Jack Van Ooststroom added a comment -

              A static getBrowserID(HttpServletRequest) : String has been added to the Browser class to consolidate the logic. Underneath the method gets the Browser-ID from the different spots. Marking this one as FIXED.

              Show
              Jack Van Ooststroom added a comment - A static getBrowserID(HttpServletRequest) : String has been added to the Browser class to consolidate the logic. Underneath the method gets the Browser-ID from the different spots. Marking this one as FIXED.
              Jack Van Ooststroom made changes -
              Status In Progress [ 3 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Fix Version/s 4.0 [ 11383 ]
              Fix Version/s EE-4.0.0.GA [ 11170 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Jack Van Ooststroom
                  Reporter:
                  Jack Van Ooststroom
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: