Details
-
Type: Improvement
-
Status: Closed
-
Priority: Major
-
Resolution: Fixed
-
Affects Version/s: 2.0-Alpha2
-
Fix Version/s: 2.0-Alpha3
-
Component/s: Push Library
-
Labels:None
-
Environment:n/a
Description
It will be very useful in development to log a warning when PushContext.push(String group) is called for a non-existent group. Currently, the group name is treated as a single pushId if the group does not exist, but we could still check if that pushId exists, and if not, log a warning. This will improve the monitoring capabilities of an ICEpush application.
Note that in a clustered environment a node may have no knowledge of a particular group, and a warning might be erroneously logged.
Note that in a clustered environment a node may have no knowledge of a particular group, and a warning might be erroneously logged.
Activity
Philip Breau
created issue -
Deryk Sinotte
made changes -
Field | Original Value | New Value |
---|---|---|
Summary | Log a warning when pusing to a non-existent group | Log a warning when pushing to a non-existent group |
Fix Version/s | 1.0-Alpha2 [ 10223 ] | |
Assignee Priority | P2 | |
Affects Version/s | 1.0-Alpha2 [ 10223 ] | |
Assignee | Mircea Toma [ mircea.toma ] |
Mircea Toma
made changes -
Affects Version/s | 1.0-Alpha3 [ 10224 ] | |
Affects Version/s | 1.0-Alpha2 [ 10223 ] |
Mircea Toma
made changes -
Fix Version/s | 1.0-Alpha3 [ 10224 ] | |
Fix Version/s | 1.0-Alpha2 [ 10223 ] | |
Affects Version/s | 1.0-Alpha2 [ 10223 ] | |
Affects Version/s | 1.0-Alpha3 [ 10224 ] |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #20743 | Mon Feb 22 16:05:31 MST 2010 | mircea.toma | |
Files Changed | ||||
MODIFY
/scratchpads/snowplow/core/src/main/java/org/icepush/PushContext.java
ADD /scratchpads/snowplow/core/src/main/java/org/icepush/VetoedSet.java |
Mircea Toma
made changes -
Status | Open [ 1 ] | Resolved [ 5 ] |
Resolution | Fixed [ 1 ] |
Philip Breau
made changes -
Comment |
[ Is that warning from auction occurring because of the older icepush.jar version currently used in Glimmer? Can't we just check in the PushGroupManager impl like so: ] |
Ken Fyten
made changes -
Status | Resolved [ 5 ] | Closed [ 6 ] |
Assignee Priority | P2 |
Keep track of registered pushIDs to log warning when rogue pushIDs are used. To avoid extensive group scanning on each notification call a special Set implementation is used. Its implementation keeps track of the number of times a pushId is used to avoid removing it from the set of registered pushIds if multiple groups own the same pushId.