ICEpdf
  1. ICEpdf
  2. PDF-929

Square and Circle Annotation Handler fill colour not being respected.

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 6.0
          • Fix Version/s: 6.0.1
          • Component/s: Viewer RI
          • Labels:
            None
          • Environment:
            PRO, 6.0 and earlier.

            Description

            A client is using our Viewer RI implementation to write square annotations. They have discovered that the SquareAnnotaitonHandler and CircleAnnotaitonHander can not have there fill colour defined.

            I've take a closer look and this is true, the system property org.icepdf.core.views.page.annotation.squareCircle.fill.color is actually being set but we don't do anything with it. Geometric shaped annotations also need a flag to indicate that a fill colour should be used.

              Activity

              Ascending order - Click to sort in descending order
              Patrick Corless created issue -
              Patrick Corless made changes -
              Field Original Value New Value
              Fix Version/s 6.0.1 [ 12071 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #46119 Mon Oct 26 10:43:14 MDT 2015 patrick.corless PDF-929 reworked handler to insure background colour system properties sill be respected.
              Files Changed
              Commit graph MODIFY /icepdf/branches/icepdf-6.0.0_P01/icepdf/viewer/src/org/icepdf/ri/common/tools/SquareAnnotationHandler.java
              Hide
              Permalink
              Patrick Corless added a comment -

              Turns out the SquareAnnotationhandler implementation was not quite complete and when the system property org.icepdf.core.views.page.annotation.squareCircle.fill.color is used nothing will happen. I've made a few code changes to insure the property will be respected. The first is the addition of the boolean system property org.icepdf.core.views.page.annotation.squareCircle.fill.enabled which is false by default. So in order to enable a black filled box by default the following system properties should be used.

              org.icepdf.core.views.page.annotation.squareCircle.stroke.color=#000000
              org.icepdf.core.views.page.annotation.squareCircle.fill.enabled = true
              org.icepdf.core.views.page.annotation.squareCircle.fill.color=#000000

              A news system property, org.icepdf.core.views.page.annotation.squareCircle.stroke.width=3.0 has been added to change the default stroke width.

              Show
              Patrick Corless added a comment - Turns out the SquareAnnotationhandler implementation was not quite complete and when the system property org.icepdf.core.views.page.annotation.squareCircle.fill.color is used nothing will happen. I've made a few code changes to insure the property will be respected. The first is the addition of the boolean system property org.icepdf.core.views.page.annotation.squareCircle.fill.enabled which is false by default. So in order to enable a black filled box by default the following system properties should be used. org.icepdf.core.views.page.annotation.squareCircle.stroke.color=#000000 org.icepdf.core.views.page.annotation.squareCircle.fill.enabled = true org.icepdf.core.views.page.annotation.squareCircle.fill.color=#000000 A news system property, org.icepdf.core.views.page.annotation.squareCircle.stroke.width=3.0 has been added to change the default stroke width.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #46120 Mon Oct 26 10:53:44 MDT 2015 patrick.corless PDF-929 reworked handler to insure background colour system properties sill be respected.
              Files Changed
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/src/org/icepdf/ri/common/tools/SquareAnnotationHandler.java
              Hide
              Permalink
              Patrick Corless added a comment -

              Marking as fixed.

              Show
              Patrick Corless added a comment - Marking as fixed.
              Patrick Corless made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Patrick Corless made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Patrick Corless
                  Reporter:
                  Patrick Corless
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: