ICEpdf
  1. ICEpdf
  2. PDF-825

PageViewComponentImpl dirty Time not shutting down dispose

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 5.1
          • Fix Version/s: 5.1.1
          • Component/s: Viewer RI
          • Labels:
            None
          • Environment:
            Viewer RI

            Description

            A customer has reported that an instance of javax.swing.Timer is not being correctly shutdown when the Viewer RI SwingController is disposed.

              Activity

              Ascending order - Click to sort in descending order
              Patrick Corless created issue -
              Patrick Corless made changes -
              Field Original Value New Value
              Summary PageViewComponentImpl dirty Time nut shutting down dispose PageViewComponentImpl dirty Time not shutting down dispose
              Hide
              Permalink
              Patrick Corless added a comment -

              As part of work down around the issue PDF-754 the isDirtyTimer() timer was moved to a static declaration to try and simplify the number of object's created. The side effect as noted by the customer is that the java.util.Timer class is not correctly disposed. This only shows up on applications that user ICEpdf as part of a larger application .

              Will push the timer creation out the documentViewModel and will remove the static declaration. This will insure the Timer is property disposed on a document by document bases.

              Show
              Patrick Corless added a comment - As part of work down around the issue PDF-754 the isDirtyTimer() timer was moved to a static declaration to try and simplify the number of object's created. The side effect as noted by the customer is that the java.util.Timer class is not correctly disposed. This only shows up on applications that user ICEpdf as part of a larger application . Will push the timer creation out the documentViewModel and will remove the static declaration. This will insure the Timer is property disposed on a document by document bases.
              Patrick Corless made changes -
              Fix Version/s 5.1.1 [ 11770 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #43065 Mon Oct 20 11:23:16 MDT 2014 patrick.corless PDF-825 correctly dirty timer not being shutdown when document is closed.
              Files Changed
              Commit graph MODIFY /icepdf/branches/icepdf-5.0.1/icepdf/viewer/src/org/icepdf/ri/common/views/PageViewComponentImpl.java
              Commit graph MODIFY /icepdf/branches/icepdf-5.0.1/icepdf/viewer/src/org/icepdf/ri/common/views/AbstractDocumentViewModel.java
              Commit graph MODIFY /icepdf/branches/icepdf-5.0.1/icepdf/viewer/src/org/icepdf/ri/common/views/DocumentViewModel.java
              Hide
              Permalink
              Patrick Corless added a comment -

              Fix appears to be valid, marking as resolved.

              Show
              Patrick Corless added a comment - Fix appears to be valid, marking as resolved.
              Patrick Corless made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Judy Guglielmin made changes -
              Support Case References https://icesoft.my.salesforce.com/5007000000qMppJ?srPos=0&srKp=500 support case 13101
              Patrick Corless made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Patrick Corless
                  Reporter:
                  Patrick Corless
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: