ICEpdf
  1. ICEpdf
  2. PDF-781

PageViewComponent buffer is larger then needed

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 5.0.6_P01
    • Fix Version/s: 5.0.7
    • Component/s: Viewer RI
    • Labels:
      None
    • Environment:
      any, Viewer RI

      Description

      While working though an issue related to an empty page buffer being painted I noticed there was a bug in how our page buffers where created. Basically at various zoom levels the buffers width or height could be many times larger then needed and as a result we are using significantly more memory then we have too.

      The extra size was being clipped the but the larger then needed BufferedImage was still being created. This should drastically reduce the amount of memory being used by the RI especially when using a column page view.

        Activity

        Patrick Corless created issue -
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #41825 Mon Jul 21 14:36:41 MDT 2014 patrick.corless PDF-781 fixed a bug when constructing the Page buffer size which was causing the buffer to be quite a bit larger then needed.
        Files Changed
        Commit graph MODIFY /icepdf/branches/icepdf-5.0.1/icepdf/viewer/src/org/icepdf/ri/common/views/PageViewComponentImpl.java
        Hide
        Patrick Corless added a comment -

        Buffer tests are complete and after further audits the buffer is being created at the minimal size required. I've also reword the math around the system properties

        org.icepdf.core.views.buffersize.vertical and org.icepdf.core.views.buffersize.horizontal. Previouisly the default values were some strange 1.012 double value. The new default is 1.25 which means the buffer will be 25% larger then the default viewport but no larger then the bounding page dimensions.

        Show
        Patrick Corless added a comment - Buffer tests are complete and after further audits the buffer is being created at the minimal size required. I've also reword the math around the system properties org.icepdf.core.views.buffersize.vertical and org.icepdf.core.views.buffersize.horizontal. Previouisly the default values were some strange 1.012 double value. The new default is 1.25 which means the buffer will be 25% larger then the default viewport but no larger then the bounding page dimensions.
        Patrick Corless made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 5.0.7 [ 11470 ]
        Resolution Fixed [ 1 ]
        Patrick Corless made changes -
        Fix Version/s 5.1 [ 10675 ]
        Fix Version/s 5.0.7 [ 11470 ]
        Patrick Corless made changes -
        Fix Version/s 5.0.7 [ 11470 ]
        Fix Version/s 5.1 [ 10675 ]
        Patrick Corless made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Patrick Corless
            Reporter:
            Patrick Corless
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: