Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 3.1
-
Fix Version/s: 4.0 - Beta, 4.0
-
Component/s: Viewer RI
-
Labels:None
-
Environment:any
Description
Page 3 (1 match)
- the found <b>text</b> in context of sentence..
Page 9 (3 match)
- the found <b>text</b> in context of sentence..
- the found <b>text</b> in context of sentence..
- the found <b>text</b> in context of sentence..
Page 11 (1 match)
- the found <b>text</b> in context of sentence..
When any node in the tree is selected the viewer will navigate the page where the hits are found. Search highlighting will show the page hits on the page.
I think the Search API will have to updated so that a search method will return the LineText in which the terms where found.
Activity
- All
- Comments
- History
- Activity
- Remote Attachments
- Subversion
Can you update the search results page nodes to have the following format. Mainly "Page X (Y match)" where match can be plural.
Also could you add a new search checkbox that will optionally add the Page nodes. The check box would be enabled by default. You'll have to change the flow layout a bit to handle the below layout.
....
| _Case-Sensitive | _ Whole Words only |
| _ Show Pages | _ Cumulative |
...
When Show pages is enabled the search will show the page nodes. when disabled it will only show the search context result nodes. It would be nice if this could be done on the fly but suspect it can only be done for the next search.
tasks
1. change page search label format
2. add new "Show Pages" check box (only works on 'next' search)
3. try to get the "show Pages" to work dynamically regardless of search state.
I've checked in some updates for the latest batch of functionality.
A "Show Pages" checkbox was added, but the single column layout was preserved as compared to the side by side view, since that looked broken with the default width of the sliding panel. When checked then parent nodes with "Page X (Y match)" will be added to the tree, with the text preview results as children. Otherwise the search context nodes are added directly to the root node.
Also the root node had some logic to display a default title if one couldn't be found for the document, but it wasn't accounting for blank titles (only null), so I fixed that. I also made it so the root node just hides itself if there is no document title, since we were putting on the same label as the title for the scroll panel.
Carlo I did a quick review and the changes look good. Please mark this bug resolved so we can file for the beta release.
Thanks for the double check Pat, marking it resolved now.
I also recently checked in a change that wraps the search panel in a JScrollPane (with vertical and horizontal scrollbars as needed). This is useful for extremely short or narrow resizes of the UI.
Recently reduced the minimum size of the search results so they can be compressed and still usable.
Functionality complete for 4.0 release.