ICEpdf
  1. ICEpdf
  2. PDF-66

Update Text Search results list view.

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 3.1
          • Fix Version/s: 4.0 - Beta, 4.0
          • Component/s: Viewer RI
          • Labels:
            None
          • Environment:
            any

            Description

            Updated search results JList with a JTree. Th updated results view would look something like:

            Page 3 (1 match)
               - the found <b>text</b> in context of sentence..
            Page 9 (3 match)
               - the found <b>text</b> in context of sentence..
               - the found <b>text</b> in context of sentence..
               - the found <b>text</b> in context of sentence..
            Page 11 (1 match)
               - the found <b>text</b> in context of sentence..

            When any node in the tree is selected the viewer will navigate the page where the hits are found. Search highlighting will show the page hits on the page.

            I think the Search API will have to updated so that a search method will return the LineText in which the terms where found.

              Activity

              Ascending order - Click to sort in descending order
              Patrick Corless created issue -
              Patrick Corless made changes -
              Field Original Value New Value
              Assignee Patrick Corless [ patrick.corless ] Carlo Guglielmin [ carlo.guglielmin ]
              Patrick Corless made changes -
              Salesforce Case []
              Fix Version/s 3.2 [ 10212 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #19609 Wed Nov 04 15:06:43 MST 2009 carlo.guglielmin PDF-66 - changed the JList to a JTree with each search result separately visible, with the matching word bolded.
              Files Changed
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/src/org/icepdf/ri/util/SearchTextTask.java
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/src/org/icepdf/ri/common/SearchPanel.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #19636 Fri Nov 06 12:28:13 MST 2009 patrick.corless PDF-66 reword the search tree to so that it is build on the awt thread and not searching more then needed.
              Files Changed
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/src/org/icepdf/ri/util/SearchTextTask.java
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/src/org/icepdf/ri/common/SearchPanel.java
              Hide
              Permalink
              Patrick Corless added a comment -

              Functionality complete for 4.0 release.

              Show
              Patrick Corless added a comment - Functionality complete for 4.0 release.
              Patrick Corless made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Patrick Corless added a comment -

              Can you update the search results page nodes to have the following format. Mainly "Page X (Y match)" where match can be plural.

              Also could you add a new search checkbox that will optionally add the Page nodes. The check box would be enabled by default. You'll have to change the flow layout a bit to handle the below layout.

              ....

              _Case-Sensitive _ Whole Words only
              _ Show Pages _ Cumulative

              ...

              When Show pages is enabled the search will show the page nodes. when disabled it will only show the search context result nodes. It would be nice if this could be done on the fly but suspect it can only be done for the next search.

              tasks
              1. change page search label format
              2. add new "Show Pages" check box (only works on 'next' search)
              3. try to get the "show Pages" to work dynamically regardless of search state.

              Show
              Patrick Corless added a comment - Can you update the search results page nodes to have the following format. Mainly "Page X (Y match)" where match can be plural. Also could you add a new search checkbox that will optionally add the Page nodes. The check box would be enabled by default. You'll have to change the flow layout a bit to handle the below layout. .... _Case-Sensitive _ Whole Words only _ Show Pages _ Cumulative ... When Show pages is enabled the search will show the page nodes. when disabled it will only show the search context result nodes. It would be nice if this could be done on the fly but suspect it can only be done for the next search. tasks 1. change page search label format 2. add new "Show Pages" check box (only works on 'next' search) 3. try to get the "show Pages" to work dynamically regardless of search state.
              Patrick Corless made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #19774 Wed Nov 25 09:42:43 MST 2009 carlo.guglielmin PDF-66 - Added 'Show Pages' checkbox, to either display or hide the parent result nodes. Also changed the text for each page node. Also hide the root node if we can't retrieve a title from the open document.
              Files Changed
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/src/org/icepdf/ri/resources/MessageBundle.properties
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/src/org/icepdf/ri/util/SearchTextTask.java
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/src/org/icepdf/ri/common/SearchPanel.java
              Hide
              Permalink
              Carlo Guglielmin added a comment -

              I've checked in some updates for the latest batch of functionality.

              A "Show Pages" checkbox was added, but the single column layout was preserved as compared to the side by side view, since that looked broken with the default width of the sliding panel. When checked then parent nodes with "Page X (Y match)" will be added to the tree, with the text preview results as children. Otherwise the search context nodes are added directly to the root node.

              Also the root node had some logic to display a default title if one couldn't be found for the document, but it wasn't accounting for blank titles (only null), so I fixed that. I also made it so the root node just hides itself if there is no document title, since we were putting on the same label as the title for the scroll panel.

              Show
              Carlo Guglielmin added a comment - I've checked in some updates for the latest batch of functionality. A "Show Pages" checkbox was added, but the single column layout was preserved as compared to the side by side view, since that looked broken with the default width of the sliding panel. When checked then parent nodes with "Page X (Y match)" will be added to the tree, with the text preview results as children. Otherwise the search context nodes are added directly to the root node. Also the root node had some logic to display a default title if one couldn't be found for the document, but it wasn't accounting for blank titles (only null), so I fixed that. I also made it so the root node just hides itself if there is no document title, since we were putting on the same label as the title for the scroll panel.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #19842 Tue Dec 01 13:19:57 MST 2009 carlo.guglielmin PDF-66 - Updated Show Pages checkbox so it will update the tree format after a search has been completed, so a user can freely toggle between having page nodes or not
              Files Changed
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/src/org/icepdf/ri/util/SearchTextTask.java
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/src/org/icepdf/ri/common/SearchPanel.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #19843 Tue Dec 01 13:57:12 MST 2009 carlo.guglielmin PDF-66 - Cleaned up the code for when Show Pages is deselected and we want to explode the page nodes into leafs. This resulted in faster behaviour as we're not doing unnecessary extra loops or reloading of the tree
              Files Changed
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/src/org/icepdf/ri/common/SearchPanel.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #19844 Tue Dec 01 14:15:14 MST 2009 carlo.guglielmin PDF-66 - Minor change to wrap the inserted nodes when Show Pages is deselected
              Files Changed
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/src/org/icepdf/ri/common/SearchPanel.java
              Hide
              Permalink
              Patrick Corless added a comment -

              Carlo I did a quick review and the changes look good. Please mark this bug resolved so we can file for the beta release.

              Show
              Patrick Corless added a comment - Carlo I did a quick review and the changes look good. Please mark this bug resolved so we can file for the beta release.
              Hide
              Permalink
              Carlo Guglielmin added a comment -

              Thanks for the double check Pat, marking it resolved now.

              Show
              Carlo Guglielmin added a comment - Thanks for the double check Pat, marking it resolved now.
              Carlo Guglielmin made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Carlo Guglielmin added a comment -

              I also recently checked in a change that wraps the search panel in a JScrollPane (with vertical and horizontal scrollbars as needed). This is useful for extremely short or narrow resizes of the UI.

              Show
              Carlo Guglielmin added a comment - I also recently checked in a change that wraps the search panel in a JScrollPane (with vertical and horizontal scrollbars as needed). This is useful for extremely short or narrow resizes of the UI.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #20007 Wed Dec 16 15:37:21 MST 2009 carlo.guglielmin PDF-66 - Lowered the minimum size to the search results so that they compress better for very short windows
              Files Changed
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/src/org/icepdf/ri/common/SearchPanel.java
              Hide
              Permalink
              Carlo Guglielmin added a comment -

              Recently reduced the minimum size of the search results so they can be compressed and still usable.

              Show
              Carlo Guglielmin added a comment - Recently reduced the minimum size of the search results so they can be compressed and still usable.
              Ken Fyten made changes -
              Fix Version/s 4.0 [ 10222 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Carlo Guglielmin
                  Reporter:
                  Patrick Corless
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: