ICEpdf
  1. ICEpdf
  2. PDF-619

Text Markup annotations tool can result in duplicate annotations being created

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 5.0.2
    • Fix Version/s: 5.0.3
    • Component/s: Viewer RI
    • Labels:
      None
    • Environment:
      any

      Description

      This issue is related to 618. When testing PDF-618 it was noticed that more then one text markup annotation was being created when using the UI tools. The reason for this is the text selection was not being cleared on mouse up resulting in every subsequent mouse up creating a new annotation in the same location and of same type.

        Issue Links

          Activity

          Patrick Corless created issue -
          Patrick Corless made changes -
          Field Original Value New Value
          Link This issue blocks PDF-618 [ PDF-618 ]
          Hide
          Patrick Corless added a comment -

          I've reworked the mouse calls and we are now call the super.MouseRelease() of TextSelectionPageHandler resulting in he proper clearing of selected text. So no more duplicates.

          Show
          Patrick Corless added a comment - I've reworked the mouse calls and we are now call the super.MouseRelease() of TextSelectionPageHandler resulting in he proper clearing of selected text. So no more duplicates.
          Hide
          Patrick Corless added a comment -

          Updated both the trunk and 5.0.1 branch with fix.

          Show
          Patrick Corless added a comment - Updated both the trunk and 5.0.1 branch with fix.
          Patrick Corless made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #36969 Tue Jul 16 11:36:20 MDT 2013 patrick.corless PDF-619 updated HighlightAnnotationHandler to correctly deselect test and corresponding method calls in AbstractPageViewComponent.
          Files Changed
          Commit graph MODIFY /icepdf/branches/icepdf-5.0.1/icepdf/viewer/src/org/icepdf/ri/common/views/AbstractPageViewComponent.java
          Commit graph MODIFY /icepdf/branches/icepdf-5.0.1/icepdf/viewer/src/org/icepdf/ri/common/tools/HighLightAnnotationHandler.java
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #36970 Tue Jul 16 11:36:44 MDT 2013 patrick.corless PDF-619 updated HighlightAnnotationHandler to correctly deselect test and corresponding method calls in AbstractPageViewComponent.
          Files Changed
          Commit graph MODIFY /icepdf/trunk/icepdf/viewer/src/org/icepdf/ri/common/views/AbstractPageViewComponent.java
          Commit graph MODIFY /icepdf/trunk/icepdf/viewer/src/org/icepdf/ri/common/tools/HighLightAnnotationHandler.java
          Patrick Corless made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Patrick Corless
              Reporter:
              Patrick Corless
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: