Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 5.0
-
Fix Version/s: 6.3
-
Component/s: Core/Parsing
-
Labels:None
-
Environment:any
-
Support Case References:Support Case 14253:- https://icesoft.my.salesforce.com/5000g00001orMCb?srPos=0&srKp=500
-
Salesforce Case Reference:
Description
The file in question is contains content stream encoded using the FlateDecode filter. ICEpdf currently relies on the java.util.ZipInflaterInputStream to handle the decompression. Unfortunately the ZipInflaterInputStream is chocking on this stream.
After quite a bit of tracing it became apparent that is was the last ZipInflaterInputStream.read call that was reporting the error. The only way that I could get all the needed content tokens was to set the buffer to 1 byte as a work around. The problem with he 1 byte buffer is that it isn't performant.
After quite a bit of tracing it became apparent that is was the last ZipInflaterInputStream.read call that was reporting the error. The only way that I could get all the needed content tokens was to set the buffer to 1 byte as a work around. The problem with he 1 byte buffer is that it isn't performant.
Activity
Suggesting work around for the time being.
Show
Patrick Corless
added a comment - Suggesting work around for the time being.
| Field | Original Value | New Value |
|---|---|---|
| Status | Open [ 1 ] | Resolved [ 5 ] |
| Fix Version/s | 5.0.1 [ 10872 ] | |
| Resolution | Fixed [ 1 ] |
| Support Customer Ref. #s | 12113 |
| Support Customer Ref. #s | 12113 |
| Salesforce Case Reference | 5007000000T59dAAAR |
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #34438 | Thu Apr 18 10:19:59 MDT 2013 | patrick.corless | |
| Files Changed | ||||
MODIFY
/icepdf/trunk/icepdf/core/src/org/icepdf/core/pobjects/filters/ChunkingInputStream.java
MODIFY
/icepdf/trunk/icepdf/core/src/org/icepdf/core/pobjects/filters/FlateDecode.java
|
Reopening issue with the hope of finding a more performant work around.
Show
Patrick Corless
added a comment - Reopening issue with the hope of finding a more performant work around.
| Resolution | Fixed [ 1 ] | |
| Status | Resolved [ 5 ] | Reopened [ 4 ] |
| Fix Version/s | 5.0.5 [ 11373 ] | |
| Fix Version/s | 5.0.1 [ 10872 ] |
Re-opened this issue. There are a few open source zip libraries out there that could possible fix this issue and be a little quicker then the default java implementation.
Show
Patrick Corless
added a comment - Re-opened this issue. There are a few open source zip libraries out there that could possible fix this issue and be a little quicker then the default java implementation.
| Fix Version/s | 5.0.6 [ 11381 ] | |
| Fix Version/s | 5.0.5 [ 11373 ] |
| Fix Version/s | 5.0.7 [ 11470 ] | |
| Fix Version/s | 5.0.6 [ 11381 ] |
| Fix Version/s | 5.1 [ 10675 ] | |
| Fix Version/s | 5.0.7 [ 11470 ] |
| Fix Version/s | 5.2 [ 10970 ] | |
| Fix Version/s | 5.1 [ 10675 ] |
| Fix Version/s | 5.2 [ 10970 ] |
| Fix Version/s | 6.3 [ 13093 ] |
I've revisited this on request from a support customer. I've touched up the flate decode to check the stream length and adjust the buffer size appropriately. By default the decode will try and use a rather large 16 KB buffer and will fall back to 2 KB buffer if the stream is really small.
Show
Patrick Corless
added a comment - I've revisited this on request from a support customer. I've touched up the flate decode to check the stream length and adjust the buffer size appropriately. By default the decode will try and use a rather large 16 KB buffer and will fall back to 2 KB buffer if the stream is really small.
| Status | Reopened [ 4 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #52121 | Tue Dec 05 09:29:21 MST 2017 | patrick.corless | buffer size for decoding small sized streams. |
| Files Changed | ||||
|
MODIFY
/icepdf/trunk/icepdf/core/core-awt/src/main/java/org/icepdf/core/pobjects/filters/FlateDecode.java
|
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #52153 | Wed Dec 13 10:53:36 MST 2017 | patrick.corless | buffer size for decoding small sized streams. |
| Files Changed | ||||
|
MODIFY
/icepdf/branches/icepdf-6.2.0/icepdf/core/src/org/icepdf/core/pobjects/filters/FlateDecode.java
|
| Support Case References | Support Case 14253:- https://icesoft.my.salesforce.com/5000g00001orMCb?srPos=0&srKp=500 |
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #52213 | Tue Jan 16 13:01:53 MST 2018 | patrick.corless | been seeing when a stream does not contain the correct end of steam bytes. |
| Files Changed | ||||
|
MODIFY
/icepdf/trunk/icepdf/core/core-awt/src/main/java/org/icepdf/core/pobjects/filters/FlateDecode.java
|
| Status | Resolved [ 5 ] | Closed [ 6 ] |
I've added the system property org.icepdf.core.flateDecode.bufferSize to allow users to set the default buffer size which ~16KB. For large file the buffer could be set higher to improve performance. But for this client they will have to set org.icepdf.core.flateDecode.bufferSize=1 for the the time being.