ICEpdf
  1. ICEpdf
  2. PDF-554

Borders with null colours are being painted black

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 5.0.0 alpha1, 5.0.0 beta1
          • Fix Version/s: 5.0
          • Component/s: Core/Parsing, Viewer RI
          • Labels:
            None
          • Environment:
            any

            Description

            There was one PDF in the QA test suite that had an link annotation border where it shouldn't have. After a closer look the border was setup to show a border with the exception of now colour definition. Our Annotation init method had a new call that would apply a black color if no colour was found. As it turns out this assumption was incorrect. So I reverted the logic to keep a null colour an updated the border panel in the viewer RI to set the colour to black if now colour was defined when setting the border as visible.

              Activity

              Ascending order - Click to sort in descending order
              Patrick Corless created issue -
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #34229 Thu Apr 04 13:57:26 MDT 2013 patrick.corless PDF-554 changed default border color back to null and updated the border UI to set the border color if none is already defined when making a border visible.
              Files Changed
              Commit graph MODIFY /icepdf/trunk/icepdf/core/src/org/icepdf/core/pobjects/annotations/Annotation.java
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/src/org/icepdf/ri/common/utility/annotation/BorderPanel.java
              Hide
              Permalink
              Patrick Corless added a comment -

              Marking as resolved

              Show
              Patrick Corless added a comment - Marking as resolved
              Patrick Corless made changes -
              Field Original Value New Value
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #34230 Thu Apr 04 14:21:20 MDT 2013 patrick.corless PDF-554 added cmyk black level configuration system property org.icepdf.core.cmyk.black, default is 255, lower values will darken, higher values will lighten the resultant rgb colour.
              Files Changed
              Commit graph MODIFY /icepdf/trunk/icepdf/core/src/org/icepdf/core/pobjects/ImageUtility.java
              Patrick Corless made changes -
              Fix Version/s 5.0 [ 10314 ]
              Patrick Corless made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Patrick Corless
                  Reporter:
                  Patrick Corless
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: