ICEpdf
  1. ICEpdf
  2. PDF-46

Remove X0R draw code from annotation painting

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.1
    • Component/s: Core/Parsing
    • Labels:
      None
    • Environment:
      Sun JDK 1.6 >, windows with direct 3D support
    • Assignee Priority:
      P1

      Description

      Java JDK 1.6 for windows introduced direct 3D support for Java2d out of the box. For the most part his works well and speeds up most drawing operations. However there is no equivalent call for Java2D's xor paint type in direct 3d.

      We use xor painting for mouse over effects of certain annotation types and as a result see painting and performance issues. Direct 3D is only supported on windows so this is a windows only problem. Probably the best fix is to replace the xor paint with some configurable alpha blend.

        Activity

        Patrick Corless created issue -
        Patrick Corless made changes -
        Field Original Value New Value
        Salesforce Case []
        Fix Version/s 3.1 [ 10181 ]
        Ken Fyten made changes -
        Salesforce Case []
        Assignee Priority P1
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #19366 Wed Oct 07 17:31:09 MDT 2009 patrick.corless PDF-46 - removed xor draw code as it was messing up directX on windows in JDK 1.6. Replaces with a black fill that has a 0.4f composite value. Default values can be overridden using system properties, see the jira for more information.
        Files Changed
        Commit graph MODIFY /icepdf/trunk/icepdf/core/src/org/icepdf/core/views/swing/PageViewComponentImpl.java
        Patrick Corless made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        Patrick Corless added a comment -

        Updated the PageViewComponentImpl to no longer use an xor fill for painting the annotation highlight states. Replaced with an configurable composite value. There are now two system properties that control the annotation highlight effects: one for fill color and the other for the alpha value.

        Fill Colors.
        Can be any valid html colour value, text or hex. The default value is black but can be overridden with the system property org.icepdf.core.views.page.annotation.highlight.color .

        Fill Alpha
        Controls the composite fill value, 0f is completely transparent where a value of 1.0f is complete opaque. The default value is 0.4f but can be overridden with the system property org.icepdf.core.views.page.annotation.highlight.alpha .

        Show
        Patrick Corless added a comment - Updated the PageViewComponentImpl to no longer use an xor fill for painting the annotation highlight states. Replaced with an configurable composite value. There are now two system properties that control the annotation highlight effects: one for fill color and the other for the alpha value. Fill Colors. Can be any valid html colour value, text or hex. The default value is black but can be overridden with the system property org.icepdf.core.views.page.annotation.highlight.color . Fill Alpha Controls the composite fill value, 0f is completely transparent where a value of 1.0f is complete opaque. The default value is 0.4f but can be overridden with the system property org.icepdf.core.views.page.annotation.highlight.alpha .
        Patrick Corless made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Patrick Corless added a comment -

        ICEpdf 3.1.0 has been released, closing issues.

        Show
        Patrick Corless added a comment - ICEpdf 3.1.0 has been released, closing issues.
        Patrick Corless made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Patrick Corless
            Reporter:
            Patrick Corless
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: