Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 4.1
-
Fix Version/s: 5.0
-
Component/s: Documentation
-
Labels:None
-
Environment:-
Description
Note from ICEpdf user:
I was browsing http://sventon.icefaces.org/svn/showfile.svn?path=/icepdf/trunk/icepdf/core/src/org/icepdf/core/pobjects/graphics/DeviceCMYK.java&name=repo
and i noticed some code duplication.
The method "alternative1()" and "getAdobeColor()" share the same algorithm; the only difference is the first return's the RGB triplet in it's arithmetic format (0.0 to 1.0) and the second in the digital format (0 to 255).
The methods "getAutoCadColor()" and "getGhostColor()" share the same algorithm too.
For simplicity sake, you would probably want to get rid of the duplicates (or at least document this fact).
I was browsing http://sventon.icefaces.org/svn/showfile.svn?path=/icepdf/trunk/icepdf/core/src/org/icepdf/core/pobjects/graphics/DeviceCMYK.java&name=repo
and i noticed some code duplication.
The method "alternative1()" and "getAdobeColor()" share the same algorithm; the only difference is the first return's the RGB triplet in it's arithmetic format (0.0 to 1.0) and the second in the digital format (0 to 255).
The methods "getAutoCadColor()" and "getGhostColor()" share the same algorithm too.
For simplicity sake, you would probably want to get rid of the duplicates (or at least document this fact).
Activity
- All
- Comments
- History
- Activity
- Remote Attachments
- Subversion
| Field | Original Value | New Value |
|---|---|---|
| Salesforce Case | [] | |
| Fix Version/s | 4.3.3 [ 10333 ] |
| Salesforce Case | [] | |
| Fix Version/s | 4.5 [ 10342 ] | |
| Fix Version/s | 4.3.3 [ 10333 ] |
| Fix Version/s | 5.0 [ 10314 ] | |
| Fix Version/s | 4.5 [ 10342 ] |
| Status | Open [ 1 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
| Status | Resolved [ 5 ] | Closed [ 6 ] |