ICEpdf
  1. ICEpdf
  2. PDF-157

Add default paper size to viewer RI properites file

          Details

          • Type: New Feature New Feature
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 4.0
          • Fix Version/s: 4.1.1
          • Component/s: Viewer RI
          • Labels:
            None
          • Environment:
            any

            Description

            If a had a dollar for every time someone asked for an easy way to change the default printer I would have quite a pile of bills. The propertiesManager which is part of the Viewer RI stores many properties that can change many aspects of the viewer ri at runtime. I would suggest that we add a new property for paper media size and possibly a system property that would allow for named paper sizes to be assigned as the default printer value.

              Activity

              Ascending order - Click to sort in descending order
              Patrick Corless created issue -
              Hide
              Permalink
              Dirk Maass added a comment - - edited

              RI completely ignores previous settings of the viewModel's PrintHelper when printing.
              Attached patch should help.

              Show
              Dirk Maass added a comment - - edited RI completely ignores previous settings of the viewModel's PrintHelper when printing. Attached patch should help.
              Dirk Maass made changes -
              Field Original Value New Value
              Attachment icepdf4.0.1-reusePrintHelper.patch [ 12305 ]
              Patrick Corless made changes -
              Salesforce Case []
              Fix Version/s 4.0.2 [ 10234 ]
              Patrick Corless made changes -
              Fix Version/s 4.1 [ 10227 ]
              Fix Version/s 4.0.2 [ 10234 ]
              Patrick Corless made changes -
              Salesforce Case []
              Fix Version/s 4.1.1 [ 10244 ]
              Fix Version/s 4.1 [ 10227 ]
              Hide
              Permalink
              Dirk Maass added a comment -

              Hi Patrick,
              i hoped to find my patch in version 4.1., as it addresses a real bug and solved some problems (at leat for us) easily. - And without for you having to solve the whole thing (deal with options in viewer RI properties file).
              The issue is now scheduled for 4.1.1, but if you have to reschedule it, I'd appreciate if you could at least review and apply this patch.

              thanks

              regards,
              Dirk

              Show
              Dirk Maass added a comment - Hi Patrick, i hoped to find my patch in version 4.1., as it addresses a real bug and solved some problems (at leat for us) easily. - And without for you having to solve the whole thing (deal with options in viewer RI properties file). The issue is now scheduled for 4.1.1, but if you have to reschedule it, I'd appreciate if you could at least review and apply this patch. thanks regards, Dirk
              Hide
              Permalink
              Patrick Corless added a comment -

              Sorry Dirk, I completely forgot that the you submitted a patch, I was running short of time for 4.1 and just pushed this to 4.1.1 given the bug title. I'll take a look at your patch today.

              Show
              Patrick Corless added a comment - Sorry Dirk, I completely forgot that the you submitted a patch, I was running short of time for 4.1 and just pushed this to 4.1.1 given the bug title. I'll take a look at your patch today.
              Hide
              Permalink
              Patrick Corless added a comment -

              Created PDF-199 to capture the patch improvement. Code is checked in, thanks for the patch.

              Show
              Patrick Corless added a comment - Created PDF-199 to capture the patch improvement. Code is checked in, thanks for the patch.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #22484 Fri Oct 01 11:31:25 MDT 2010 patrick.corless PDF-157 - applied print attributes patch to saves printer attributes between document prints. Also added basic media size attributes to the default properties file, does not currently presist between saves.
              Files Changed
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/src/org/icepdf/ri/common/SwingController.java
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/src/org/icepdf/ri/viewer/res/ICEpdfDefault.properties
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/src/org/icepdf/ri/util/PropertiesManager.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #22497 Mon Oct 04 06:11:34 MDT 2010 patrick.corless PDF-157 - added state saving for paper width, height and unit to the default RI.
              Files Changed
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/src/org/icepdf/ri/common/SwingController.java
              Hide
              Permalink
              Patrick Corless added a comment -

              I've applied the patch as it addresses saving properties from one open document to another. I took a first shot at adding default properties to the UI properties file. When the print dialog or printer job is started the current media size values are saved to the properties manager class. When the viewer RI is closed the propertiesManager writes out its current state to file.

              Show
              Patrick Corless added a comment - I've applied the patch as it addresses saving properties from one open document to another. I took a first shot at adding default properties to the UI properties file. When the print dialog or printer job is started the current media size values are saved to the properties manager class. When the viewer RI is closed the propertiesManager writes out its current state to file.
              Patrick Corless made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Patrick Corless
                  Reporter:
                  Patrick Corless
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: