ICEpdf
  1. ICEpdf
  2. PDF-1249

Improve the stick nature of the PropertiesManager

          Details

          • Type: Improvement Improvement
          • Status: Resolved
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 6.3
          • Fix Version/s: 6.3.1
          • Component/s: Viewer RI
          • Labels:
            None
          • Environment:
            Viewer RI

            Description

            The 6.3 release introduced a fairly major change to the PropertiesManager class (PDF-1182). The changes were intended to update the core functionality of the class for a simpler approach to saving properties. The enhancement also introduced a preferences dialog for the viewer ri for common settings.

            One short site of the API changes was the many settings the didn't persist now automatically did. This had a negative effect on the using the SwingViewBuilder when building custom components. Once a setting was set it had to manually be unset. This has generated a few problems for some of our users.

              Activity

              Ascending order - Click to sort in descending order
              Patrick Corless created issue -
              Hide
              Permalink
              Patrick Corless added a comment -

              The properties manage has been updated to have a local properties store which can be manipulated with checkAndStore*Property() methods which are used by UI building code. Settings that needed to be persisted should directly access the getPreferences():Preferences method. It is possible to write the local properties to the persistence store if desired with a call to saveStoredProperties() method, any existing property is overwritten.

              The PropertiesManager documentation has also be updated to reflect the intended usage.

              Show
              Patrick Corless added a comment - The properties manage has been updated to have a local properties store which can be manipulated with checkAndStore*Property() methods which are used by UI building code. Settings that needed to be persisted should directly access the getPreferences():Preferences method. It is possible to write the local properties to the persistence store if desired with a call to saveStoredProperties() method, any existing property is overwritten. The PropertiesManager documentation has also be updated to reflect the intended usage.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #52362 Wed Mar 28 14:20:29 MDT 2018 patrick.corless PDF-1249 updated PreferenceManager to have a non sticky property cache
              for local properties used to set various spects of the view construction.
              Files Changed
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/viewer-awt/src/main/java/org/icepdf/ri/common/preferences/PreferencesDialog.java
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/viewer-awt/src/main/java/org/icepdf/ri/common/preferences/AnnotationPreferencesPanel.java
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/viewer-awt/src/main/java/org/icepdf/ri/util/PropertiesManager.java
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/viewer-awt/src/main/java/org/icepdf/ri/common/SwingViewBuilder.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #52364 Thu Mar 29 14:10:00 MDT 2018 patrick.corless PDF-1249 touched up issue were default properties are not being added to
              the local properties.
              Files Changed
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/viewer-awt/src/main/java/org/icepdf/ri/util/PropertiesManager.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #52365 Thu Mar 29 14:12:17 MDT 2018 patrick.corless PDF-1249 rolled back explicit setting of annotation permission vsisibility,
              value is now correctly loaded from default values.
              Files Changed
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/viewer-awt/src/main/java/org/icepdf/ri/common/SwingViewBuilder.java
              Patrick Corless made changes -
              Field Original Value New Value
              Fix Version/s 6.3.1 [ 13113 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #52376 Wed Apr 04 10:03:55 MDT 2018 patrick.corless PDF-1249 touche up a usage case where a client does not include default
              properties resulting a warning message. I've added a catch for the null
              file and added some quieter logging.
              Files Changed
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/viewer-awt/src/main/java/org/icepdf/ri/util/PropertiesManager.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #52377 Wed Apr 04 13:10:37 MDT 2018 patrick.corless PDF-1249 touche up a usage case where a client does not include default
              properties resulting a warning message. I've added a catch for the null
              file and added some quieter logging.
              Files Changed
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/viewer-awt/src/main/java/org/icepdf/ri/util/PropertiesManager.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #52379 Thu Apr 05 08:52:12 MDT 2018 patrick.corless PDF-1249 added back setters for saving local properties.
              Files Changed
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/viewer-awt/src/main/java/org/icepdf/ri/util/PropertiesManager.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #52419 Mon Apr 30 13:40:17 MDT 2018 patrick.corless PDF-1249 increased size of preferences dialog.
              Files Changed
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/viewer-awt/src/main/java/org/icepdf/ri/common/preferences/PreferencesDialog.java
              Hide
              Permalink
              Patrick Corless added a comment -

              Marking as fixed.

              Show
              Patrick Corless added a comment - Marking as fixed.
              Patrick Corless made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]

                People

                • Assignee:
                  Patrick Corless
                  Reporter:
                  Patrick Corless
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: