ICEpdf
  1. ICEpdf
  2. PDF-1209

Improve highlight annotation containment

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 6.2.5
          • Fix Version/s: 6.3
          • Component/s: Viewer RI
          • Labels:
            None
          • Environment:
            Viewer RI

            Description

            When using the highlight markup annotation tools the resulting component behaves as a rectangle even now the highlight shape may be a complex polygon. This rectangular nature makes it hard to selected text that is not marked as highlighted but resides under the component block.

            The way around this is in swing is to make the contains(x,y) method a little smarter. Basically if the mouse is contained in the box we then look a little further to check if the mouse coordinates are also contained in the highlight shape. This address mouse icon state and the propagation of mouse events.

              Activity

              Ascending order - Click to sort in descending order
              Patrick Corless created issue -
              Patrick Corless made changes -
              Field Original Value New Value
              Fix Version/s 6.3 [ 13093 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #52036 Thu Oct 26 10:21:51 MDT 2017 patrick.corless PDF-1209 addition of new contains method for highlight annotations as well
              as added code to make sure that resultant highlight annotation shape is
              contiguous.
              Files Changed
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/viewer-awt/src/main/java/org/icepdf/ri/common/views/PageViewComponentImpl.java
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/viewer-awt/src/main/java/org/icepdf/ri/common/views/annotations/MarkupAnnotationComponent.java
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/viewer-awt/src/main/java/org/icepdf/ri/common/views/annotations/summary/AnnotationSummaryPanel.java
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/viewer-awt/src/main/java/org/icepdf/ri/common/views/annotations/TextAnnotationComponent.java
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/viewer-awt/src/main/java/org/icepdf/ri/common/views/annotations/SquareAnnotationComponent.java
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/viewer-awt/src/main/java/org/icepdf/ri/common/tools/HighLightAnnotationHandler.java
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/viewer-awt/src/main/java/org/icepdf/ri/common/views/annotations/TextMarkupAnnotationComponent.java
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/viewer-awt/src/main/java/org/icepdf/ri/common/views/annotations/PopupAnnotationComponent.java
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/viewer-awt/src/main/java/org/icepdf/ri/common/views/annotations/AnnotationComponentFactory.java
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/viewer-awt/src/main/java/org/icepdf/ri/common/views/annotations/CircleAnnotationComponent.java
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/viewer-awt/src/main/java/org/icepdf/ri/common/views/annotations/LineAnnotationComponent.java
              Commit graph MODIFY /icepdf/trunk/icepdf/core/core-awt/src/main/java/org/icepdf/core/pobjects/annotations/TextMarkupAnnotation.java
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/viewer-awt/src/main/java/org/icepdf/ri/common/views/annotations/InkAnnotationComponent.java
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/viewer-awt/src/main/java/org/icepdf/ri/common/views/annotations/FreeTextAnnotationComponent.java
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/viewer-awt/src/main/java/org/icepdf/ri/common/utility/annotation/markup/MarkupAnnotationHandlerPanel.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #52051 Wed Nov 01 10:58:47 MDT 2017 patrick.corless PDF-1209 addition of rounding rules for word bounds to help smooth out
              text selection of justified paragraph layouts. Buttery smooth...
              Files Changed
              Commit graph MODIFY /icepdf/trunk/icepdf/core/core-awt/src/main/java/org/icepdf/core/pobjects/graphics/text/PageText.java
              Commit graph MODIFY /icepdf/trunk/icepdf/core/core-awt/src/main/java/org/icepdf/core/pobjects/graphics/text/WordText.java
              Hide
              Permalink
              Patrick Corless added a comment -

              Marking as complete.

              Show
              Patrick Corless added a comment - Marking as complete.
              Patrick Corless made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Patrick Corless made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Patrick Corless
                  Reporter:
                  Patrick Corless
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: