ICEpdf
  1. ICEpdf
  2. PDF-118

Fit Width view adds an unnecessary horizontal scrollbar

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 3.1.2, 4.0 - Beta
          • Fix Version/s: 4.0
          • Component/s: Viewer RI
          • Labels:
            None
          • Environment:
            -

            Description

            When selecting the Fit Width view, an unnecessary horizontal scrollbar is added to the PDF viewer.

              Activity

              Ascending order - Click to sort in descending order
              Tyler Johnson created issue -
              Tyler Johnson made changes -
              Field Original Value New Value
              Attachment FIT_TO_WIDTH.jpg [ 12132 ]
              Ken Fyten made changes -
              Salesforce Case []
              Fix Version/s 4.0 [ 10222 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #20204 Wed Jan 13 06:36:49 MST 2010 patrick.corless PDF-118 Updated the page fit alogrithms to better fit page views to width and height.
              Files Changed
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/src/org/icepdf/ri/common/views/DocumentViewControllerImpl.java
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/src/org/icepdf/ri/common/views/AbstractDocumentView.java
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/src/org/icepdf/ri/common/views/TwoPageView.java
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/src/org/icepdf/ri/common/views/TwoColumnPageView.java
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/src/org/icepdf/ri/common/views/OnePageView.java
              Commit graph MODIFY /icepdf/trunk/icepdf/viewer/src/org/icepdf/ri/common/views/OneColumnPageView.java
              Commit graph MODIFY /icepdf/trunk/icepdf/core/src/org/icepdf/core/views/DocumentView.java
              Hide
              Permalink
              Patrick Corless added a comment -

              Updated the page fit algorithms so that fit width and height work more consistently. The old algorithms did not take into consideration the layout manager padding and insets and as a result resorted to a fudge factor for calculating the fit to width or fit to height.

              The four document view types DocumentView.getDocumentSize implementation was updated respectively to calculate a normalized page sized based on a zoom of 1.0f. The DocumentViewControllerImpl could then use this normalized value from each of the four view types to calculate accurate width and hight scaling factors. In most cases no horizontal scroll bar will be present for fit to width and no vertical scroll bar for fit to height for views that are not column based.

              Show
              Patrick Corless added a comment - Updated the page fit algorithms so that fit width and height work more consistently. The old algorithms did not take into consideration the layout manager padding and insets and as a result resorted to a fudge factor for calculating the fit to width or fit to height. The four document view types DocumentView.getDocumentSize implementation was updated respectively to calculate a normalized page sized based on a zoom of 1.0f. The DocumentViewControllerImpl could then use this normalized value from each of the four view types to calculate accurate width and hight scaling factors. In most cases no horizontal scroll bar will be present for fit to width and no vertical scroll bar for fit to height for views that are not column based.
              Patrick Corless made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Tyler Johnson made changes -
              Salesforce Case [5007000000ApPDh]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Patrick Corless
                  Reporter:
                  Tyler Johnson
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: