ICEpdf
  1. ICEpdf
  2. PDF-1144

Removal of cmyk colour caches

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.2.4
    • Component/s: Core/Parsing
    • Labels:
      None
    • Environment:
      any

      Description

      I've been running up against some memory problems with a much larger QA run and it appears the cmyk colou caches may behind the issue. They are unbounded and can be very large in size.

        Activity

        Patrick Corless created issue -
        Patrick Corless made changes -
        Field Original Value New Value
        Fix Version/s 6.2.4 [ 13099 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #51421 Wed Apr 12 14:30:36 MDT 2017 patrick.corless PDF-1144 removal of icc based cache.
        Files Changed
        Commit graph MODIFY /icepdf/trunk/icepdf/core/core-awt/src/main/java/org/icepdf/core/pobjects/graphics/RasterOps/IccCmykRasterOp.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #51422 Wed Apr 12 14:55:15 MDT 2017 patrick.corless PDF-1144 removal of cmyk based cache, possible memory leak.
        Files Changed
        Commit graph MODIFY /icepdf/trunk/icepdf/core/core-awt/src/main/java/org/icepdf/core/pobjects/graphics/DeviceCMYK.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #51423 Wed Apr 12 15:04:32 MDT 2017 patrick.corless PDF-1144 removed cmyk colour caches they are causing a slow memory
        leak on large content sets.
        Files Changed
        Commit graph MODIFY /icepdf/branches/icepdf-6.2.0/icepdf/core/src/org/icepdf/core/pobjects/ImageUtility.java
        Commit graph MODIFY /icepdf/branches/icepdf-6.2.0/icepdf/core/src/org/icepdf/core/pobjects/graphics/RasterOps/IccCmykRasterOp.java
        Commit graph MODIFY /icepdf/branches/icepdf-6.2.0/icepdf/core/src/org/icepdf/core/pobjects/graphics/DeviceCMYK.java
        Hide
        Patrick Corless added a comment -

        I've been able to verify the slow memory leak when the caches are enabled and disabled. If users are running up against peformance issues when using ICC profiles then I suggest they try -Dorg.icepdf.core.cmyk.disableICCProfile=true which can offer significant improvements but at the cost of colour accuracy.

        Show
        Patrick Corless added a comment - I've been able to verify the slow memory leak when the caches are enabled and disabled. If users are running up against peformance issues when using ICC profiles then I suggest they try -Dorg.icepdf.core.cmyk.disableICCProfile=true which can offer significant improvements but at the cost of colour accuracy.
        Patrick Corless made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Patrick Corless made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Patrick Corless
            Reporter:
            Patrick Corless
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: