ICEpdf
  1. ICEpdf
  2. PDF-1130

Error detecting JPEG colour space.

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 6.2.2
          • Fix Version/s: 6.2.4
          • Component/s: Colour, Imaging
          • Labels:
            None
          • Environment:
            any

            Description

            The document in question has a small header image that doesn't appear to have any header data in the stream do indicate which colour model is being used. The pdf colour space for the mage is CMYK and renders the image correctly.

            Our fall back code for missing header data doesn't look at the orginal colour space of the image as defined by the PDF object. I've added a fairly trivial check for CMYK before falling back on YCbCr.

            Need to do a full QA run but the fix should be valid

              Issue Links

              duplicates

              Bug - A problem which impairs or prevents the functions of the product. PDF-1141 Images in PDF are displayed with the wrong colours

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Patrick Corless created issue -
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #50766 Tue Feb 28 09:54:36 MST 2017 patrick.corless PDF-1130 touched up our corner case handling of jpeg without a header definition for colour space.
                Files Changed
                Commit graph MODIFY /icepdf/branches/icepdf-6.2.0/icepdf/core/src/org/icepdf/core/pobjects/ImageStream.java
                Hide
                Permalink
                Patrick Corless added a comment -

                The QA run failed pretty bad so I think we need to dig a little deeper on our end. We have code that tries to figure out which type of APP14 is used so we can figure out which colour mode to apply. Will need to pull out the JPEG spec to see if we are doing the APP14 parsing correctly.

                Show
                Patrick Corless added a comment - The QA run failed pretty bad so I think we need to dig a little deeper on our end. We have code that tries to figure out which type of APP14 is used so we can figure out which colour mode to apply. Will need to pull out the JPEG spec to see if we are doing the APP14 parsing correctly.
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #50767 Tue Feb 28 10:22:43 MST 2017 patrick.corless PDF-1130 reverting changes, need to look at our APP14 parsing code.
                Files Changed
                Commit graph MODIFY /icepdf/branches/icepdf-6.2.0/icepdf/core/src/org/icepdf/core/pobjects/ImageStream.java
                Patrick Corless made changes -
                Field Original Value New Value
                Fix Version/s 6.2.4 [ 13099 ]
                Hide
                Permalink
                Patrick Corless added a comment -

                same colour issue.

                Show
                Patrick Corless added a comment - same colour issue.
                Patrick Corless made changes -
                Link This issue duplicates PDF-1141 [ PDF-1141 ]
                Hide
                Permalink
                Patrick Corless added a comment -

                Marking as fixed.

                Show
                Patrick Corless added a comment - Marking as fixed.
                Patrick Corless made changes -
                Status Open [ 1 ] Resolved [ 5 ]
                Resolution Fixed [ 1 ]
                Patrick Corless made changes -
                Status Resolved [ 5 ] Closed [ 6 ]

                  People

                  • Assignee:
                    Patrick Corless
                    Reporter:
                    Patrick Corless
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    1 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: